rooty/Arduino
1
0
Fork 0
mirror of https://github.com/arduino/Arduino.git synced 2025-01-18 07:52:14 +01:00
Code Issues Releases Activity

Warn about increasing HardwareSerial buffers to > 256

Browse Source 
Properly supporting bigger buffers need better atomicity code, which
isn't implemented yet. Until it is, best to add a warning. See #2405.
This commit is contained in:
Matthijs Kooijman 2015-06-18 16:34:53 +02:00
parent fbb61ffd3c
commit 07c4d958c0
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
hardware/arduino/avr/cores/arduino/HardwareSerial.h
View File

@ -34,6 +34,11 @@
// location from which to read. // location from which to read.
// NOTE: a "power of 2" buffer size is reccomended to dramatically // NOTE: a "power of 2" buffer size is reccomended to dramatically
// optimize all the modulo operations for ring buffers. // optimize all the modulo operations for ring buffers.
// WARNING: When buffer sizes are increased to > 256, the buffer index
// variables are automatically increased in size, but the extra
// atomicity guards needed for that are not implemented. This will
// often work, but occasionally a race condition can occur that makes
// Serial behave erratically. See https://github.com/arduino/Arduino/issues/2405
#if !defined(SERIAL_TX_BUFFER_SIZE) #if !defined(SERIAL_TX_BUFFER_SIZE)
#if (RAMEND < 1000) #if (RAMEND < 1000)
#define SERIAL_TX_BUFFER_SIZE 16 #define SERIAL_TX_BUFFER_SIZE 16