rooty/Arduino
1
0
Fork 0
mirror of https://github.com/arduino/Arduino.git synced 2025-02-20 14:54:31 +01:00
Code Issues Releases Activity

Output column info from compiler error when available

Browse Source
This commit is contained in:
Cristian Maglie 2017-11-07 16:30:38 +01:00 committed by Cristian Maglie
parent b10063a5fe
commit 3d3bb385ad
1 changed files with 20 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
arduino-core/src/cc/arduino/Compiler.java
View File

@ -515,7 +515,17 @@ public class Compiler implements MessageConsumer {
String[] pieces = PApplet.match(s, ERROR_FORMAT);
if (pieces != null) {
String error = pieces[pieces.length - 1], msg = "";
String msg = "";
int errorIdx = pieces.length - 1;
String error = pieces[errorIdx];
String filename = pieces[1];
int line = PApplet.parseInt(pieces[2]);
int col;
if (errorIdx > 3) {
col = PApplet.parseInt(pieces[3].substring(1));
} else {
col = -1;
}
if (error.trim().equals("SPI.h: No such file or directory")) {
error = tr("Please import the SPI library from the Sketch > Import Library menu.");
@ -569,12 +579,17 @@ public class Compiler implements MessageConsumer {
//msg = _("\nThe 'Keyboard' class is only supported on the Arduino Leonardo.\n\n");
}
RunnerException ex = placeException(error, pieces[1], PApplet.parseInt(pieces[2]) - 1);
RunnerException ex = placeException(error, filename, line - 1, col);
if (ex != null) {
String fileName = ex.getCodeFile().getPrettyName();
int lineNum = ex.getCodeLine() + 1;
s = fileName + ":" + lineNum + ": error: " + error + msg;
int colNum = ex.getCodeColumn();
if (colNum != -1) {
s = fileName + ":" + lineNum + ":" + colNum + ": error: " + error + msg;
} else {
s = fileName + ":" + lineNum + ": error: " + error + msg;
}
}
if (ex != null) {
@ -600,10 +615,10 @@ public class Compiler implements MessageConsumer {
System.err.println(s);
}
private RunnerException placeException(String message, String fileName, int line) {
private RunnerException placeException(String message, String fileName, int line, int col) {
for (SketchFile file : sketch.getFiles()) {
if (new File(fileName).getName().equals(file.getFileName())) {
return new RunnerException(message, file, line);
return new RunnerException(message, file, line, col);
}
}
return null;