rooty/Arduino
1
0
Fork 0
mirror of https://github.com/arduino/Arduino.git synced 2025-01-30 19:52:13 +01:00
Code Issues Releases Activity

Don't store peeked characters in a char variable

Browse Source 
peekNextDigit() returns an int, so it can return -1 in addition to all
256 possible bytes. By putting the result in a signe char, all bytes
over 128 will be interpreted as "no bytes available". Furthermore, it
seems that on SAM "char" is unsigned by default, causing the
"if (c < 0)" line a bit further down to always be false.

Using an int is more appropriate.

A different fix for this issue was suggested in #1399. This fix helps
towards #1728.
This commit is contained in:
Matthijs Kooijman 2014-02-18 20:56:31 +01:00
parent 12b706551d
commit 4cf21dcdd1
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hardware/arduino/avr/cores/arduino/Stream.cpp
View File

@ -176,7 +176,7 @@ float Stream::parseFloat(char skipChar){
boolean isNegative = false; boolean isNegative = false;
boolean isFraction = false; boolean isFraction = false;
long value = 0; long value = 0;
char c; int c;
float fraction = 1.0; float fraction = 1.0;
c = peekNextDigit(); c = peekNextDigit();

2
hardware/arduino/sam/cores/arduino/Stream.cpp
View File

@ -176,7 +176,7 @@ float Stream::parseFloat(char skipChar){
boolean isNegative = false; boolean isNegative = false;
boolean isFraction = false; boolean isFraction = false;
long value = 0; long value = 0;
char c; int c;
float fraction = 1.0; float fraction = 1.0;
c = peekNextDigit(); c = peekNextDigit();