From 5bc96652e612d57dfc5f32ac68b682ca838cb4dc Mon Sep 17 00:00:00 2001 From: Cristian Maglie Date: Thu, 4 Oct 2018 13:40:05 +0200 Subject: [PATCH] Slightly optimized method by removing redundant boolean flag --- .../packages/discoverers/serial/SerialDiscovery.java | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arduino-core/src/cc/arduino/packages/discoverers/serial/SerialDiscovery.java b/arduino-core/src/cc/arduino/packages/discoverers/serial/SerialDiscovery.java index a7ff00e4d..f589a0195 100644 --- a/arduino-core/src/cc/arduino/packages/discoverers/serial/SerialDiscovery.java +++ b/arduino-core/src/cc/arduino/packages/discoverers/serial/SerialDiscovery.java @@ -162,19 +162,18 @@ public class SerialDiscovery implements Discovery, Runnable { Map boardData = platform.resolveDeviceByVendorIdProductId(port, BaseNoGui.packages); BoardPort boardPort = null; - boolean updatingInfos = false; int i = 0; // create new board or update existing for (BoardPort board : boardPorts) { if (board.toString().equals(newPort)) { - updatingInfos = true; boardPort = boardPorts.get(i); break; } i++; } - if (!updatingInfos) { + if (boardPort == null) { boardPort = new BoardPort(); + boardPorts.add(boardPort); } boardPort.setAddress(port); boardPort.setProtocol("serial"); @@ -216,9 +215,6 @@ public class SerialDiscovery implements Discovery, Runnable { } boardPort.setLabel(label); - if (!updatingInfos) { - boardPorts.add(boardPort); - } } setSerialBoardPorts(boardPorts); }