rooty/Arduino
1
0
Fork 0
mirror of https://github.com/arduino/Arduino.git synced 2025-04-05 21:40:24 +02:00
Code Issues Releases Activity

Merge pull request #2279 from cmaglie/fix-leo-upload-osx10.9.4

Browse Source 
Fix for upload problems on Arduino Leonardo (and derivatives) on OSX 10.9
This commit is contained in:
Cristian Maglie 2014-09-10 12:58:10 +02:00
commit 6f9674288b
2 changed files with 22 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/cc/arduino/packages/uploaders/SerialUploader.java
View File

@ -86,15 +86,13 @@ public class SerialUploader extends Uploader {
System.out.println(_("Forcing reset using 1200bps open/close on port ") + uploadPort); System.out.println(_("Forcing reset using 1200bps open/close on port ") + uploadPort);
Serial.touchPort(uploadPort, 1200); Serial.touchPort(uploadPort, 1200);
} }
Thread.sleep(400);
if (waitForUploadPort) { if (waitForUploadPort) {
// Scanning for available ports seems to open the port or // Scanning for available ports seems to open the port or
// otherwise assert DTR, which would cancel the WDT reset if // otherwise assert DTR, which would cancel the WDT reset if
// it happened within 250 ms. So we wait until the reset should // it happened within 250 ms. So we wait until the reset should
// have already occured before we start scanning. // have already occured before we start scanning.
Thread.sleep(300);
uploadPort = waitForUploadPort(uploadPort, before); uploadPort = waitForUploadPort(uploadPort, before);
} else {
Thread.sleep(400);
} }
} catch (SerialException e) { } catch (SerialException e) {
throw new RunnerException(e); throw new RunnerException(e);

38
hardware/arduino/avr/cores/arduino/CDC.cpp
View File

@ -80,35 +80,39 @@ bool WEAK CDC_Setup(Setup& setup)
if (CDC_SET_LINE_CODING == r) if (CDC_SET_LINE_CODING == r)
{ {
USB_RecvControl((void*)&_usbLineInfo,7); USB_RecvControl((void*)&_usbLineInfo,7);
return true;
} }
if (CDC_SET_CONTROL_LINE_STATE == r) if (CDC_SET_CONTROL_LINE_STATE == r)
{ {
_usbLineInfo.lineState = setup.wValueL; _usbLineInfo.lineState = setup.wValueL;
}
if (CDC_SET_LINE_CODING == r || CDC_SET_CONTROL_LINE_STATE == r)
{
// auto-reset into the bootloader is triggered when the port, already // auto-reset into the bootloader is triggered when the port, already
// open at 1200 bps, is closed. this is the signal to start the watchdog // open at 1200 bps, is closed. this is the signal to start the watchdog
// with a relatively long period so it can finish housekeeping tasks // with a relatively long period so it can finish housekeeping tasks
// like servicing endpoints before the sketch ends // like servicing endpoints before the sketch ends
if (1200 == _usbLineInfo.dwDTERate) {
// We check DTR state to determine if host port is open (bit 0 of lineState). // We check DTR state to determine if host port is open (bit 0 of lineState).
if ((_usbLineInfo.lineState & 0x01) == 0) { if (1200 == _usbLineInfo.dwDTERate && (_usbLineInfo.lineState & 0x01) == 0)
*(uint16_t *)0x0800 = 0x7777; {
wdt_enable(WDTO_120MS); *(uint16_t *)0x0800 = 0x7777;
} else { wdt_enable(WDTO_120MS);
// Most OSs do some intermediate steps when configuring ports and DTR can }
// twiggle more than once before stabilizing. else
// To avoid spurious resets we set the watchdog to 250ms and eventually {
// cancel if DTR goes back high. // Most OSs do some intermediate steps when configuring ports and DTR can
// twiggle more than once before stabilizing.
wdt_disable(); // To avoid spurious resets we set the watchdog to 250ms and eventually
wdt_reset(); // cancel if DTR goes back high.
*(uint16_t *)0x0800 = 0x0;
} wdt_disable();
wdt_reset();
*(uint16_t *)0x0800 = 0x0;
} }
return true;
} }
return true;
} }
return false; return false;
} }