rooty/Arduino
1
0
Fork 0
mirror of https://github.com/arduino/Arduino.git synced 2025-01-29 18:52:13 +01:00
Code Issues Releases Activity

Removed destructor from File.cpp and SD.h as it leads to unexpected close/destructed objects #814

Browse Source
This commit is contained in:
Federico Fissore 2013-10-15 17:05:45 +02:00
parent e8834d32f3
commit 88f7504e81
3 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
build/shared/revisions.txt
View File

@ -19,6 +19,7 @@ ARDUINO 1.5.5 BETA
* avr: Fixed wrong extended fuses on Arduino Yún when using external programmer * avr: Fixed wrong extended fuses on Arduino Yún when using external programmer
* avr: Added yun variant with LED_BUILTIN definition * avr: Added yun variant with LED_BUILTIN definition
* avr: Refactored Mega* variants definitions in boards.txt (Kristian Sloth Lauszus) * avr: Refactored Mega* variants definitions in boards.txt (Kristian Sloth Lauszus)
* avr: Removed File object destructor. In order to free memory allocated by a File object the safest way is to call its close() method
ARDUINO 1.5.4 BETA 2013.09.10 ARDUINO 1.5.4 BETA 2013.09.10

5
libraries/SD/src/File.cpp
View File

@ -43,11 +43,6 @@ File::File(void) {
//Serial.print("Created empty file object"); //Serial.print("Created empty file object");
} }
File::~File(void) {
close();
// Serial.print("Deleted file object");
}
// returns a pointer to the file name // returns a pointer to the file name
char *File::name(void) { char *File::name(void) {
return _name; return _name;

1
libraries/SD/src/SD.h
View File

@ -31,7 +31,6 @@ class File : public Stream {
public: public:
File(SdFile f, const char *name); // wraps an underlying SdFile File(SdFile f, const char *name); // wraps an underlying SdFile
File(void); // 'empty' constructor File(void); // 'empty' constructor
~File(void); // destructor
virtual size_t write(uint8_t); virtual size_t write(uint8_t);
virtual size_t write(const uint8_t *buf, size_t size); virtual size_t write(const uint8_t *buf, size_t size);
virtual int read(); virtual int read();