1
0
mirror of https://github.com/arduino/Arduino.git synced 2025-01-31 20:52:13 +01:00

Merge pull request #9168 from joew46167/scrollMenu

Tools Boards menu scroll updates for accessibility
This commit is contained in:
Martino Facchin 2019-08-26 14:09:09 +02:00 committed by GitHub
commit 930ec16321
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -3,6 +3,8 @@
*/
package processing.app.tools;
import processing.app.PreferencesData;
import javax.swing.*;
import javax.swing.event.ChangeEvent;
import javax.swing.event.ChangeListener;
@ -567,6 +569,43 @@ public class MenuScroller {
public void actionPerformed(ActionEvent e) {
firstIndex += increment * accelerator;
refreshMenu();
if (PreferencesData.getBoolean("ide.accessible")) {
// If the user has chosen to use accessibility features, it means that they are using a screen reader
// to assist them in development of their project. This scroller is very unfriendly toward screen readers
// because it does not tell the user that it is scrolling through the board options, and it does not read
// the name of the boards as they scroll by. It is possible that the desired board will never become
// accessible.
// Because this scroller is quite nice for the sighted user, the idea here is to continue to use the
// scroller, but to fool it into scrolling one item at a time for accessible features users so that the
// screen readers work well, too.
// It's not the prettiest of code, but it works.
String itemClassName;
int keyEvent;
// The blind user likely used an arrow key to get to the scroller. Determine which arrow key
// so we can send an event for the opposite arrow key. This fools the scroller into scrolling
// a single item. Get the class name of the new item while we're here
if (increment > 0) {
itemClassName = menuItems[firstIndex + scrollCount - 1].getClass().getName();
keyEvent = KeyEvent.VK_UP;
}
else {
itemClassName = menuItems[firstIndex].getClass().getName();
keyEvent = KeyEvent.VK_DOWN;
}
// Use the class name to check if the next item is a separator. If it is, just let it scroll on like
// normal, otherwise move the cursor back with the opposite key event to the new item so that item is read
// by a screen reader and the user can use their arrow keys to navigate the list one item at a time
if (!itemClassName.equals(JSeparator.class.getName()) ) {
KeyboardFocusManager manager = KeyboardFocusManager.getCurrentKeyboardFocusManager();
Component comp = manager.getFocusOwner();
KeyEvent event = new KeyEvent(comp,
KeyEvent.KEY_PRESSED, System.currentTimeMillis(), 0,
keyEvent, KeyEvent.CHAR_UNDEFINED);
comp.dispatchEvent(event);
}
}
}
});
}