rooty/Arduino
1
0
Fork 0
mirror of https://github.com/arduino/Arduino.git synced 2025-01-31 20:52:13 +01:00
Code Issues Releases Activity

Fix buffer being overwritten by multiple twi_transmit calls

Browse Source 
Fixes that more complex methods (like Stream::print(float)) do not work properly.

Without this fix, Wire.print(1.01f); results in '1' because Print::printFloat(double, uint8_t) performs multiple print() and therefore twi_transmit calls. Also Wire.println("Heyho"); results only in a newline character.
This commit is contained in:
kellerkindt 2016-06-05 03:01:57 +02:00
parent 61323525b7
commit ab4e114624
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hardware/arduino/avr/libraries/Wire/src/utility/twi.c
View File

@ -304,7 +304,7 @@ uint8_t twi_transmit(const uint8_t* data, uint8_t length)
uint8_t i; uint8_t i;
// ensure data will fit into buffer // ensure data will fit into buffer
if(TWI_BUFFER_LENGTH < length){ if(TWI_BUFFER_LENGTH < (twi_txBufferLength+length)){
return 1; return 1;
} }
@ -314,10 +314,10 @@ uint8_t twi_transmit(const uint8_t* data, uint8_t length)
} }
// set length and copy data into tx buffer // set length and copy data into tx buffer
twi_txBufferLength = length;
for(i = 0; i < length; ++i){ for(i = 0; i < length; ++i){
twi_txBuffer[i] = data[i]; twi_txBuffer[twi_txBufferLength+i] = data[i];
} }
twi_txBufferLength += length;
return 0; return 0;
} }