From 4b7eaf2ee7de101fdaf7e90ae103226d3bdec9ef Mon Sep 17 00:00:00 2001
From: Federico Fissore <f.fissore@arduino.cc>
Date: Wed, 8 Oct 2014 14:10:54 +0200
Subject: [PATCH 1/6] build.xml: removed unzip-arm-toolchain

---
 build/build.xml | 27 +++------------------------
 1 file changed, 3 insertions(+), 24 deletions(-)

diff --git a/build/build.xml b/build/build.xml
index de6bf1aac..063170f2c 100644
--- a/build/build.xml
+++ b/build/build.xml
@@ -252,7 +252,7 @@
       <param name="target.path" value="macosx/work/Arduino.app/Contents/Resources/Java" />
     </antcall>
 
-    <antcall target="unzip-arm-toolchain">
+    <antcall target="unzip-tool">
       <param name="dist_file" value="gcc-arm-none-eabi-4.8.3-2014q1-mac.tar.gz" />
       <param name="dist_url" value="http://downloads.arduino.cc/gcc-arm-none-eabi-4.8.3-2014q1-mac.tar.gz" />
       <param name="dist_check_file" value="gcc-arm-none-eabi-4.8.3-2014q1" />
@@ -486,7 +486,7 @@
 
   <target name="linux32-build" depends="linux-build" description="Build linux (32-bit) version">
     <!-- Unzip ARM tools -->
-    <antcall target="unzip-arm-toolchain">
+    <antcall target="unzip-tool">
       <param name="dist_file" value="gcc-arm-none-eabi-4.8.3-2014q1-linux32.tar.gz" />
       <param name="dist_url" value="http://downloads.arduino.cc/gcc-arm-none-eabi-4.8.3-2014q1-linux32.tar.gz" />
       <param name="dist_check_file" value="gcc-arm-none-eabi-4.8.3-2014q1" />
@@ -608,27 +608,6 @@
     <get src="${dist_url}" dest="${staging_folder}/dist/${dist_file}" verbose="true" ignoreerrors="true" />
   </target>
 
-  <target name="unzip-arm-toolchain" depends="get-arm-toolchain, check-arm-toolchain"
-      unless="arm_toolchain_installed">
-    <checksum file="${staging_folder}/dist/${dist_file}" algorithm="sha"
-      fileext=".sha" verifyproperty="checksum.matches"/>
-    <condition property="checksum.matches.fail">
-      <equals arg1="${checksum.matches}" arg2="false"/>
-    </condition>
-    <fail if="checksum.matches.fail">Checksum failed.
-
-      File ${dist_file} failed checksum.
-      Please remove "${staging_folder}/dist/${dist_file}" to download it again.
-    </fail>
-
-    <!-- Unzip toolchain to the destination folder -->
-    <exec executable="tar">
-      <arg value="xfz"/>
-      <arg value="${staging_folder}/dist/${dist_file}"/>
-      <arg value="--directory=${staging_folder}/work/${staging_hardware_folder}/tools/"/>
-    </exec>
-  </target>
-
   <target name="linux-dist" depends="build"
 	  description="Build .tar.gz of linux version">
 
@@ -792,7 +771,7 @@
     </chmod>
 
     <!-- Unzip ARM toolchain -->
-    <antcall target="unzip-arm-toolchain">
+    <antcall target="unzip-tool">
       <param name="dist_file" value="gcc-arm-none-eabi-4.8.3-2014q1-windows.tar.gz" />
       <param name="dist_url" value="http://downloads.arduino.cc/gcc-arm-none-eabi-4.8.3-2014q1-windows.tar.gz" />
       <param name="dist_check_file" value="gcc-arm-none-eabi-4.8.3-2014q1" />

From 24be3773ead1c1c068a4755cdc8bcce83b0fc0a9 Mon Sep 17 00:00:00 2001
From: Federico Fissore <f.fissore@arduino.cc>
Date: Wed, 8 Oct 2014 14:22:34 +0200
Subject: [PATCH 2/6] build.xml: renamed unzip-tool to untar-tool

---
 build/build.xml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/build/build.xml b/build/build.xml
index 063170f2c..bb5e088e1 100644
--- a/build/build.xml
+++ b/build/build.xml
@@ -252,7 +252,7 @@
       <param name="target.path" value="macosx/work/Arduino.app/Contents/Resources/Java" />
     </antcall>
 
-    <antcall target="unzip-tool">
+    <antcall target="untar-tool">
       <param name="dist_file" value="gcc-arm-none-eabi-4.8.3-2014q1-mac.tar.gz" />
       <param name="dist_url" value="http://downloads.arduino.cc/gcc-arm-none-eabi-4.8.3-2014q1-mac.tar.gz" />
       <param name="dist_check_file" value="gcc-arm-none-eabi-4.8.3-2014q1" />
@@ -486,7 +486,7 @@
 
   <target name="linux32-build" depends="linux-build" description="Build linux (32-bit) version">
     <!-- Unzip ARM tools -->
-    <antcall target="unzip-tool">
+    <antcall target="untar-tool">
       <param name="dist_file" value="gcc-arm-none-eabi-4.8.3-2014q1-linux32.tar.gz" />
       <param name="dist_url" value="http://downloads.arduino.cc/gcc-arm-none-eabi-4.8.3-2014q1-linux32.tar.gz" />
       <param name="dist_check_file" value="gcc-arm-none-eabi-4.8.3-2014q1" />
@@ -500,7 +500,7 @@
 
   <target name="linux64-build" depends="linux-build" description="Build linux (64-bit) version">
     <!-- Unzip ARM tools -->
-    <antcall target="unzip-tool">
+    <antcall target="untar-tool">
       <param name="dist_file" value="gcc-arm-none-eabi-4.8.3-2014q1-linux64.tar.gz" />
       <param name="dist_url" value="http://downloads.arduino.cc/gcc-arm-none-eabi-4.8.3-2014q1-linux64.tar.gz" />
       <param name="dist_check_file" value="gcc-arm-none-eabi-4.8.3-2014q1" />
@@ -573,7 +573,7 @@
   </target>
 
   <!-- Ensure that the tool is downloaded and test checksums, if everything's ok unzip it on the tools folder  -->
-  <target name="unzip-tool" depends="get-tool, check-tool" unless="${dist_file}_installed">
+  <target name="untar-tool" depends="get-tool, check-tool" unless="${dist_file}_installed">
     <echo>Testing checksum of "${staging_folder}/dist/${dist_file}"</echo>
     <checksum file="${staging_folder}/dist/${dist_file}" algorithm="sha" fileext=".sha" verifyproperty="checksum.matches"/>
     <condition property="checksum.matches.fail">
@@ -771,7 +771,7 @@
     </chmod>
 
     <!-- Unzip ARM toolchain -->
-    <antcall target="unzip-tool">
+    <antcall target="untar-tool">
       <param name="dist_file" value="gcc-arm-none-eabi-4.8.3-2014q1-windows.tar.gz" />
       <param name="dist_url" value="http://downloads.arduino.cc/gcc-arm-none-eabi-4.8.3-2014q1-windows.tar.gz" />
       <param name="dist_check_file" value="gcc-arm-none-eabi-4.8.3-2014q1" />

From 30d4c89ed33af6c8b5f5db0217c72ebd11ae4882 Mon Sep 17 00:00:00 2001
From: Federico Fissore <f.fissore@arduino.cc>
Date: Wed, 8 Oct 2014 15:50:32 +0200
Subject: [PATCH 3/6] build.xml: made untar-tool (and dependencies) easier to
 reuse

---
 build/build.xml | 62 ++++++++++++++++++++++++++-----------------------
 1 file changed, 33 insertions(+), 29 deletions(-)

diff --git a/build/build.xml b/build/build.xml
index bb5e088e1..ca3134d60 100644
--- a/build/build.xml
+++ b/build/build.xml
@@ -252,10 +252,11 @@
       <param name="target.path" value="macosx/work/Arduino.app/Contents/Resources/Java" />
     </antcall>
 
-    <antcall target="untar-tool">
-      <param name="dist_file" value="gcc-arm-none-eabi-4.8.3-2014q1-mac.tar.gz" />
-      <param name="dist_url" value="http://downloads.arduino.cc/gcc-arm-none-eabi-4.8.3-2014q1-mac.tar.gz" />
-      <param name="dist_check_file" value="gcc-arm-none-eabi-4.8.3-2014q1" />
+    <antcall target="untar">
+      <param name="archive_file" value="${staging_folder}/dist/gcc-arm-none-eabi-4.8.3-2014q1-mac.tar.gz" />
+      <param name="archive_url" value="http://downloads.arduino.cc/gcc-arm-none-eabi-4.8.3-2014q1-mac.tar.gz" />
+      <param name="final_folder" value="${staging_folder}/work/${staging_hardware_folder}/tools/gcc-arm-none-eabi-4.8.3-2014q1" />
+      <param name="dest_folder" value="${staging_folder}/work/${staging_hardware_folder}/tools/" />
     </antcall>
 
     <delete includeEmptyDirs="true" quiet="true">
@@ -486,10 +487,11 @@
 
   <target name="linux32-build" depends="linux-build" description="Build linux (32-bit) version">
     <!-- Unzip ARM tools -->
-    <antcall target="untar-tool">
-      <param name="dist_file" value="gcc-arm-none-eabi-4.8.3-2014q1-linux32.tar.gz" />
-      <param name="dist_url" value="http://downloads.arduino.cc/gcc-arm-none-eabi-4.8.3-2014q1-linux32.tar.gz" />
-      <param name="dist_check_file" value="gcc-arm-none-eabi-4.8.3-2014q1" />
+    <antcall target="untar">
+      <param name="archive_file" value="${staging_folder}/dist/gcc-arm-none-eabi-4.8.3-2014q1-linux32.tar.gz" />
+      <param name="archive_url" value="http://downloads.arduino.cc/gcc-arm-none-eabi-4.8.3-2014q1-linux32.tar.gz" />
+      <param name="final_folder" value="${staging_folder}/work/${staging_hardware_folder}/tools/gcc-arm-none-eabi-4.8.3-2014q1" />
+      <param name="dest_folder" value="${staging_folder}/work/${staging_hardware_folder}/tools/" />
     </antcall>
 
     <!-- Unzip AVR tools -->
@@ -500,10 +502,11 @@
 
   <target name="linux64-build" depends="linux-build" description="Build linux (64-bit) version">
     <!-- Unzip ARM tools -->
-    <antcall target="untar-tool">
-      <param name="dist_file" value="gcc-arm-none-eabi-4.8.3-2014q1-linux64.tar.gz" />
-      <param name="dist_url" value="http://downloads.arduino.cc/gcc-arm-none-eabi-4.8.3-2014q1-linux64.tar.gz" />
-      <param name="dist_check_file" value="gcc-arm-none-eabi-4.8.3-2014q1" />
+    <antcall target="untar">
+      <param name="archive_file" value="${staging_folder}/dist/gcc-arm-none-eabi-4.8.3-2014q1-linux64.tar.gz" />
+      <param name="archive_url" value="http://downloads.arduino.cc/gcc-arm-none-eabi-4.8.3-2014q1-linux64.tar.gz" />
+      <param name="final_folder" value="${staging_folder}/work/${staging_hardware_folder}/tools/gcc-arm-none-eabi-4.8.3-2014q1" />
+      <param name="dest_folder" value="${staging_folder}/work/${staging_hardware_folder}/tools/" />
     </antcall>
 
     <!-- Unzip AVR tools -->
@@ -562,35 +565,35 @@
   <!-- Set '${dist_file}_available' property if toolchain dist_file is downloaded              -->
   <!-- Set '${dist_file}_installed' property if toolchain is installed in working directory    -->
   <!--                              hardware/tools/${dist_check_file} is checked for existence -->
-  <target name="check-tool">
-    <available file="${staging_folder}/dist/${dist_file}" property="${dist_file}_available" />
-    <available file="${staging_folder}/work/hardware/tools/${dist_check_file}" property="${dist_file}_installed" />
+  <target name="untar-unzip-check">
+    <available file="${archive_file}" property="${archive_file}_available" />
+    <available file="${final_folder}" property="${archive_file}_installed" />
   </target>
 
   <!-- Retrieve tool -->
-  <target name="get-tool" depends="check-tool" unless="${dist_file}_available">
-    <get src="${dist_url}" dest="${staging_folder}/dist/${dist_file}" verbose="true" ignoreerrors="true" />
+  <target name="untar-unzip-download" depends="untar-unzip-check" unless="${archive_file}_available">
+    <get src="${archive_url}" dest="${archive_file}" verbose="true" ignoreerrors="true" />
   </target>
 
   <!-- Ensure that the tool is downloaded and test checksums, if everything's ok unzip it on the tools folder  -->
-  <target name="untar-tool" depends="get-tool, check-tool" unless="${dist_file}_installed">
-    <echo>Testing checksum of "${staging_folder}/dist/${dist_file}"</echo>
-    <checksum file="${staging_folder}/dist/${dist_file}" algorithm="sha" fileext=".sha" verifyproperty="checksum.matches"/>
+  <target name="untar" depends="untar-unzip-download" unless="${dist_file}_installed">
+    <echo>Testing checksum of "${archive_file}"</echo>
+    <checksum file="${archive_file}" algorithm="sha" fileext=".sha" verifyproperty="checksum.matches"/>
     <condition property="checksum.matches.fail">
       <equals arg1="${checksum.matches}" arg2="false"/>
     </condition>
     <fail if="checksum.matches.fail">Checksum failed.
 
-      File ${dist_file} failed checksum.
-      Please remove "${staging_folder}/dist/${dist_file}" to download it again.
+      File ${archive_file} failed checksum.
+      Please remove "${archive_file}" to download it again.
     </fail>
 
     <!-- Unzip tool to the destination folder -->
-    <echo>Unzipping into folder ${staging_folder}/dist/${dist_file}</echo>
+    <echo>Unzipping into folder ${dest_folder}</echo>
     <exec executable="tar">
       <arg value="xfz"/>
-      <arg value="${staging_folder}/dist/${dist_file}"/>
-      <arg value="--directory=${staging_folder}/work/${staging_hardware_folder}/tools/"/>
+      <arg value="${archive_file}"/>
+      <arg value="--directory=${dest_folder}"/>
     </exec>
   </target>
 
@@ -771,10 +774,11 @@
     </chmod>
 
     <!-- Unzip ARM toolchain -->
-    <antcall target="untar-tool">
-      <param name="dist_file" value="gcc-arm-none-eabi-4.8.3-2014q1-windows.tar.gz" />
-      <param name="dist_url" value="http://downloads.arduino.cc/gcc-arm-none-eabi-4.8.3-2014q1-windows.tar.gz" />
-      <param name="dist_check_file" value="gcc-arm-none-eabi-4.8.3-2014q1" />
+    <antcall target="untar">
+      <param name="archive_file" value="${staging_folder}/dist/gcc-arm-none-eabi-4.8.3-2014q1-windows.tar.gz" />
+      <param name="archive_url" value="http://downloads.arduino.cc/gcc-arm-none-eabi-4.8.3-2014q1-windows.tar.gz" />
+      <param name="final_folder" value="${staging_folder}/work/${staging_hardware_folder}/tools/gcc-arm-none-eabi-4.8.3-2014q1" />
+      <param name="dest_folder" value="${staging_folder}/work/${staging_hardware_folder}/tools/" />
     </antcall>
 
     <delete includeEmptyDirs="true" quiet="true">

From 00ecd5585d949075af4111cd14fb464cbc88dfc8 Mon Sep 17 00:00:00 2001
From: Federico Fissore <f.fissore@arduino.cc>
Date: Wed, 8 Oct 2014 17:10:47 +0200
Subject: [PATCH 4/6] build.xml: removed unzip-avr-toolchain and
 unzip-libastyle in favour of unzip

---
 build/build.xml | 123 +++++++++++++++++++++++-------------------------
 1 file changed, 59 insertions(+), 64 deletions(-)

diff --git a/build/build.xml b/build/build.xml
index ca3134d60..f4f0b3754 100644
--- a/build/build.xml
+++ b/build/build.xml
@@ -27,9 +27,6 @@
   <condition property="staging_hardware_folder" value="hardware"><equals arg1="${platform}" arg2="linux32" /></condition>
   <condition property="staging_hardware_folder" value="hardware"><equals arg1="${platform}" arg2="linux64" /></condition>
 
-  <condition property="launch4j-download-unpack-target-name" value="launch4j-windows"><os family="windows" /></condition>
-  <property name="launch4j-download-unpack-target-name" value="launch4j-linux"/>
-
   <condition property="arch-bits" value="32">
     <equals arg1="${platform}" arg2="linux32"/>
   </condition>
@@ -224,8 +221,11 @@
     </copy>
 
     <!-- Unzip AVR tools -->
-    <antcall target="unzip-avr-toolchain">
-      <param name="file_arch" value="mac32" />
+    <antcall target="unzip">
+      <param name="archive_file" value="${staging_folder}/avr-toolchain-mac32-gcc-4.8.1.zip" />
+      <param name="archive_url" value="http://downloads.arduino.cc/avr-toolchain-mac32-gcc-4.8.1.zip" />
+      <param name="final_folder" value="${staging_folder}/work/${staging_hardware_folder}/tools/avr" />
+      <param name="dest_folder" value="${staging_folder}/work/${staging_hardware_folder}/tools/avr" />
     </antcall>
 
 <!--
@@ -266,7 +266,12 @@
       <fileset dir="macosx/work/${staging_hardware_folder}/tools" includes="**/man"/>
     </delete>
 
-    <antcall target="unzip-libastyle" />
+    <antcall target="unzip">
+      <param name="archive_file" value="./libastylej-2.04.zip" />
+      <param name="archive_url" value="http://downloads.arduino.cc/libastylej-2.04.zip" />
+      <param name="final_folder" value="${staging_folder}/libastylej" />
+      <param name="dest_folder" value="${staging_folder}" />
+    </antcall>
     <copy file="macosx/libastylej/libastylej.jnilib" todir="macosx/work/Arduino.app/Contents/Resources/Java/lib/" />
     <chmod perm="755" file="macosx/work/Arduino.app/Contents/Resources/Java/lib/libastylej.jnilib" />
   </target>
@@ -480,7 +485,12 @@
     <copy todir="linux/work" file="linux/dist/arduino" />
     <chmod perm="755" file="linux/work/arduino" />
 
-    <antcall target="unzip-libastyle" />
+    <antcall target="unzip">
+      <param name="archive_file" value="./libastylej-2.04.zip" />
+      <param name="archive_url" value="http://downloads.arduino.cc/libastylej-2.04.zip" />
+      <param name="final_folder" value="${staging_folder}/libastylej" />
+      <param name="dest_folder" value="${staging_folder}" />
+    </antcall>
     <copy file="linux/libastylej/libastylej${arch-bits}.so" tofile="linux/work/lib/libastylej.so" />
     <chmod perm="755" file="linux/work/lib/libastylej.so" />
   </target>
@@ -495,8 +505,11 @@
     </antcall>
 
     <!-- Unzip AVR tools -->
-    <antcall target="unzip-avr-toolchain">
-      <param name="file_arch" value="linux32" />
+    <antcall target="unzip">
+      <param name="archive_file" value="${staging_folder}/avr-toolchain-linux32-gcc-4.8.1.zip" />
+      <param name="archive_url" value="http://downloads.arduino.cc/avr-toolchain-linux32-gcc-4.8.1.zip" />
+      <param name="final_folder" value="${staging_folder}/work/${staging_hardware_folder}/tools/avr" />
+      <param name="dest_folder" value="${staging_folder}/work/${staging_hardware_folder}/tools/avr" />
     </antcall>
   </target>
 
@@ -510,8 +523,11 @@
     </antcall>
 
     <!-- Unzip AVR tools -->
-    <antcall target="unzip-avr-toolchain">
-      <param name="file_arch" value="linux64" />
+    <antcall target="unzip">
+      <param name="archive_file" value="${staging_folder}/avr-toolchain-linux64-gcc-4.8.1.zip" />
+      <param name="archive_url" value="http://downloads.arduino.cc/avr-toolchain-linux64-gcc-4.8.1.zip" />
+      <param name="final_folder" value="${staging_folder}/work/${staging_hardware_folder}/tools/avr" />
+      <param name="dest_folder" value="${staging_folder}/work/${staging_hardware_folder}/tools/avr" />
     </antcall>
   </target>
 
@@ -523,45 +539,6 @@
     <exec executable="./linux/work/arduino" spawn="false"/>
   </target>
 
-  <target name="unzip-avr-toolchain">
-    <get src="http://downloads.arduino.cc/avr-toolchain-${file_arch}-gcc-4.8.1.zip" dest="${staging_folder}" usetimestamp="true" ignoreerrors="true" verbose="true" />
-
-    <checksum file="${staging_folder}/avr-toolchain-${file_arch}-gcc-4.8.1.zip" algorithm="sha" fileext=".sha" verifyproperty="checksum.matches"/>
-    <condition property="checksum.matches.fail">
-      <equals arg1="${checksum.matches}" arg2="false"/>
-    </condition>
-    <fail if="checksum.matches.fail">Checksum failed.
-
-      File avr-toolchain-${file_arch}-gcc-4.8.1.zip failed checksum.
-      Please remove "${staging_folder}/avr-toolchain-${file_arch}-gcc-4.8.1.zip" and download it again.
-    </fail>
-
-    <mkdir dir="${staging_folder}/work/${staging_hardware_folder}/tools/avr" />
-    <exec executable="unzip">
-      <arg value="-q" />
-      <arg value="-n" />
-      <arg value="-d" />
-      <arg value="${staging_folder}/work/${staging_hardware_folder}/tools/avr" />
-      <arg value="${staging_folder}/avr-toolchain-${file_arch}-gcc-4.8.1.zip" />
-    </exec>
-  </target>
-
-  <target name="unzip-libastyle">
-    <get src="http://downloads.arduino.cc/libastylej-2.04.zip" dest="." usetimestamp="true" ignoreerrors="true" verbose="true" />
-
-    <checksum file="libastylej-2.04.zip" algorithm="sha" fileext=".sha" verifyproperty="checksum.matches"/>
-    <condition property="checksum.matches.fail">
-      <equals arg1="${checksum.matches}" arg2="false"/>
-    </condition>
-    <fail if="checksum.matches.fail">Checksum failed.
-
-      File libastylej-2.04.zip failed checksum.
-      Please remove "libastylej-2.04.zip" and download it again.
-    </fail>
-
-    <unzip src="libastylej-2.04.zip" dest="${staging_folder}" overwrite="true"/>
-  </target>
-
   <!-- Set '${dist_file}_available' property if toolchain dist_file is downloaded              -->
   <!-- Set '${dist_file}_installed' property if toolchain is installed in working directory    -->
   <!--                              hardware/tools/${dist_check_file} is checked for existence -->
@@ -576,7 +553,7 @@
   </target>
 
   <!-- Ensure that the tool is downloaded and test checksums, if everything's ok unzip it on the tools folder  -->
-  <target name="untar" depends="untar-unzip-download" unless="${dist_file}_installed">
+  <target name="untar" depends="untar-unzip-download" unless="${archive_file}_installed">
     <echo>Testing checksum of "${archive_file}"</echo>
     <checksum file="${archive_file}" algorithm="sha" fileext=".sha" verifyproperty="checksum.matches"/>
     <condition property="checksum.matches.fail">
@@ -597,18 +574,28 @@
     </exec>
   </target>
 
+  <target name="unzip" depends="untar-unzip-download" unless="${archive_file}_installed">
+    <echo>Testing checksum of "${archive_file}"</echo>
+    <checksum file="${archive_file}" algorithm="sha" fileext=".sha" verifyproperty="checksum.matches"/>
+    <condition property="checksum.matches.fail">
+      <equals arg1="${checksum.matches}" arg2="false"/>
+    </condition>
+    <fail if="checksum.matches.fail">Checksum failed.
 
+      File ${archive_file} failed checksum.
+      Please remove "${archive_file}" to download it again.
+    </fail>
 
-  <!-- Set 'arm_disfile_available' property if ARM toolchain dist_file is downloaded             -->
-  <!-- Set 'arm_toolchain_installed' property if ARM toolchain is installed in working directory -->
-  <target name="check-arm-toolchain">
-    <available file="${staging_folder}/dist/${dist_file}" property="arm_distfile_available" />
-    <available file="${staging_folder}/work/hardware/tools/${dist_check_file}" property="arm_toolchain_installed" />
-  </target>
-
-  <!-- Retrieve ARM toolchain -->
-  <target name="get-arm-toolchain" depends="check-arm-toolchain" unless="arm_distfile_available">
-    <get src="${dist_url}" dest="${staging_folder}/dist/${dist_file}" verbose="true" ignoreerrors="true" />
+    <!-- Unzip tool to the destination folder -->
+    <echo>Unzipping into folder ${dest_folder}</echo>
+    <mkdir dir="${dest_folder}" />
+    <exec executable="unzip">
+      <arg value="-q" />
+      <arg value="-n" />
+      <arg value="-d" />
+      <arg value="${dest_folder}" />
+      <arg value="${archive_file}" />
+    </exec>
   </target>
 
   <target name="linux-dist" depends="build"
@@ -731,11 +718,19 @@
     </copy>
 
     <!-- Unzip AVR tools -->
-    <antcall target="unzip-avr-toolchain">
-      <param name="file_arch" value="win32" />
+    <antcall target="unzip">
+      <param name="archive_file" value="${staging_folder}/avr-toolchain-win32-gcc-4.8.1.zip" />
+      <param name="archive_url" value="http://downloads.arduino.cc/avr-toolchain-win32-gcc-4.8.1.zip" />
+      <param name="final_folder" value="${staging_folder}/work/${staging_hardware_folder}/tools/avr" />
+      <param name="dest_folder" value="${staging_folder}/work/${staging_hardware_folder}/tools/avr" />
     </antcall>
 
-    <antcall target="unzip-libastyle" />
+    <antcall target="unzip">
+      <param name="archive_file" value="./libastylej-2.04.zip" />
+      <param name="archive_url" value="http://downloads.arduino.cc/libastylej-2.04.zip" />
+      <param name="final_folder" value="${staging_folder}/libastylej" />
+      <param name="dest_folder" value="${staging_folder}" />
+    </antcall>
     <copy file="windows/libastylej/AStylej.dll" todir="windows/work/lib" />
 
     <!-- Copy bossac.exe tool -->

From f462191dba694a9fd6c55f390730d761dcb95507 Mon Sep 17 00:00:00 2001
From: Federico Fissore <f.fissore@arduino.cc>
Date: Wed, 8 Oct 2014 17:16:50 +0200
Subject: [PATCH 5/6] build.xml: moved checksum into untar-unzip-checksum

---
 build/build.xml | 21 +++++----------------
 1 file changed, 5 insertions(+), 16 deletions(-)

diff --git a/build/build.xml b/build/build.xml
index f4f0b3754..dccdae3c0 100644
--- a/build/build.xml
+++ b/build/build.xml
@@ -552,8 +552,7 @@
     <get src="${archive_url}" dest="${archive_file}" verbose="true" ignoreerrors="true" />
   </target>
 
-  <!-- Ensure that the tool is downloaded and test checksums, if everything's ok unzip it on the tools folder  -->
-  <target name="untar" depends="untar-unzip-download" unless="${archive_file}_installed">
+  <target name="untar-unzip-checksum" depends="untar-unzip-download">
     <echo>Testing checksum of "${archive_file}"</echo>
     <checksum file="${archive_file}" algorithm="sha" fileext=".sha" verifyproperty="checksum.matches"/>
     <condition property="checksum.matches.fail">
@@ -564,8 +563,10 @@
       File ${archive_file} failed checksum.
       Please remove "${archive_file}" to download it again.
     </fail>
+  </target>
 
-    <!-- Unzip tool to the destination folder -->
+  <!-- Ensure that the tool is downloaded and test checksums, if everything's ok unzip it on the tools folder  -->
+  <target name="untar" depends="untar-unzip-checksum" unless="${archive_file}_installed">
     <echo>Unzipping into folder ${dest_folder}</echo>
     <exec executable="tar">
       <arg value="xfz"/>
@@ -574,19 +575,7 @@
     </exec>
   </target>
 
-  <target name="unzip" depends="untar-unzip-download" unless="${archive_file}_installed">
-    <echo>Testing checksum of "${archive_file}"</echo>
-    <checksum file="${archive_file}" algorithm="sha" fileext=".sha" verifyproperty="checksum.matches"/>
-    <condition property="checksum.matches.fail">
-      <equals arg1="${checksum.matches}" arg2="false"/>
-    </condition>
-    <fail if="checksum.matches.fail">Checksum failed.
-
-      File ${archive_file} failed checksum.
-      Please remove "${archive_file}" to download it again.
-    </fail>
-
-    <!-- Unzip tool to the destination folder -->
+  <target name="unzip" depends="untar-unzip-checksum" unless="${archive_file}_installed">
     <echo>Unzipping into folder ${dest_folder}</echo>
     <mkdir dir="${dest_folder}" />
     <exec executable="unzip">

From f60745485f100e8649dfe7b994c9cc685280373c Mon Sep 17 00:00:00 2001
From: Federico Fissore <f.fissore@arduino.cc>
Date: Wed, 8 Oct 2014 17:25:53 +0200
Subject: [PATCH 6/6] build.xml: tar autodetects archive type, removing "z"
 flag

---
 build/build.xml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/build/build.xml b/build/build.xml
index dccdae3c0..5934a026c 100644
--- a/build/build.xml
+++ b/build/build.xml
@@ -569,7 +569,7 @@
   <target name="untar" depends="untar-unzip-checksum" unless="${archive_file}_installed">
     <echo>Unzipping into folder ${dest_folder}</echo>
     <exec executable="tar">
-      <arg value="xfz"/>
+      <arg value="xf"/>
       <arg value="${archive_file}"/>
       <arg value="--directory=${dest_folder}"/>
     </exec>
@@ -617,7 +617,6 @@
     <move file="linux/work" tofile="linux/arduino-${version}" />
 
     <exec executable="tar" dir="linux">
-      <arg value="-z"/>
       <arg value="-c"/>
       <arg value="-f"/>
       <arg value="arduino-${version}-${platform}.tgz"/>
@@ -674,7 +673,7 @@
     <get src="http://switch.dl.sourceforge.net/project/launch4j/launch4j-3/3.0.2/launch4j-3.0.2-linux.tgz" dest="windows" usetimestamp="true" skipexisting="true" verbose="true" />
 
     <exec executable="tar" dir="windows/launcher">
-      <arg value="-xzf"/>
+      <arg value="-xf"/>
       <arg value="../launch4j-3.0.2-linux.tgz"/>
     </exec>
   </target>