1
0
mirror of https://github.com/arduino/Arduino.git synced 2025-03-01 23:29:28 +01:00

Fixed incorrect boards.txt preference handling when submenu id has underscore

Fixes #2533
This commit is contained in:
Cristian Maglie 2015-01-27 20:22:22 +01:00
parent 379df90b30
commit e360f82cae

View File

@ -154,18 +154,27 @@ public class BaseNoGui {
TargetBoard board = getTargetBoard(); TargetBoard board = getTargetBoard();
if (board == null) if (board == null)
return null; return null;
String boardId = board.getId();
PreferencesMap prefs = new PreferencesMap(board.getPreferences()); PreferencesMap prefs = new PreferencesMap(board.getPreferences());
String extendedName = prefs.get("name");
for (String menuId : board.getMenuIds()) { for (String menuId : board.getMenuIds()) {
if (!board.hasMenu(menuId))
continue;
// Get "custom_[MENU_ID]" preference (for example "custom_cpu")
String entry = PreferencesData.get("custom_" + menuId); String entry = PreferencesData.get("custom_" + menuId);
if (board.hasMenu(menuId) && entry != null && if (entry != null && entry.startsWith(boardId)) {
entry.startsWith(board.getId())) {
String selectionId = entry.substring(entry.indexOf("_") + 1); String selectionId = entry.substring(boardId.length() + 1);
prefs.putAll(board.getMenuPreferences(menuId, selectionId)); prefs.putAll(board.getMenuPreferences(menuId, selectionId));
prefs.put("name", prefs.get("name") + ", " +
board.getMenuLabel(menuId, selectionId)); // Update the name with the extended configuration
extendedName += ", " + board.getMenuLabel(menuId, selectionId);
} }
} }
prefs.put("name", extendedName);
return prefs; return prefs;
} }