Cristian Maglie
482b905a62
Using Optional<T> semantics for 'replacedLib' in LibraryInstaller
...
Optional<T> helps to not forget to check about nullness where it is
needed.
This commit should be equivalent and shouln't fix any bug, BTW the
Optional<T> semantic turns out to be useful in the next commits.
Possibly all nullable values will be replaced by Optional in the
future.
2018-05-17 09:14:25 +02:00
Cristian Maglie
212825eb55
Simplified overly complex filtering of InstallerJDialog
...
- we ensure that there is always a filter selected, no more need
to check for non-nullness
- the filters are always the same, no need to pass a
Stream<Predicate<T>> around where Predicate<T> suffices
2018-05-17 09:14:25 +02:00
Cristian Maglie
f111905da6
Removed a lot of useless equals overrides.
...
Those introduces a very convoluted logic that is needed only in
two cases. Moreover those are better handled by directly checking
the object.
2018-05-17 09:14:25 +02:00
Cristian Maglie
b832e0d8b1
Use anyMatch instead of count in ContributionSelfCheck checks
2018-05-17 09:14:25 +02:00
Cristian Maglie
d285b7fdc9
Improved VersionComparator API
2018-05-17 09:14:25 +02:00
Cristian Maglie
27b99860b4
Simplified SketchController.isReadOnly(..) method
...
Since the method is called everywhere with the following parameters
isReadOnly(
BaseNoGui.librariesIndexer.getInstalledLibraries(),
BaseNoGui.getExamplesPath())
)
the static calls to BaseNoGui have been inlined into isReadOnly()
removing all the duplications around.
2018-05-17 09:14:25 +02:00
Cristian Maglie
627d4fb536
Removed NoopPredicate
2018-05-17 09:14:25 +02:00
Martino Facchin
2be54da740
SaveAs should preserve the folder structure if user selected a sketch
...
Fixes https://github.com/arduino/Arduino/issues/6416
2018-05-10 10:54:54 +02:00
Martino Facchin
950d88dcbe
Handle unsaved tab deletion correctly
2018-05-09 16:09:29 +02:00
Martino Facchin
f8540b3a59
rescan libraries when installing from zip file
...
Fixes https://github.com/arduino/Arduino/issues/6960
2018-05-09 16:09:29 +02:00
Martino Facchin
b6280cfd65
Apply on-the-fly setFontSize to Console
...
Fixes #7022
2018-05-09 15:56:11 +02:00
Cristian Maglie
4aec8997e2
If theme couldn't be loaded print a message explaining why
2018-05-09 11:44:03 +02:00
Cristian Maglie
b96b2508db
Fixed warnings
2018-05-09 11:43:40 +02:00
Martino Facchin
01519eba9c
Move Sketchbook preparation before Theme.init()
...
Fixes NPE when searching for themes in portable installation
2018-05-08 16:53:55 +02:00
Martino Facchin
260e0c284c
Abbreviate Theme name to max 40 characters
2018-05-08 16:53:55 +02:00
Mumfrey
794ef806f1
Support selectable, user-defined themes contained in zip files
2018-05-08 16:53:55 +02:00
Mumfrey
78ef37ef08
Support user-defined theme elements via "theme" folder in sketchbook dir
2018-05-08 16:53:54 +02:00
Martino Facchin
60f267745b
Add on-hover selection on Board/Library manager
...
User testing on skilled devs showed that "buttons appear on click" behaviour is far from being understood.
Accessibility features (like moving with Arrow keys) should be untouched.
2018-05-02 16:41:59 +02:00
Martino Facchin
a47e62627c
[Lib/Board Manager] Give some padding to the dropdown lists
2018-05-02 16:41:59 +02:00
Martino Facchin
1f9d99b699
Add copy/paste contextual menu to Firnd/replace text fields
...
Fixes #4883
2018-05-02 16:17:06 +02:00
Martino Facchin
921dd272ad
Update jackson to 2.9.5
...
Fixes CVE-2018-7489
2018-05-02 16:14:03 +02:00
Martino Facchin
4562b4ba44
Update jmdns to 3.5.3
2018-05-02 16:12:32 +02:00
Martino Facchin
634fe10fa2
Mitigate stdout roaming through editor consoles
...
Still not a perfect solution; two compilation outputs will mix up anyway.
A major refactor should be needed to avoid using System.out anywhere and inverse multiplexing the streams so they can be muted or replicated on any Console.
2018-05-02 15:52:13 +02:00
Martino Facchin
c4f5cafd33
Moving a sketch to another folder should move all files
...
Fixes #6402
2018-05-02 15:52:13 +02:00
Cristian Maglie
1fd794dfdb
Cache editor tools (don't create new instance for each menu item)
2018-05-02 15:26:14 +02:00
Cristian Maglie
a15abacc7f
Added setting for autoformat before saving (editor.autoformat_currentfile_before_saving)
2018-05-02 15:26:14 +02:00
Cristian Maglie
8e0d668344
Serial Monitor: added "show timestamp" checkbox
2018-05-02 15:26:14 +02:00
Cristian Maglie
0175a4ee94
Revert "Fix keyword loading to use any whitespace as separator"
...
This reverts commit eed9e7069f
.
See #6693
2018-02-19 12:58:01 +01:00
Cristian Maglie
8ffbe05437
Sligthly simplified buildImportMenu loop
2018-01-18 11:46:49 +01:00
Cristian Maglie
534d62653c
Removed deprecated method Base.getLibraries()
2018-01-03 15:17:20 +01:00
Cristian Maglie
3ed68c5d71
No need to make copy of list when caling BaseNoGui.librariesIndexer.getInstalledLibraries()
2018-01-03 15:04:44 +01:00
Cristian Maglie
472d0b8ef6
Removed unused import
2018-01-03 14:50:55 +01:00
Corey Knapp
9891a6ba21
Improve accessibility in the Preferences dialog
...
This commit makes the Preferences dialog more usable by accessibility devices like screen readers.
Previously, a screen reader would only read the content of the text boxes. By using JLabel's setLabelFor() feature (and in some extreme cases, setAccessibleName()), a screen reader will know that a label is assigned to a text field. For example, instead of just reading "12", it will now read "Editor font size: 12".
2017-11-10 07:57:38 -05:00
Flavio Monteiro
a3f59fae91
Display the keyboard shortcut tip on both "Manage Libraries..."
...
This commit adds the Menu+Shift+I shortcut to the remaining menu entry in Base.java.
When the shortcut is called, the menu entry from Base.java is the one that will be called.
2017-10-30 11:04:26 +01:00
Flavio Monteiro
f8621b0421
Add Menu+Shift+I shortcut to the Library Manager
...
Please note that this commit actually adds the shortcut to its menu
entry under the "Tools" menu.
As a side effect, the shortcut tip is only shown in this entry and not
on the another one.
Menu usually means the Ctrl key on most modern systems.
2017-10-30 11:04:26 +01:00
Flavio Monteiro
d860c907bb
Show "Manage Libraries" item in the Tools menu too
...
This duplicates the entry, so now "Manage Libraries..." is available
in both under the "Tools" menu and inside the "Sketch" -> "Include
Library" menu.
The reasons for this change are:
- It makes sense for the entry to be there
- It makes easier for the user to click on the entry
Aditionally, I added a comment about a issue I found with the
newJMenuItemShift function on Xubuntu 17.04 regarding the Ctrl+Shift+K
shortcut.
2017-10-30 11:04:26 +01:00
Flavio Monteiro
4a80f50d28
Trim trailing spaces from Editor.java
2017-10-30 11:04:26 +01:00
Flavio Monteiro
bafd66ba4f
Fix comment of the ctrlAlt() helper function
2017-10-30 11:04:26 +01:00
Cristian Maglie
48384a7ad0
tests: added some missing null checks
2017-10-20 13:17:09 +02:00
Brett Hagman
eed9e7069f
Fix keyword loading to use any whitespace as separator
...
Instead of forcing keywords.txt to use tabs, let library developers use spaces too.
2017-10-16 18:19:35 +02:00
Martino Facchin
0460dc4941
Add accelerator for scrollable menus
...
Press A when on a scrollable menu for a 6x acceleration
2017-10-16 18:19:35 +02:00
Martino Facchin
bfea2724ba
Add scroller for programmers menu
2017-10-16 18:19:35 +02:00
Martino Facchin
ffa13ed733
Keep "Board Manager" entry always on top of its menu
2017-10-16 18:19:35 +02:00
ReAlUA
ba04ed2f7f
Correct grammatical gender for Ukrainian in Ukrainian
2017-10-11 11:55:45 +02:00
ReAlUA
190eb8f9b1
IDE: call translation function for lastLibType
...
In menu Sketch/Include Library/ library types (Arduino|Recommended|Contributed) are not translated into selected «Editor language» although types are translated in .po files.
2017-10-11 11:55:45 +02:00
Cristian Maglie
d0f8037f6d
Added exception printout while building
2017-09-28 13:13:29 +02:00
Cristian Maglie
369b23a7d2
Refactored function to get status of menus in MacOSX
2017-09-28 12:57:56 +02:00
Martino Facchin
59a57a9312
Use classic close() handle when macOS 10.13 workaround is on
2017-09-28 09:25:46 +02:00
Martino Facchin
a2b5f661b8
Fix macOS 10.13 missing menubar
...
The global bar is being used if locale is English and About() menu is present
2017-09-27 17:43:52 +02:00
Cristian Maglie
5427f94b9d
Do not allow negative font resize
...
Fix #6359 (again)
2017-08-28 17:57:21 +02:00
Cristian Maglie
fcd88e6a43
IDE: "New/rename tab" now allow numbers as first char
...
Fix #6656
Related to #6592 and 4545283ae7
2017-08-28 14:35:49 +02:00
Martino Facchin
328296a2c5
Only reapply serial monitor last location if it fits the screen
...
There could be a couple of edge cases in this approach (for example, if someone wants to keep the serial monitor window only half visible).
However, it should be at least safe (no serial monitors on the second screen) if the Window Manager acts correctly (by moving all the windows on the second monitor to the primary on detach).
2017-08-18 15:25:11 +02:00
Martino Facchin
8292989e2d
Separate screen dimensions storing from recent sketches
2017-08-18 15:25:11 +02:00
Cristian Maglie
4545283ae7
Sketch names starting with a digit are now allowed
...
Fix #6592
2017-08-18 15:11:24 +02:00
Martino Facchin
ad02e4940c
Merge pull request #6130 from facchinm/allow_resizing_console_to_zero
...
Allow setting low values as minimum console size
2017-08-01 11:47:01 +02:00
Martino Facchin
d9d1406f64
Merge pull request #6459 from facchinm/smaller_preference_panel
...
Remove gaps on confirmation button to fit 600px height
2017-08-01 11:46:22 +02:00
Martino Facchin
91cdf53147
Merge pull request #6551 from facchinm/test_pr6394
...
Add font size shortcuts (menu, keyboard and mouse)
2017-08-01 11:45:04 +02:00
Martino Facchin
0c4d59d13f
Merge pull request #6411 from facchinm/huge_serialportlist_scrollable
...
Add scroller for serial port list menu
2017-08-01 11:44:28 +02:00
Cristian Maglie
93217c40c7
CLI: fixed missing "runtime.platform.path"
...
This happens when the CLI is runned without the `--board` option.
Fix #6463
2017-07-27 15:56:24 +02:00
Martino Facchin
388822ad95
Implement font increse/decrease with CTRL+MouseWheel
2017-07-25 14:58:10 +02:00
Martino Facchin
c07f8fca54
Use CTRL+"+" as Increase Font shortcut
2017-07-25 14:57:21 +02:00
Cristian Maglie
ddf60361d6
Toolbar can now go full width on 4K display
...
Fix #5341
2017-07-18 14:00:56 +02:00
Martino Facchin
2191315123
[Pref panel] Remove gaps on confirmation button to fit 600px height
...
Should solve #4753
2017-07-05 11:19:46 +02:00
Martino Facchin
76f4668f02
Call setScrollerFor port menu only once
2017-06-26 09:43:22 +02:00
Martino Facchin
506ebd8011
add scroller for serial port list menu
...
Fixes #6397
2017-06-22 10:24:22 +02:00
Michael G
04a7e7ff15
Add font size shortcuts (menu and keyboard)
2017-06-20 11:33:24 +02:00
Cristian Maglie
d65e6ffc3d
Merge pull request #6331 from cmaglie/jssc-no-unpack
...
Two fix for future Windows compatibility
2017-05-30 15:58:10 +02:00
Cristian Maglie
229c32ccad
Avoid dll unpacking within JSSC
...
This requires a custom build of JSSC.
https://github.com/scream3r/java-simple-serial-connector/pull/105
2017-05-18 15:36:17 +02:00
Cristian Maglie
626a00a9bf
Show the dialog just once when there are many unsaved sketches
2017-05-16 14:53:27 +02:00
Cristian Maglie
e500c7c41f
Enabling "external editor" now requires to save all sketches.
...
Fix #6196
2017-05-16 14:53:27 +02:00
Cristian Maglie
00c1a3b3eb
Renamed editor.auto_close_braces pref and set default value
2017-04-13 11:38:23 +02:00
bob
8ecbded312
add editor.autocomplete flag to disable automatic curly braces
2017-04-13 11:38:23 +02:00
Martino Facchin
39da3f0867
Apply editor.indent preference
...
Solves #6128
2017-04-13 11:38:23 +02:00
Cristian Maglie
323bd64a60
Serial Monitor: move "clear output" button from left to right side
2017-04-10 16:26:08 +02:00
Michael michael.sytko
99006fc5c6
Serial Monitor: added "clear output" button
2017-04-10 16:19:19 +02:00
Michael michael.sytko
8943b7ccbe
added custom title format setting (editor.custom_title_format)
2017-04-10 14:24:26 +02:00
Michael michael.sytko
74384400e2
configurable shortcut for comment / uncomment
2017-04-10 14:24:26 +02:00
Cristian Maglie
e4ebd4a6fc
Fixed CommandLineTest for windows
2017-04-10 13:49:04 +02:00
Martino Facchin
0190225050
Allow setting low values as minimum console size
...
Fixes #6085 when setting console.lines=0 in preferences.txt
2017-03-27 12:52:47 +02:00
Cristian Maglie
c70efd950f
Fixed --save-prefs regression
...
Also removed deprecated Prefences.save() method.
Fix #6067
2017-03-22 13:13:06 +01:00
Cristian Maglie
39f396e55a
Added test to check preference saving from cmd line
...
See #6067
2017-03-22 12:59:38 +01:00
Cristian Maglie
674419a464
Fixed a bunch of trivial javac warnings
2017-03-22 12:12:46 +01:00
Martino Facchin
5b6adec95f
add preference checkbox for core cache
2017-03-20 17:31:38 +01:00
Sandeep Mistry
3e9448d34b
Disable serial monitor for non-SSH network ports
2017-03-20 15:09:54 +01:00
tomneutens
938df21778
Added a CompilerProgressListenerList to the EditorStatus class so you can add a listener for compiler progress from an external tool. To enable this the build method in the compiler class had to be changed
2017-03-15 19:32:53 +02:00
Petri Laarne
1fc0997f71
Do not delete the source if source = destination
...
While the previous version could handle the case, it only did so after
deleting the destination file, therefore causing data loss.
2017-03-08 13:23:50 +01:00
Cristian Maglie
1f35bfca53
Fixed regression tests on Indent/Unindent and Comment/Uncomment actions
...
RSTA for some reason doesn't fire update signals on DocumentListeners.
2017-03-01 10:38:09 +01:00
Matthijs Kooijman
f5eb673f44
Update RSyntaxTextArea to 2.6.1
...
This imports the unmodified upstream version of RSTA from
http://repo1.maven.org/maven2/com/fifesoft/rsyntaxtextarea/2.6.1/rsyntaxtextarea-2.6.1.jar
since the Arduino-specific changes are no longer required.
This fixes #5888
2017-03-01 10:38:09 +01:00
Cristian Maglie
5f12bb9a3e
Removed the need for get/setUndoManager()
...
This dramatically simplifies undo/redo handling and allows to use
unpatched RSyntaxTextArea library.
2017-03-01 10:38:09 +01:00
Cristian Maglie
1062307c52
Removed some redundant this
keyword
2017-02-27 13:48:54 +01:00
Cristian Maglie
dd17388280
Removed unneeded up-cast
2017-02-27 13:48:54 +01:00
Matthijs Kooijman
87c917f4ea
Remove unused CaretAwareUndoableEdit class
...
It seems this class has been unused since the switch to RSyntaxTextArea
was made.
2017-02-27 13:46:38 +01:00
Cristian Maglie
ad503bce6d
Added missing license
2017-02-27 13:45:16 +01:00
Martino Facchin
c0a99f9ec9
Disallow opening Serial monitor during compilation
...
Commit 6d5597b070
introduced a guard against multiple concurrent operations.
This guard also avoid any real serial monitor "open" during the compile+upload phase, but it didn't handle keyboard shortcuts.
Fixes https://github.com/arduino/Arduino/issues/6015
2017-02-24 16:42:58 +01:00
Cristian Maglie
ffe6aee5a6
Updated eclipse formatter options
2017-02-20 15:22:27 +01:00
Cristian Maglie
4d6385ab6d
Serial monitor: input textfield is automatically selected
...
When the serial monitor window is focused again (not reopened but put
in background and selected again) the text input field is now
automatically focused.
Fix #5810
2017-02-17 10:57:20 +01:00
Martino Facchin
e9e24bd369
Merge pull request #5879 from facchinm/better-mdns
...
Update jmdns to 3.5.1
2017-02-10 18:36:14 +01:00
Dan Stutts
a095d2a3c8
Add 500Kbps, 1Mbps and 2Mbps to the list of available serial speeds
2017-02-08 17:21:12 +01:00
Cristian Maglie
61cccc0151
verify/upload from CLI with relative path works again
...
Fix #5836
2017-01-23 13:41:03 +01:00
Cristian Maglie
3f74631762
Added test for command line regression
...
See #5836
2017-01-23 13:41:03 +01:00