This patch will require a little rework before it gets submitted.
1) I don't know if the Arduino team will simply edit the existing binary
dependencies in place and hence NOT change the filename like I have below
(libastylej-2.05.1-3.zip -> libastylej-2.05.1-4.zip), or will indeed
upload to new a filename.
2) Since the Arduino team will build and distribute all the binaries, the
SHA values in the patch below will have to be recalculated once the actual
files are available. The values below are for my locally built versions.
This reverts commits:
385edd26fc (Removed "macosx-fix-bundled-toolchain-missing-symlinks" build task)
f5fd6423c3 (Updated avrdude to 6.3-arduino2)
5a01929b8f (avrdude 6.3: fixed IDE build for macosx)
And part of this commit:
05b647721c (Update avr-gcc to 4.9.2 and avrdude to 6.3)
This ensures now splash-screen is shown when preferences are changed or CLI-mode is used.
More information in #5131.
However this does NOT fix#5131, since the Arduino IDE in CLI-mode still requires X11 (according to #1981).
Install script adds menu item, desktop icon, file association for
the current user - even if the Arduino installation was placed
outside of the user's home dir (such as in /opt or /usr/local).
Added three more icon resolutions (64px, 72px, 96px) - by using
the 256px file - maybe there is a better source available for this...
Modified build.xml for copying the existing icons and mime.xml file,
both scripts and adjusted file permissions (ugo+x) for *.sh files to
be executable by others by default.
The startup bash script lacked quotes in some places, causing it to
interpret part of the path to the splash image as the main class and
fail to start:
arduino: line 29: [: /home/a/Arduino: binary operator expected
Error: Could not find or load main class IDE.lib.splash.png
For the -splash option, simply adding quotes was not sufficient. If no
splash screen was to be used (so when $SPLASH was empty), using
"$SPLASH" would result in an empty argument being passed to java, which
was then interpreted by java as the name of the base class.
To allow spaces to occur in the -splash option, but also allow it to be
omitted entirely, options to java are now passed through the
$JAVA_OPTIONS array. By using the special "${JAVA_OPTIONS[@]}" syntax,
each element in the array is expanded into a single argument, even when
spaces are present inside (this is identical to what happens with "$@").
This fixes#3950
Also upgrading appbundler with a patched version: https://bitbucket.org/ffissore/appbundler It allows to know the current working directory
These two put together, we can now rely on APP_DIR when loading IDE resources while being sure current working directory is properly set, thus being much more friendly when run from CLI
Fixes#1493
