mirror of
https://github.com/arduino/Arduino.git
synced 2025-02-08 02:54:24 +01:00
af8e1e6dc4
The tests would initialize Base, PreferencesData with default settings and/or run the arduino executable, without specifying any settings to use. In practice, this would read settings from e.g. `~/.arduino15`, load libraries from the user's sketchbook, etc. This is not a good idea, since this can be influence the test. For example, the presence of invalid libraries would cause extra output to be generated, which breaks the `--version` test. Or having the "Use external editor" setting set would break tests that try to edit a sketch. This commit fixes this. The core of this commit is in `AbstractWithPreferencesTest`, which sets up a clean settings dir (to replace `~/.arduino15`) with a sketchbook and `preferences.txt` file inside before every test (and removes it again after the test. For some tests, this is enough, but some tests create an instance of `Base`, which again initializes everything, including preferences, from the default location. To prevent that, `--preferences-file` is passed to the `Base` constructor, loading the previously set up preferences. This is handled by the new `AbstractWithPreferencesTest.createBase()` method. Furthermore, CommandLineTest calls the actual Arduino executable, which has the same problem. This is fixed by passing the same `--preferences-file` option on the commandline (generated by `AbstractWithPreferencesTest.getBaseArgs()`). This should prevent all tests from reading the the default settings files, fixing some tests on my system and even speeding up the tests somewhat (due less libraries and cores to load, probably).
69 lines
2.3 KiB
Java
69 lines
2.3 KiB
Java
/*
|
|
* This file is part of Arduino.
|
|
*
|
|
* Copyright 2015 Arduino LLC (http://www.arduino.cc/)
|
|
*
|
|
* Arduino is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*
|
|
* As a special exception, you may use this file as part of a free software
|
|
* library without restriction. Specifically, if other files instantiate
|
|
* templates or use macros or inline functions from this file, or you compile
|
|
* this file and link it with other files to produce an executable, this
|
|
* file does not by itself cause the resulting executable to be covered by
|
|
* the GNU General Public License. This exception does not however
|
|
* invalidate any other reasons why the executable file might be covered by
|
|
* the GNU General Public License.
|
|
*/
|
|
|
|
package processing.app;
|
|
|
|
import org.junit.After;
|
|
import org.junit.Assume;
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
|
|
import processing.app.debug.TargetBoard;
|
|
import static org.junit.Assert.assertNotEquals;
|
|
|
|
public class DefaultTargetTest extends AbstractWithPreferencesTest {
|
|
|
|
private String oldBoardID;
|
|
|
|
@Before
|
|
public void saveBoardFromPreferences() throws Exception {
|
|
oldBoardID = PreferencesData.get("board");
|
|
}
|
|
|
|
@After
|
|
public void restoreBoardIntoPreferences() throws Exception {
|
|
PreferencesData.set("board", oldBoardID);
|
|
PreferencesData.save();
|
|
}
|
|
|
|
@Test
|
|
public void testDefaultTarget() throws Exception {
|
|
PreferencesData.set("board", "unreal_board");
|
|
|
|
// should not raise an exception
|
|
createBase();
|
|
|
|
// skip test if no target platforms are available
|
|
Assume.assumeNotNull(BaseNoGui.getTargetPlatform());
|
|
|
|
TargetBoard targetBoard = BaseNoGui.getTargetBoard();
|
|
assertNotEquals("unreal_board", targetBoard.getId());
|
|
}
|
|
}
|