From 0aabaa209d8787b906dc13d0a2c67f55edd30687 Mon Sep 17 00:00:00 2001 From: Martijn Cuppens Date: Wed, 21 Aug 2019 10:33:26 +0200 Subject: [PATCH] Drop nav divider mixin --- scss/_dropdown.scss | 5 ++++- scss/_mixins.scss | 1 - scss/mixins/_nav-divider.scss | 10 ---------- site/content/docs/4.3/migration.md | 3 ++- 4 files changed, 6 insertions(+), 13 deletions(-) delete mode 100644 scss/mixins/_nav-divider.scss diff --git a/scss/_dropdown.scss b/scss/_dropdown.scss index 70c07ab4bd..4bfa8ac9df 100644 --- a/scss/_dropdown.scss +++ b/scss/_dropdown.scss @@ -113,7 +113,10 @@ // Dividers (basically an `
`) within the dropdown .dropdown-divider { - @include nav-divider($dropdown-divider-bg, $dropdown-divider-margin-y); + height: 0; + margin: $dropdown-divider-margin-y 0; + overflow: hidden; + border-top: 1px solid $dropdown-divider-bg; } // Links, buttons, and more within the dropdown menu diff --git a/scss/_mixins.scss b/scss/_mixins.scss index ffee78ac2e..aac26155fe 100644 --- a/scss/_mixins.scss +++ b/scss/_mixins.scss @@ -27,7 +27,6 @@ @import "mixins/pagination"; @import "mixins/lists"; @import "mixins/list-group"; -@import "mixins/nav-divider"; @import "mixins/forms"; @import "mixins/table-row"; diff --git a/scss/mixins/_nav-divider.scss b/scss/mixins/_nav-divider.scss deleted file mode 100644 index 4fb37b6224..0000000000 --- a/scss/mixins/_nav-divider.scss +++ /dev/null @@ -1,10 +0,0 @@ -// Horizontal dividers -// -// Dividers (basically an hr) within dropdowns and nav lists - -@mixin nav-divider($color: $nav-divider-color, $margin-y: $nav-divider-margin-y) { - height: 0; - margin: $margin-y 0; - overflow: hidden; - border-top: 1px solid $color; -} diff --git a/site/content/docs/4.3/migration.md b/site/content/docs/4.3/migration.md index dd98b6adc4..b530421b68 100644 --- a/site/content/docs/4.3/migration.md +++ b/site/content/docs/4.3/migration.md @@ -23,9 +23,10 @@ See the browser and devices page for details on what is currently supported in B Changes to our source Sass files and compiled CSS. - Removed `hover`, `hover-focus`, `plain-hover-focus`, and `hover-focus-active` mixins. Use regular CSS syntax for these moving forward. [See #28267](https://github.com/twbs/bootstrap/pull/28267). -- **Todo:** Remove previously deprecated mixins +- Remove previously deprecated mixins - `float()` - `form-control-mixin()` + - `nav-divider()` - `retina-img()` - `text-hide()` (also dropped the associated utility class, `.text-hide`) - `visibility()`