From 0be41096888201831c151864c0ab05cf0b5ca734 Mon Sep 17 00:00:00 2001 From: Mike Greiling Date: Thu, 29 May 2014 02:24:41 -0500 Subject: [PATCH] there is no need for this.offsets and this.targets to be jQuery objects --- js/scrollspy.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/js/scrollspy.js b/js/scrollspy.js index cddde45ada..de4f987076 100644 --- a/js/scrollspy.js +++ b/js/scrollspy.js @@ -24,8 +24,8 @@ this.selector = (this.options.target || ((href = $(element).attr('href')) && href.replace(/.*(?=#[^\s]+$)/, '')) //strip for ie7 || '') + ' .nav li > a' - this.offsets = $([]) - this.targets = $([]) + this.offsets = [] + this.targets = [] this.activeTarget = null this.refresh() @@ -41,8 +41,9 @@ ScrollSpy.prototype.refresh = function () { var offsetMethod = this.$element[0] == window ? 'offset' : 'position' - this.offsets = $([]) - this.targets = $([]) + this.offsets = [] + this.targets = [] + var self = this this.$body @@ -75,7 +76,7 @@ var i if (scrollTop >= maxScroll) { - return activeTarget != (i = targets.last()[0]) && this.activate(i) + return activeTarget != (i = targets[targets.length - 1]) && this.activate(i) } if (activeTarget && scrollTop <= offsets[0]) {