mirror of
https://github.com/twbs/bootstrap.git
synced 2025-02-21 18:54:30 +01:00
remove selector options for popover, in favor of more generic content selector
This commit is contained in:
parent
b37a336417
commit
0c7a80c79b
@ -691,18 +691,6 @@ $('#.tabs').bind('change', function (e) {
|
|||||||
<td>[default markup]</td>
|
<td>[default markup]</td>
|
||||||
<td>the html template used for rendering a popover</td>
|
<td>the html template used for rendering a popover</td>
|
||||||
</tr>
|
</tr>
|
||||||
<tr>
|
|
||||||
<td>titleSelector</td>
|
|
||||||
<td>string</td>
|
|
||||||
<td>.title</td>
|
|
||||||
<td>selector used to find the title element within the popover</td>
|
|
||||||
</tr>
|
|
||||||
<tr>
|
|
||||||
<td>contentSelector</td>
|
|
||||||
<td>string</td>
|
|
||||||
<td>.content p</td>
|
|
||||||
<td>selector used to find the content element within the popover</td>
|
|
||||||
</tr>
|
|
||||||
</tbody>
|
</tbody>
|
||||||
</table>
|
</table>
|
||||||
<p><span class="label notice">Notice</span> Individual popover instance options can alternatively be specified through the use of data attributes.</code></p>
|
<p><span class="label notice">Notice</span> Individual popover instance options can alternatively be specified through the use of data attributes.</code></p>
|
||||||
|
6
js/bootstrap-popover.js
vendored
6
js/bootstrap-popover.js
vendored
@ -36,8 +36,8 @@
|
|||||||
|
|
||||||
setContent: function () {
|
setContent: function () {
|
||||||
var $tip = this.tip()
|
var $tip = this.tip()
|
||||||
$tip.find(this.options.titleSelector)[this.options.html ? 'html' : 'text'](this.getTitle())
|
$tip.find('.title')[this.options.html ? 'html' : 'text'](this.getTitle())
|
||||||
$tip.find(this.options.contentSelector)[this.options.html ? 'html' : 'text'](this.getContent())
|
$tip.find('.content > *')[this.options.html ? 'html' : 'text'](this.getContent())
|
||||||
$tip[0].className = 'popover'
|
$tip[0].className = 'popover'
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -83,8 +83,6 @@
|
|||||||
placement: 'right'
|
placement: 'right'
|
||||||
, content: 'data-content'
|
, content: 'data-content'
|
||||||
, template: '<div class="arrow"></div><div class="inner"><h3 class="title"></h3><div class="content"><p></p></div></div>'
|
, template: '<div class="arrow"></div><div class="inner"><h3 class="title"></h3><div class="content"><p></p></div></div>'
|
||||||
, titleSelector: '.title'
|
|
||||||
, contentSelector: '.content p'
|
|
||||||
})
|
})
|
||||||
|
|
||||||
$.fn.twipsy.rejectAttrOptions.push( 'content' )
|
$.fn.twipsy.rejectAttrOptions.push( 'content' )
|
||||||
|
23
js/tests/unit/bootstrap-popover.js
vendored
23
js/tests/unit/bootstrap-popover.js
vendored
@ -73,27 +73,4 @@ $(function () {
|
|||||||
$('#qunit-runoff').empty()
|
$('#qunit-runoff').empty()
|
||||||
})
|
})
|
||||||
|
|
||||||
test("should allow arbitrary template html with title and content selector options", function() {
|
|
||||||
$.support.transition = false
|
|
||||||
var expectedTitle = 'Gotta make you understand'
|
|
||||||
, popover = $('<a href="#">@rvagg</a>')
|
|
||||||
.attr('title', expectedTitle)
|
|
||||||
.attr('data-content', '<p><b>Never gonna give you up</b>,</p><p>Never gonna let you down</p>')
|
|
||||||
.appendTo('#qunit-runoff')
|
|
||||||
.popover({
|
|
||||||
html: true
|
|
||||||
, titleSelector: 'h1'
|
|
||||||
, contentSelector: '.rick > .roll'
|
|
||||||
, template: '<div class="rick"><h1></h1><div class="roll"></div></div>'
|
|
||||||
})
|
|
||||||
.popover('show')
|
|
||||||
|
|
||||||
ok($('.popover > div > h1').length, 'h1 tag was inserted')
|
|
||||||
ok($('.popover > div > h1').text() === expectedTitle)
|
|
||||||
ok($('.popover > .rick > .roll > p').length === 2, 'p > b tags were inserted')
|
|
||||||
popover.popover('hide')
|
|
||||||
ok(!$('.popover').length, 'popover was removed')
|
|
||||||
$('#qunit-runoff').empty()
|
|
||||||
})
|
|
||||||
|
|
||||||
})
|
})
|
||||||
|
Loading…
x
Reference in New Issue
Block a user