From 2ac2a5a91e2958a367c46a61d05162f640457db5 Mon Sep 17 00:00:00 2001 From: Martijn Cuppens Date: Fri, 7 Jun 2019 13:44:26 +0200 Subject: [PATCH] Removal of one of the most iconic components of Bootstrap: the jumbotron (#28876) --- scss/_jumbotron.scss | 17 ---- scss/_variables.scss | 7 -- scss/bootstrap.scss | 1 - site/content/docs/4.3/components/jumbotron.md | 29 ------- .../content/docs/4.3/examples/album/album.css | 33 -------- .../docs/4.3/examples/album/index.html | 28 +++--- .../content/docs/4.3/examples/blog/index.html | 2 +- .../docs/4.3/examples/jumbotron/index.html | 80 ------------------ .../docs/4.3/examples/jumbotron/jumbotron.css | 4 - .../4.3/examples/navbar-bottom/index.html | 2 +- .../docs/4.3/examples/navbar-fixed/index.html | 2 +- .../4.3/examples/navbar-static/index.html | 2 +- .../docs/4.3/examples/navbars/index.html | 2 +- site/content/docs/4.3/migration.md | 4 + site/data/examples.yml | 2 - site/data/nav.yml | 1 - .../docs/4.3/assets/img/examples/album.png | Bin 21740 -> 10760 bytes .../docs/4.3/assets/img/examples/album@2x.png | Bin 26370 -> 25026 bytes .../4.3/assets/img/examples/navbar-bottom.png | Bin 9774 -> 4873 bytes .../assets/img/examples/navbar-bottom@2x.png | Bin 11316 -> 11666 bytes .../4.3/assets/img/examples/navbar-fixed.png | Bin 11569 -> 5911 bytes .../assets/img/examples/navbar-fixed@2x.png | Bin 13616 -> 14103 bytes .../4.3/assets/img/examples/navbar-static.png | Bin 12523 -> 6624 bytes .../assets/img/examples/navbar-static@2x.png | Bin 14893 -> 15155 bytes .../docs/4.3/assets/img/examples/navbars.png | Bin 24748 -> 13126 bytes .../4.3/assets/img/examples/navbars@2x.png | Bin 27187 -> 31168 bytes 26 files changed, 23 insertions(+), 193 deletions(-) delete mode 100644 scss/_jumbotron.scss delete mode 100644 site/content/docs/4.3/components/jumbotron.md delete mode 100644 site/content/docs/4.3/examples/album/album.css delete mode 100644 site/content/docs/4.3/examples/jumbotron/index.html delete mode 100644 site/content/docs/4.3/examples/jumbotron/jumbotron.css mode change 100644 => 100755 site/static/docs/4.3/assets/img/examples/album.png mode change 100644 => 100755 site/static/docs/4.3/assets/img/examples/album@2x.png mode change 100644 => 100755 site/static/docs/4.3/assets/img/examples/navbar-bottom.png mode change 100644 => 100755 site/static/docs/4.3/assets/img/examples/navbar-bottom@2x.png mode change 100644 => 100755 site/static/docs/4.3/assets/img/examples/navbar-fixed.png mode change 100644 => 100755 site/static/docs/4.3/assets/img/examples/navbar-fixed@2x.png mode change 100644 => 100755 site/static/docs/4.3/assets/img/examples/navbar-static.png mode change 100644 => 100755 site/static/docs/4.3/assets/img/examples/navbar-static@2x.png mode change 100644 => 100755 site/static/docs/4.3/assets/img/examples/navbars.png mode change 100644 => 100755 site/static/docs/4.3/assets/img/examples/navbars@2x.png diff --git a/scss/_jumbotron.scss b/scss/_jumbotron.scss deleted file mode 100644 index bcd7dcad99..0000000000 --- a/scss/_jumbotron.scss +++ /dev/null @@ -1,17 +0,0 @@ -.jumbotron { - padding: $jumbotron-padding ($jumbotron-padding / 2); - margin-bottom: $jumbotron-padding; - color: $jumbotron-color; - background-color: $jumbotron-bg; - @include border-radius($border-radius-lg); - - @include media-breakpoint-up(sm) { - padding: ($jumbotron-padding * 2) $jumbotron-padding; - } -} - -.jumbotron-fluid { - padding-right: 0; - padding-left: 0; - @include border-radius(0); -} diff --git a/scss/_variables.scss b/scss/_variables.scss index 79e0793a75..716b551360 100644 --- a/scss/_variables.scss +++ b/scss/_variables.scss @@ -811,13 +811,6 @@ $pagination-disabled-bg: $white !default; $pagination-disabled-border-color: $gray-300 !default; -// Jumbotron - -$jumbotron-padding: 2rem !default; -$jumbotron-color: null !default; -$jumbotron-bg: $gray-200 !default; - - // Cards $card-spacer-y: .75rem !default; diff --git a/scss/bootstrap.scss b/scss/bootstrap.scss index 5f100326b7..6ded9f628f 100644 --- a/scss/bootstrap.scss +++ b/scss/bootstrap.scss @@ -35,7 +35,6 @@ @import "breadcrumb"; @import "pagination"; @import "badge"; -@import "jumbotron"; @import "alert"; @import "progress"; @import "list-group"; diff --git a/site/content/docs/4.3/components/jumbotron.md b/site/content/docs/4.3/components/jumbotron.md deleted file mode 100644 index 9810be418b..0000000000 --- a/site/content/docs/4.3/components/jumbotron.md +++ /dev/null @@ -1,29 +0,0 @@ ---- -layout: docs -title: Jumbotron -description: Lightweight, flexible component for showcasing hero unit style content. -group: components ---- - -A lightweight, flexible component that can optionally extend the entire viewport to showcase key marketing messages on your site. - -{{< example >}} -
-

Hello, world!

-

This is a simple hero unit, a simple jumbotron-style component for calling extra attention to featured content or information.

-
-

It uses utility classes for typography and spacing to space content out within the larger container.

- Learn more -
-{{< /example >}} - -To make the jumbotron full width, and without rounded corners, add the `.jumbotron-fluid` modifier class and add a `.container` or `.container-fluid` within. - -{{< example >}} -
-
-

Fluid jumbotron

-

This is a modified jumbotron that occupies the entire horizontal space of its parent.

-
-
-{{< /example >}} diff --git a/site/content/docs/4.3/examples/album/album.css b/site/content/docs/4.3/examples/album/album.css deleted file mode 100644 index bc81349c59..0000000000 --- a/site/content/docs/4.3/examples/album/album.css +++ /dev/null @@ -1,33 +0,0 @@ -.jumbotron { - padding-top: 3rem; - padding-bottom: 3rem; - margin-bottom: 0; - background-color: #fff; -} -@media (min-width: 768px) { - .jumbotron { - padding-top: 6rem; - padding-bottom: 6rem; - } -} - -.jumbotron p:last-child { - margin-bottom: 0; -} - -.jumbotron h1 { - font-weight: 300; -} - -.jumbotron .container { - max-width: 40rem; -} - -footer { - padding-top: 3rem; - padding-bottom: 3rem; -} - -footer p { - margin-bottom: .25rem; -} diff --git a/site/content/docs/4.3/examples/album/index.html b/site/content/docs/4.3/examples/album/index.html index bedeefcf38..366ac51164 100644 --- a/site/content/docs/4.3/examples/album/index.html +++ b/site/content/docs/4.3/examples/album/index.html @@ -1,8 +1,6 @@ --- layout: examples title: Album example -extra_css: - - "album.css" ---
@@ -39,14 +37,16 @@ extra_css:
-
-
-

Album example

-

Something short and leading about the collection below—its contents, the creator, etc. Make it short and sweet, but not too short so folks don’t simply skip over it entirely.

-

- Main call to action - Secondary action -

+
+
+
+

Album example

+

Something short and leading about the collection below—its contents, the creator, etc. Make it short and sweet, but not too short so folks don’t simply skip over it entirely.

+

+ Main call to action + Secondary action +

+
@@ -197,12 +197,12 @@ extra_css:
-