From 30861cbc6d450d70e646e2b1b35223f14d3d6973 Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Wed, 13 Feb 2019 21:40:15 +0200 Subject: [PATCH] Simplify checks. --- js/src/dom/eventHandler.js | 7 +++---- js/src/dom/manipulator.js | 2 +- js/src/util.js | 4 ++-- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/js/src/dom/eventHandler.js b/js/src/dom/eventHandler.js index c3d4f000a3..9049acfb62 100644 --- a/js/src/dom/eventHandler.js +++ b/js/src/dom/eventHandler.js @@ -132,7 +132,7 @@ function normalizeParams(originalTypeEvent, handler, delegationFn) { } function addHandler(element, originalTypeEvent, handler, delegationFn, oneOff) { - if (typeof originalTypeEvent !== 'string' || (typeof element === 'undefined' || element === null)) { + if (typeof originalTypeEvent !== 'string' || !element) { return } @@ -198,7 +198,7 @@ const EventHandler = { }, off(element, originalTypeEvent, handler, delegationFn) { - if (typeof originalTypeEvent !== 'string' || (typeof element === 'undefined' || element === null)) { + if (typeof originalTypeEvent !== 'string' || !element) { return } @@ -243,8 +243,7 @@ const EventHandler = { }, trigger(element, event, args) { - if (typeof event !== 'string' || - (typeof element === 'undefined' || element === null)) { + if (typeof event !== 'string' || !element) { return null } diff --git a/js/src/dom/manipulator.js b/js/src/dom/manipulator.js index 5210f8b2c6..31d0252c65 100644 --- a/js/src/dom/manipulator.js +++ b/js/src/dom/manipulator.js @@ -76,7 +76,7 @@ const Manipulator = { }, toggleClass(element, className) { - if (typeof element === 'undefined' || element === null) { + if (!element) { return } diff --git a/js/src/util.js b/js/src/util.js index 5467b9dab5..8b6226f61c 100644 --- a/js/src/util.js +++ b/js/src/util.js @@ -123,7 +123,7 @@ const Util = { }, makeArray(nodeList) { - if (typeof nodeList === 'undefined' || nodeList === null) { + if (!nodeList) { return [] } @@ -131,7 +131,7 @@ const Util = { }, isVisible(element) { - if (typeof element === 'undefined' || element === null) { + if (!element) { return false }