rooty/Bootstrap
0
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2025-02-07 04:54:24 +01:00
Code Issues Actions Packages Releases Activity

fix tooltip hide method when already hidden (#31115)

Browse Source 
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
This commit is contained in:
Hiws 2020-09-24 13:55:38 +02:00 committed by GitHub
parent a690a67c7c
commit 43b4252a34
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/src/tooltip.js
View File

@ -331,6 +331,10 @@ class Tooltip {
} }
hide() { hide() {
if (!this._popper) {
return
}
const tip = this.getTipElement() const tip = this.getTipElement()
const complete = () => { const complete = () => {
if (this._hoverState !== HOVER_STATE_SHOW && tip.parentNode) { if (this._hoverState !== HOVER_STATE_SHOW && tip.parentNode) {

14
js/tests/unit/tooltip.spec.js
View File

@ -717,6 +717,20 @@ describe('Tooltip', () => {
tooltip.show() tooltip.show()
}) })
it('should not throw error running hide if popper hasn\'t been shown', () => {
fixtureEl.innerHTML = '<div></div>'
const div = fixtureEl.querySelector('div')
const tooltip = new Tooltip(div)
try {
tooltip.hide()
expect().nothing()
} catch {
throw new Error('should not throw error')
}
})
}) })
describe('update', () => { describe('update', () => {