diff --git a/docs/assets/bootstrap.zip b/docs/assets/bootstrap.zip
index c474e5f0c9..04562df6f9 100644
Binary files a/docs/assets/bootstrap.zip and b/docs/assets/bootstrap.zip differ
diff --git a/docs/assets/js/bootstrap-modal.js b/docs/assets/js/bootstrap-modal.js
index ba64368b2d..180f0b64d9 100644
--- a/docs/assets/js/bootstrap-modal.js
+++ b/docs/assets/js/bootstrap-modal.js
@@ -26,7 +26,7 @@
* ====================== */
var Modal = function ( content, options ) {
- this.options = $.extend({}, $.fn.modal.defaults, options)
+ this.options = options
this.$element = $(content)
.delegate('[data-dismiss="modal"]', 'click.dismiss.modal', $.proxy(this.hide, this))
}
@@ -177,16 +177,17 @@
return this.each(function () {
var $this = $(this)
, data = $this.data('modal')
- , options = typeof option == 'object' && option
+ , options = $.extend({}, $.fn.modal.defaults, typeof option == 'object' && option)
if (!data) $this.data('modal', (data = new Modal(this, options)))
if (typeof option == 'string') data[option]()
- else data.show()
+ else if (options.show) data.show()
})
}
$.fn.modal.defaults = {
backdrop: true
, keyboard: true
+ , show: true
}
$.fn.modal.Constructor = Modal
diff --git a/docs/javascript.html b/docs/javascript.html
index b6abe80eaa..02467051d1 100644
--- a/docs/javascript.html
+++ b/docs/javascript.html
@@ -273,6 +273,12 @@
true |
Closes the modal when escape key is pressed |
+
+ show |
+ boolean |
+ true |
+ Shows the modal when initialized. |
+
Markup
diff --git a/docs/templates/pages/javascript.mustache b/docs/templates/pages/javascript.mustache
index 0064612908..9658190364 100644
--- a/docs/templates/pages/javascript.mustache
+++ b/docs/templates/pages/javascript.mustache
@@ -197,6 +197,12 @@
{{_i}}true{{/i}} |
{{_i}}Closes the modal when escape key is pressed{{/i}} |
+
+ {{_i}}show{{/i}} |
+ {{_i}}boolean{{/i}} |
+ {{_i}}true{{/i}} |
+ {{_i}}Shows the modal when initialized.{{/i}} |
+
{{_i}}Markup{{/i}}
diff --git a/js/README.md b/js/README.md
index b58fa1d407..3aa09c960f 100644
--- a/js/README.md
+++ b/js/README.md
@@ -37,7 +37,7 @@ All methods should accept an optional options object, a string which targets a p
Options should be sparse and add universal value. We should pick the right defaults.
-All plugins should have a default object which can be modified to effect all instance's default options. The defaults object should be available via `$.fn.plugin.defaults`.
+All plugins should have a default object which can be modified to affect all instances' default options. The defaults object should be available via `$.fn.plugin.defaults`.
$.fn.modal.defaults = { … }
@@ -64,7 +64,7 @@ All events should have an infinitive and past participle form. The infinitive is
### CONSTRUCTORS
-Each plugin should expose it's raw constructor on a `Constructor` property -- accessed in the following way:
+Each plugin should expose its raw constructor on a `Constructor` property -- accessed in the following way:
$.fn.popover.Constructor
diff --git a/js/bootstrap-modal.js b/js/bootstrap-modal.js
index ba64368b2d..180f0b64d9 100644
--- a/js/bootstrap-modal.js
+++ b/js/bootstrap-modal.js
@@ -26,7 +26,7 @@
* ====================== */
var Modal = function ( content, options ) {
- this.options = $.extend({}, $.fn.modal.defaults, options)
+ this.options = options
this.$element = $(content)
.delegate('[data-dismiss="modal"]', 'click.dismiss.modal', $.proxy(this.hide, this))
}
@@ -177,16 +177,17 @@
return this.each(function () {
var $this = $(this)
, data = $this.data('modal')
- , options = typeof option == 'object' && option
+ , options = $.extend({}, $.fn.modal.defaults, typeof option == 'object' && option)
if (!data) $this.data('modal', (data = new Modal(this, options)))
if (typeof option == 'string') data[option]()
- else data.show()
+ else if (options.show) data.show()
})
}
$.fn.modal.defaults = {
backdrop: true
, keyboard: true
+ , show: true
}
$.fn.modal.Constructor = Modal
diff --git a/js/tests/unit/bootstrap-alert.js b/js/tests/unit/bootstrap-alert.js
index f961345c37..e607f43402 100644
--- a/js/tests/unit/bootstrap-alert.js
+++ b/js/tests/unit/bootstrap-alert.js
@@ -13,7 +13,7 @@ $(function () {
test("should fade element out on clicking .close", function () {
var alertHTML = ''
+ '
×'
- + '
Holy guacamole! Best check yo self, you're not looking too good.
'
+ + '
Holy guacamole! Best check yo self, you\'re not looking too good.
'
+ '
'
, alert = $(alertHTML).alert()
@@ -27,7 +27,7 @@ $(function () {
var alertHTML = ''
+ '
×'
- + '
Holy guacamole! Best check yo self, you're not looking too good.
'
+ + '
Holy guacamole! Best check yo self, you\'re not looking too good.
'
+ '
'
, alert = $(alertHTML).appendTo('#qunit-fixture').alert()