rooty/Bootstrap
0
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2025-02-21 18:54:30 +01:00
Code Issues Actions Packages Releases Activity

Fix Util.reflow function and add documentation (#34543)

Browse Source 
* add documentation to reflow function

* refactor to void as it should be

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
This commit is contained in:
GeoSot 2021-07-20 17:20:43 +03:00 committed by GitHub
parent 365b9e5af0
commit 5541179b38
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
js/src/util/index.js
View File

@ -188,7 +188,18 @@ const findShadowRoot = element => {
const noop = () => {} const noop = () => {}
const reflow = element => element.offsetHeight /**
* Trick to restart an element's animation
*
* @param {HTMLElement} element
* @return void
*
* @see https://www.charistheo.io/blog/2021/02/restart-a-css-animation-with-javascript/#restarting-a-css-animation
*/
const reflow = element => {
// eslint-disable-next-line no-unused-expressions
element.offsetHeight
}
const getjQuery = () => { const getjQuery = () => {
const { jQuery } = window const { jQuery } = window

5
js/tests/unit/util/index.spec.js
View File

@ -543,8 +543,9 @@ describe('Util', () => {
fixtureEl.innerHTML = '<div></div>' fixtureEl.innerHTML = '<div></div>'
const div = fixtureEl.querySelector('div') const div = fixtureEl.querySelector('div')
const spy = spyOnProperty(div, 'offsetHeight')
expect(Util.reflow(div)).toEqual(0) Util.reflow(div)
expect(spy).toHaveBeenCalled()
}) })
}) })