From ac3fbdad3626c4c43303c168f3109c09da688b8d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Corn=C3=A9=20Dorrestijn?= Date: Fri, 21 Aug 2015 22:21:20 +0200 Subject: [PATCH 1/2] Removed mixin from focus ouline box-shadow fixes #17066 --- scss/_custom-forms.scss | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scss/_custom-forms.scss b/scss/_custom-forms.scss index ec211acaa8..2326e01ca0 100644 --- a/scss/_custom-forms.scss +++ b/scss/_custom-forms.scss @@ -19,16 +19,16 @@ z-index: -1; // Put the input behind the label so it doesn't overlay text opacity: 0; - &:focus ~ .c-indicator { - @include box-shadow(0 0 0 .075rem #fff, 0 0 0 .2rem #0074d9); - } - &:checked ~ .c-indicator { color: #fff; background-color: #0074d9; @include box-shadow(none); } + &:focus ~ .c-indicator { + box-shadow: 0 0 0 .075rem #fff, 0 0 0 .2rem #0074d9; + } + &:active ~ .c-indicator { color: #fff; background-color: #84c6ff; From c49503165a301e53583dcb74003e2894d966269b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Corn=C3=A9=20Dorrestijn?= Date: Sat, 22 Aug 2015 01:04:16 +0200 Subject: [PATCH 2/2] Added comment explaining why there is no mixin here --- scss/_custom-forms.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/scss/_custom-forms.scss b/scss/_custom-forms.scss index 2326e01ca0..bc36013e9d 100644 --- a/scss/_custom-forms.scss +++ b/scss/_custom-forms.scss @@ -26,6 +26,7 @@ } &:focus ~ .c-indicator { + // the mixin is not used here to make sure there is feedback box-shadow: 0 0 0 .075rem #fff, 0 0 0 .2rem #0074d9; }