From 15c9c3aef7f047c9cce45fd33ada799e99fbd390 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 22 Dec 2014 16:54:50 -0800 Subject: [PATCH 1/3] add more refs to browser-related bugs in Less comments --- less/carousel.less | 1 + less/close.less | 1 + less/forms.less | 2 +- less/theme.less | 4 ++-- 4 files changed, 5 insertions(+), 3 deletions(-) diff --git a/less/carousel.less b/less/carousel.less index a28e397a55..4bbe946d3a 100644 --- a/less/carousel.less +++ b/less/carousel.less @@ -196,6 +196,7 @@ // Internet Explorer 8-9 does not support clicks on elements without a set // `background-color`. We cannot use `filter` since that's not viewed as a // background color by the browser. Thus, a hack is needed. + // See https://developer.mozilla.org/en-US/docs/Web/Events/click#Internet_Explorer // // For IE8, we set solid black as it doesn't support `rgba()`. For IE9, we // set alpha transparency for the best results possible. diff --git a/less/close.less b/less/close.less index 9b4e74f2b8..6d5bfe087a 100644 --- a/less/close.less +++ b/less/close.less @@ -23,6 +23,7 @@ // Additional properties for button version // iOS requires the button element instead of an anchor tag. // If you want the anchor version, it requires `href="#"`. + // See https://developer.mozilla.org/en-US/docs/Web/Events/click#Safari_Mobile button& { padding: 0; cursor: pointer; diff --git a/less/forms.less b/less/forms.less index f37d1c8f8f..d1e29b1183 100644 --- a/less/forms.less +++ b/less/forms.less @@ -143,7 +143,7 @@ output { fieldset[disabled] & { cursor: @cursor-disabled; background-color: @input-bg-disabled; - opacity: 1; // iOS fix for unreadable disabled content + opacity: 1; // iOS fix for unreadable disabled content; see https://github.com/twbs/bootstrap/issues/11655 } // Reset height for `textarea`s diff --git a/less/theme.less b/less/theme.less index a15d16ecd2..3673accc09 100644 --- a/less/theme.less +++ b/less/theme.less @@ -36,7 +36,7 @@ // Mixin for generating new styles .btn-styles(@btn-color: #555) { #gradient > .vertical(@start-color: @btn-color; @end-color: darken(@btn-color, 12%)); - .reset-filter(); // Disable gradients for IE9 because filter bleeds through rounded corners + .reset-filter(); // Disable gradients for IE9 because filter bleeds through rounded corners; see https://github.com/twbs/bootstrap/issues/10620 background-repeat: repeat-x; border-color: darken(@btn-color, 14%); @@ -130,7 +130,7 @@ // Inverted navbar .navbar-inverse { #gradient > .vertical(@start-color: lighten(@navbar-inverse-bg, 10%); @end-color: @navbar-inverse-bg); - .reset-filter(); // Remove gradient in IE<10 to fix bug where dropdowns don't get triggered + .reset-filter(); // Remove gradient in IE<10 to fix bug where dropdowns don't get triggered; see https://github.com/twbs/bootstrap/issues/10257 .navbar-nav > .open > a, .navbar-nav > .active > a { From d84f726da4f55434de853202961310d153f35739 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 22 Dec 2014 17:02:29 -0800 Subject: [PATCH 2/3] IE11 & current Firefox are still affected. Refs #11623 --- less/tables.less | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/less/tables.less b/less/tables.less index ba24498a39..3c801aedbb 100644 --- a/less/tables.less +++ b/less/tables.less @@ -133,7 +133,7 @@ th { // Reset default table behavior table col[class*="col-"] { - position: static; // Prevent border hiding in Firefox and IE9/10 (see https://github.com/twbs/bootstrap/issues/11623) + position: static; // Prevent border hiding in Firefox and IE9-11 (see https://github.com/twbs/bootstrap/issues/11623) float: none; display: table-column; } @@ -141,7 +141,7 @@ table { td, th { &[class*="col-"] { - position: static; // Prevent border hiding in Firefox and IE9/10 (see https://github.com/twbs/bootstrap/issues/11623) + position: static; // Prevent border hiding in Firefox and IE9-11 (see https://github.com/twbs/bootstrap/issues/11623) float: none; display: table-cell; } From 75ec7393ec2940cb1f015dc2d002328833ad3ef8 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 22 Dec 2014 17:03:45 -0800 Subject: [PATCH 3/3] Add summary of #11526 to explanatory Less comment [skip sauce] [skip validator] --- less/mixins/vendor-prefixes.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/less/mixins/vendor-prefixes.less b/less/mixins/vendor-prefixes.less index 31f8e2f7ab..afd3331c31 100644 --- a/less/mixins/vendor-prefixes.less +++ b/less/mixins/vendor-prefixes.less @@ -102,7 +102,7 @@ // Firefox &::-moz-placeholder { color: @color; - opacity: 1; // See https://github.com/twbs/bootstrap/pull/11526 + opacity: 1; // Override Firefox's unusual default opacity; see https://github.com/twbs/bootstrap/pull/11526 } &:-ms-input-placeholder { color: @color; } // Internet Explorer 10+ &::-webkit-input-placeholder { color: @color; } // Safari and Chrome