mirror of
https://github.com/twbs/bootstrap.git
synced 2025-02-18 15:54:26 +01:00
Merge pull request #4241 from shama/issue-guidelines
Use ref instead of label when checking branches in issue-guidelines
This commit is contained in:
commit
6905dbe98d
@ -24,11 +24,11 @@ module.exports = {
|
||||
'pull-requests': {
|
||||
|
||||
'should always be made against -wip branches': function (pull) {
|
||||
assert.ok(/\-wip$/.test(pull.base.label))
|
||||
assert.ok(/\-wip$/.test(pull.base.ref))
|
||||
},
|
||||
|
||||
'should always be made from feature branches': function (pull) {
|
||||
assert.ok(pull.head.label != 'master')
|
||||
assert.notEqual(pull.head.ref, 'master')
|
||||
},
|
||||
|
||||
'should always include a unit test if changing js files': function (pull) {
|
||||
@ -36,7 +36,7 @@ module.exports = {
|
||||
var hasTests = false
|
||||
|
||||
pull.files.forEach(function (file) {
|
||||
if (/^js\/[^./]+.js/.test(file.filename)) hasJS = true
|
||||
if (/^js\/[^./]+.js/.test(file.filename)) hasJS = true
|
||||
if (/^js\/tests\/unit\/[^.]+.js/.test(file.filename)) hasTests = true
|
||||
})
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user