rooty/Bootstrap
0
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2025-02-17 14:54:30 +01:00
Code Issues Actions Packages Releases Activity

v4: Improve accessible name of version dropdown in docs navbar (#36504)

Browse Source 
- add `sr-only` "Bootstrap", which will be part of the accessible name
- extra `sr-only` text to give some context - that the dropdown is about switching versions
- remove the redundant id/aria-labelledby for the dropdown
- change the control from `<a>` to `<button>`
This commit is contained in:
Patrick H. Lauke 2022-06-05 10:33:18 +01:00 committed by GitHub
parent d136302a57
commit 6fd203060b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
site/layouts/partials/docs-navbar.html
View File

@ -31,10 +31,10 @@
<ul class="navbar-nav ml-md-auto"> <ul class="navbar-nav ml-md-auto">
<li class="nav-item dropdown"> <li class="nav-item dropdown">
<a class="nav-item nav-link dropdown-toggle mr-md-2" href="#" id="bd-versions" data-toggle="dropdown" aria-expanded="false"> <button class="btn nav-link dropdown-toggle mr-md-2" data-toggle="dropdown" aria-expanded="false">
v{{ .Site.Params.docs_version }} <span class="sr-only">Bootstrap&nbsp;</span> v{{ .Site.Params.docs_version }} <span class="sr-only">(switch to other versions)</span>
</a> </button>
<div class="dropdown-menu dropdown-menu-md-right" aria-labelledby="bd-versions"> <div class="dropdown-menu dropdown-menu-md-right">
<a class="dropdown-item active" href="/docs/{{ .Site.Params.docs_version }}/">Latest ({{ .Site.Params.docs_version }}.x)</a> <a class="dropdown-item active" href="/docs/{{ .Site.Params.docs_version }}/">Latest ({{ .Site.Params.docs_version }}.x)</a>
<div class="dropdown-divider"></div> <div class="dropdown-divider"></div>
<a class="dropdown-item" href="https://getbootstrap.com/docs/5.1/">5.1.x</a> <a class="dropdown-item" href="https://getbootstrap.com/docs/5.1/">5.1.x</a>