From 8a78bc065f866763607f104907b7a2ac9fa6ceec Mon Sep 17 00:00:00 2001 From: Heinrich Fenkart Date: Sun, 16 Feb 2014 20:06:31 +0100 Subject: [PATCH] Remove event aliases from JavaScript Makes life for people with custom jQuery builds excluding event aliases much easier. --- dist/js/bootstrap.js | 16 ++++++++-------- js/dropdown.js | 8 ++++---- js/modal.js | 8 ++++---- 3 files changed, 16 insertions(+), 16 deletions(-) diff --git a/dist/js/bootstrap.js b/dist/js/bootstrap.js index 8ae571b6da..08463f4a38 100644 --- a/dist/js/bootstrap.js +++ b/dist/js/bootstrap.js @@ -675,7 +675,7 @@ if (typeof jQuery === 'undefined') { throw new Error('Bootstrap\'s JavaScript re .toggleClass('open') .trigger('shown.bs.dropdown', relatedTarget) - $this.focus() + $this.trigger('focus') } return false @@ -695,8 +695,8 @@ if (typeof jQuery === 'undefined') { throw new Error('Bootstrap\'s JavaScript re var isActive = $parent.hasClass('open') if (!isActive || (isActive && e.keyCode == 27)) { - if (e.which == 27) $parent.find(toggle).focus() - return $this.click() + if (e.which == 27) $parent.find(toggle).trigger('focus') + return $this.trigger('click') } var desc = ' li:not(.divider):visible a' @@ -710,7 +710,7 @@ if (typeof jQuery === 'undefined') { throw new Error('Bootstrap\'s JavaScript re if (e.keyCode == 40 && index < $items.length - 1) index++ // down if (!~index) index = 0 - $items.eq(index).focus() + $items.eq(index).trigger('focus') } function clearMenus(e) { @@ -857,10 +857,10 @@ if (typeof jQuery === 'undefined') { throw new Error('Bootstrap\'s JavaScript re transition ? that.$element.find('.modal-dialog') // wait for modal to slide in .one($.support.transition.end, function () { - that.$element.focus().trigger(e) + that.$element.trigger('focus').trigger(e) }) .emulateTransitionEnd(300) : - that.$element.focus().trigger(e) + that.$element.trigger('focus').trigger(e) }) } @@ -896,7 +896,7 @@ if (typeof jQuery === 'undefined') { throw new Error('Bootstrap\'s JavaScript re .off('focusin.bs.modal') // guard against infinite focus loop .on('focusin.bs.modal', $.proxy(function (e) { if (this.$element[0] !== e.target && !this.$element.has(e.target).length) { - this.$element.focus() + this.$element.trigger('focus') } }, this)) } @@ -1011,7 +1011,7 @@ if (typeof jQuery === 'undefined') { throw new Error('Bootstrap\'s JavaScript re $target .modal(option, this) .one('hide', function () { - $this.is(':visible') && $this.focus() + $this.is(':visible') && $this.trigger('focus') }) }) diff --git a/js/dropdown.js b/js/dropdown.js index 43d7ae3ea4..6e206a0d16 100644 --- a/js/dropdown.js +++ b/js/dropdown.js @@ -44,7 +44,7 @@ .toggleClass('open') .trigger('shown.bs.dropdown', relatedTarget) - $this.focus() + $this.trigger('focus') } return false @@ -64,8 +64,8 @@ var isActive = $parent.hasClass('open') if (!isActive || (isActive && e.keyCode == 27)) { - if (e.which == 27) $parent.find(toggle).focus() - return $this.click() + if (e.which == 27) $parent.find(toggle).trigger('focus') + return $this.trigger('click') } var desc = ' li:not(.divider):visible a' @@ -79,7 +79,7 @@ if (e.keyCode == 40 && index < $items.length - 1) index++ // down if (!~index) index = 0 - $items.eq(index).focus() + $items.eq(index).trigger('focus') } function clearMenus(e) { diff --git a/js/modal.js b/js/modal.js index 20ff270466..f6dc477b10 100644 --- a/js/modal.js +++ b/js/modal.js @@ -78,10 +78,10 @@ transition ? that.$element.find('.modal-dialog') // wait for modal to slide in .one($.support.transition.end, function () { - that.$element.focus().trigger(e) + that.$element.trigger('focus').trigger(e) }) .emulateTransitionEnd(300) : - that.$element.focus().trigger(e) + that.$element.trigger('focus').trigger(e) }) } @@ -117,7 +117,7 @@ .off('focusin.bs.modal') // guard against infinite focus loop .on('focusin.bs.modal', $.proxy(function (e) { if (this.$element[0] !== e.target && !this.$element.has(e.target).length) { - this.$element.focus() + this.$element.trigger('focus') } }, this)) } @@ -232,7 +232,7 @@ $target .modal(option, this) .one('hide', function () { - $this.is(':visible') && $this.focus() + $this.is(':visible') && $this.trigger('focus') }) })