From 8340d664ce5875c15393017e4f3b06c458215469 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Thu, 3 Jul 2014 11:45:49 -0700 Subject: [PATCH 1/3] Mark the `remote` option of the Modal plugin as deprecated. Follow-up to https://github.com/twbs/bootstrap/issues/13087#issuecomment-46563760 Closes #13087 as WONTFIX. Closes #13597 as WONTFIX. --- docs/_includes/js/modal.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/_includes/js/modal.html b/docs/_includes/js/modal.html index 9b8a709185..0ce58415a0 100644 --- a/docs/_includes/js/modal.html +++ b/docs/_includes/js/modal.html @@ -259,7 +259,7 @@ remote path false -

If a remote URL is provided, content will be loaded one time via jQuery's load method and injected into the .modal-content div. If you're using the data-api, you may alternatively use the href attribute to specify the remote source. An example of this is shown below:

+

This option is deprecated since v3.2.1 and will be removed in v4.

If a remote URL is provided, content will be loaded one time via jQuery's load method and injected into the .modal-content div. If you're using the data-api, you may alternatively use the href attribute to specify the remote source. An example of this is shown below:

{% highlight html %} Click me {% endhighlight %} From 24e51590b78d60213042df2d454ee82b40745591 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Thu, 3 Jul 2014 11:49:32 -0700 Subject: [PATCH 2/3] modal docs formatting tweak [skip sauce] --- docs/_includes/js/modal.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/_includes/js/modal.html b/docs/_includes/js/modal.html index 0ce58415a0..f8ad8e33e8 100644 --- a/docs/_includes/js/modal.html +++ b/docs/_includes/js/modal.html @@ -320,7 +320,7 @@ $('#myModal').modal({ loaded.bs.modal - This event is fired when the modal has loaded content using the remote option. + This event is fired when the modal has loaded content using the remote option. From 7f4af4aeeac5e93dcb69b5c820e8e791077cc787 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Sat, 5 Jul 2014 23:42:30 -0700 Subject: [PATCH 3/3] `remote` modal docs: mention jQuery.load and other JS options as alternatives [skip sauce] --- docs/_includes/js/modal.html | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/_includes/js/modal.html b/docs/_includes/js/modal.html index f8ad8e33e8..d5b1aee849 100644 --- a/docs/_includes/js/modal.html +++ b/docs/_includes/js/modal.html @@ -259,7 +259,9 @@ remote path false -

This option is deprecated since v3.2.1 and will be removed in v4.

If a remote URL is provided, content will be loaded one time via jQuery's load method and injected into the .modal-content div. If you're using the data-api, you may alternatively use the href attribute to specify the remote source. An example of this is shown below:

+ +

This option is deprecated since v3.2.1 and will be removed in v4. We recommend instead using client-side templating or a data binding framework, or calling jQuery.load yourself.

+

If a remote URL is provided, content will be loaded one time via jQuery's load method and injected into the .modal-content div. If you're using the data-api, you may alternatively use the href attribute to specify the remote source. An example of this is shown below:

{% highlight html %} Click me {% endhighlight %}