From 7c19fee3f1f3a371445981cf7e88a3af92f3b602 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 23 Feb 2015 21:55:07 -0800 Subject: [PATCH] JS unit tests: use modern QUnit assert object everywhere --- js/tests/unit/affix.js | 24 +-- js/tests/unit/alert.js | 28 ++-- js/tests/unit/button.js | 106 ++++++------- js/tests/unit/carousel.js | 138 ++++++++--------- js/tests/unit/collapse.js | 74 +++++----- js/tests/unit/dropdown.js | 66 ++++----- js/tests/unit/modal.js | 76 +++++----- js/tests/unit/popover.js | 108 +++++++------- js/tests/unit/scrollspy.js | 30 ++-- js/tests/unit/tab.js | 64 ++++---- js/tests/unit/tooltip.js | 294 ++++++++++++++++++------------------- 11 files changed, 504 insertions(+), 504 deletions(-) diff --git a/js/tests/unit/affix.js b/js/tests/unit/affix.js index 040fe98030..480e1adc1e 100644 --- a/js/tests/unit/affix.js +++ b/js/tests/unit/affix.js @@ -3,8 +3,8 @@ $(function () { module('affix plugin') - test('should be defined on jquery object', function () { - ok($(document.body).affix, 'affix method is defined') + test('should be defined on jquery object', function (assert) { + assert.ok($(document.body).affix, 'affix method is defined') }) module('affix', { @@ -18,21 +18,21 @@ $(function () { } }) - test('should provide no conflict', function () { - strictEqual($.fn.affix, undefined, 'affix was set back to undefined (org value)') + test('should provide no conflict', function (assert) { + assert.strictEqual($.fn.affix, undefined, 'affix was set back to undefined (org value)') }) - test('should return jquery collection containing the element', function () { + test('should return jquery collection containing the element', function (assert) { var $el = $('
') var $affix = $el.bootstrapAffix() - ok($affix instanceof $, 'returns jquery collection') - strictEqual($affix[0], $el[0], 'collection contains element') + assert.ok($affix instanceof $, 'returns jquery collection') + assert.strictEqual($affix[0], $el[0], 'collection contains element') }) - test('should exit early if element is not visible', function () { + test('should exit early if element is not visible', function (assert) { var $affix = $('
').bootstrapAffix() $affix.data('bs.affix').checkPosition() - ok(!$affix.hasClass('affix'), 'affix class was not added') + assert.ok(!$affix.hasClass('affix'), 'affix class was not added') }) test('should trigger affixed event after affix', function (assert) { @@ -53,9 +53,9 @@ $(function () { $('#affixTarget') .on('affix.bs.affix', function () { - ok(true, 'affix event fired') + assert.ok(true, 'affix event fired') }).on('affixed.bs.affix', function () { - ok(true, 'affixed event fired') + assert.ok(true, 'affixed event fired') $('#affixTarget, #affixAfter').remove() done() }) @@ -85,7 +85,7 @@ $(function () { offset: { top: 120, bottom: 0 } }) .on('affixed-top.bs.affix', function () { - ok($('#affixTopTarget').hasClass('affix-top'), 'affix-top class applied') + assert.ok($('#affixTopTarget').hasClass('affix-top'), 'affix-top class applied') $('#padding-offset').remove() done() }) diff --git a/js/tests/unit/alert.js b/js/tests/unit/alert.js index 140a148385..68e694ca29 100644 --- a/js/tests/unit/alert.js +++ b/js/tests/unit/alert.js @@ -3,8 +3,8 @@ $(function () { module('alert plugin') - test('should be defined on jquery object', function () { - ok($(document.body).alert, 'alert method is defined') + test('should be defined on jquery object', function (assert) { + assert.ok($(document.body).alert, 'alert method is defined') }) module('alert', { @@ -18,18 +18,18 @@ $(function () { } }) - test('should provide no conflict', function () { - strictEqual($.fn.alert, undefined, 'alert was set back to undefined (org value)') + test('should provide no conflict', function (assert) { + assert.strictEqual($.fn.alert, undefined, 'alert was set back to undefined (org value)') }) - test('should return jquery collection containing the element', function () { + test('should return jquery collection containing the element', function (assert) { var $el = $('
') var $alert = $el.bootstrapAlert() - ok($alert instanceof $, 'returns jquery collection') - strictEqual($alert[0], $el[0], 'collection contains element') + assert.ok($alert instanceof $, 'returns jquery collection') + assert.strictEqual($alert[0], $el[0], 'collection contains element') }) - test('should fade element out on clicking .close', function () { + test('should fade element out on clicking .close', function (assert) { var alertHTML = '
' + '×' + '

Holy guacamole! Best check yo self, you\'re not looking too good.

' @@ -38,21 +38,21 @@ $(function () { $alert.find('.close').click() - equal($alert.hasClass('in'), false, 'remove .in class on .close click') + assert.equal($alert.hasClass('in'), false, 'remove .in class on .close click') }) - test('should remove element when clicking .close', function () { + test('should remove element when clicking .close', function (assert) { var alertHTML = '
' + '×' + '

Holy guacamole! Best check yo self, you\'re not looking too good.

' + '
' var $alert = $(alertHTML).appendTo('#qunit-fixture').bootstrapAlert() - notEqual($('#qunit-fixture').find('.alert').length, 0, 'element added to dom') + assert.notEqual($('#qunit-fixture').find('.alert').length, 0, 'element added to dom') $alert.find('.close').click() - equal($('#qunit-fixture').find('.alert').length, 0, 'element removed from dom') + assert.equal($('#qunit-fixture').find('.alert').length, 0, 'element removed from dom') }) test('should not fire closed when close is prevented', function (assert) { @@ -60,11 +60,11 @@ $(function () { $('
') .on('close.bs.alert', function (e) { e.preventDefault() - ok(true, 'close event fired') + assert.ok(true, 'close event fired') done() }) .on('closed.bs.alert', function () { - ok(false, 'closed event fired') + assert.ok(false, 'closed event fired') }) .bootstrapAlert('close') }) diff --git a/js/tests/unit/button.js b/js/tests/unit/button.js index cb51d40b95..4324d0b578 100644 --- a/js/tests/unit/button.js +++ b/js/tests/unit/button.js @@ -3,8 +3,8 @@ $(function () { module('button plugin') - test('should be defined on jquery object', function () { - ok($(document.body).button, 'button method is defined') + test('should be defined on jquery object', function (assert) { + assert.ok($(document.body).button, 'button method is defined') }) module('button', { @@ -18,46 +18,46 @@ $(function () { } }) - test('should provide no conflict', function () { - strictEqual($.fn.button, undefined, 'button was set back to undefined (org value)') + test('should provide no conflict', function (assert) { + assert.strictEqual($.fn.button, undefined, 'button was set back to undefined (org value)') }) - test('should return jquery collection containing the element', function () { + test('should return jquery collection containing the element', function (assert) { var $el = $('
') var $button = $el.bootstrapButton() - ok($button instanceof $, 'returns jquery collection') - strictEqual($button[0], $el[0], 'collection contains element') + assert.ok($button instanceof $, 'returns jquery collection') + assert.strictEqual($button[0], $el[0], 'collection contains element') }) test('should return set state to loading', function (assert) { var $btn = $('') - equal($btn.html(), 'mdo', 'btn text equals mdo') + assert.equal($btn.html(), 'mdo', 'btn text equals mdo') $btn.bootstrapButton('loading') var done = assert.async() setTimeout(function () { - equal($btn.html(), 'fat', 'btn text equals fat') - ok($btn[0].hasAttribute('disabled'), 'btn is disabled') - ok($btn.hasClass('disabled'), 'btn has disabled class') + assert.equal($btn.html(), 'fat', 'btn text equals fat') + assert.ok($btn[0].hasAttribute('disabled'), 'btn is disabled') + assert.ok($btn.hasClass('disabled'), 'btn has disabled class') done() }, 0) }) test('should return reset state', function (assert) { var $btn = $('') - equal($btn.html(), 'mdo', 'btn text equals mdo') + assert.equal($btn.html(), 'mdo', 'btn text equals mdo') $btn.bootstrapButton('loading') var doneOne = assert.async() setTimeout(function () { - equal($btn.html(), 'fat', 'btn text equals fat') - ok($btn[0].hasAttribute('disabled'), 'btn is disabled') - ok($btn.hasClass('disabled'), 'btn has disabled class') + assert.equal($btn.html(), 'fat', 'btn text equals fat') + assert.ok($btn[0].hasAttribute('disabled'), 'btn is disabled') + assert.ok($btn.hasClass('disabled'), 'btn has disabled class') doneOne() var doneTwo = assert.async() $btn.bootstrapButton('reset') setTimeout(function () { - equal($btn.html(), 'mdo', 'btn text equals mdo') - ok(!$btn[0].hasAttribute('disabled'), 'btn is not disabled') - ok(!$btn.hasClass('disabled'), 'btn does not have disabled class') + assert.equal($btn.html(), 'mdo', 'btn text equals mdo') + assert.ok(!$btn[0].hasAttribute('disabled'), 'btn is not disabled') + assert.ok(!$btn.hasClass('disabled'), 'btn does not have disabled class') doneTwo() }, 0) }, 0) @@ -65,74 +65,74 @@ $(function () { test('should work with an empty string as reset state', function (assert) { var $btn = $('') - ok(!$btn.hasClass('active'), 'btn does not have active class') + assert.ok(!$btn.hasClass('active'), 'btn does not have active class') $btn.bootstrapButton('toggle') - ok($btn.hasClass('active'), 'btn has class active') + assert.ok($btn.hasClass('active'), 'btn has class active') }) - test('should toggle active when btn children are clicked', function () { + test('should toggle active when btn children are clicked', function (assert) { var $btn = $('') var $inner = $('') $btn .append($inner) .appendTo('#qunit-fixture') - ok(!$btn.hasClass('active'), 'btn does not have active class') + assert.ok(!$btn.hasClass('active'), 'btn does not have active class') $inner.click() - ok($btn.hasClass('active'), 'btn has class active') + assert.ok($btn.hasClass('active'), 'btn has class active') }) - test('should toggle aria-pressed', function () { + test('should toggle aria-pressed', function (assert) { var $btn = $('') - equal($btn.attr('aria-pressed'), 'false', 'btn aria-pressed state is false') + assert.equal($btn.attr('aria-pressed'), 'false', 'btn aria-pressed state is false') $btn.bootstrapButton('toggle') - equal($btn.attr('aria-pressed'), 'true', 'btn aria-pressed state is true') + assert.equal($btn.attr('aria-pressed'), 'true', 'btn aria-pressed state is true') }) - test('should toggle aria-pressed when btn children are clicked', function () { + test('should toggle aria-pressed when btn children are clicked', function (assert) { var $btn = $('') var $inner = $('') $btn .append($inner) .appendTo('#qunit-fixture') - equal($btn.attr('aria-pressed'), 'false', 'btn aria-pressed state is false') + assert.equal($btn.attr('aria-pressed'), 'false', 'btn aria-pressed state is false') $inner.click() - equal($btn.attr('aria-pressed'), 'true', 'btn aria-pressed state is true') + assert.equal($btn.attr('aria-pressed'), 'true', 'btn aria-pressed state is true') }) - test('should toggle active when btn children are clicked within btn-group', function () { + test('should toggle active when btn children are clicked within btn-group', function (assert) { var $btngroup = $('
') var $btn = $('') var $inner = $('') $btngroup .append($btn.append($inner)) .appendTo('#qunit-fixture') - ok(!$btn.hasClass('active'), 'btn does not have active class') + assert.ok(!$btn.hasClass('active'), 'btn does not have active class') $inner.click() - ok($btn.hasClass('active'), 'btn has class active') + assert.ok($btn.hasClass('active'), 'btn has class active') }) - test('should check for closest matching toggle', function () { + test('should check for closest matching toggle', function (assert) { var groupHTML = '
' + '