From 032a5ab72f8a7f0e786cb1d796ef895395b86e1f Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 27 Oct 2014 15:00:30 -0700 Subject: [PATCH 1/4] add clearfix divs to customizer input rows --- docs/_includes/customizer-variables.html | 100 +++++++++++++++++++++++ docs/_jade/customizer-variables.jade | 4 +- 2 files changed, 103 insertions(+), 1 deletion(-) diff --git a/docs/_includes/customizer-variables.html b/docs/_includes/customizer-variables.html index 2c7eb69fc2..d489704091 100644 --- a/docs/_includes/customizer-variables.html +++ b/docs/_includes/customizer-variables.html @@ -15,6 +15,7 @@ +
@@ -27,6 +28,7 @@
+
@@ -39,6 +41,7 @@
+
@@ -66,6 +69,7 @@

Global textual link color.

+
@@ -93,6 +97,7 @@

Default monospace fonts for <code>, <kbd>, and <pre>.

+
@@ -105,6 +110,7 @@
+
@@ -117,6 +123,7 @@
+
@@ -129,6 +136,7 @@
+
@@ -143,6 +151,7 @@

Computed "line-height" (font-size * line-height) for use with margin, padding, etc.

+
@@ -156,6 +165,7 @@
+
@@ -195,6 +205,7 @@
+
@@ -207,6 +218,7 @@
+
@@ -219,6 +231,7 @@
+
@@ -231,6 +244,7 @@
+
@@ -245,6 +259,7 @@

Global background color for active items (e.g., navs or dropdowns).

+
@@ -274,6 +289,7 @@

Default background color used for all tables.

+
@@ -288,6 +304,7 @@
+
@@ -309,6 +326,7 @@
+
@@ -321,6 +339,7 @@
+
@@ -333,6 +352,7 @@
+
@@ -345,6 +365,7 @@
+
@@ -357,6 +378,7 @@
+
@@ -369,6 +391,7 @@
+
@@ -395,6 +418,7 @@

Text color for <input>s

+
@@ -410,6 +434,7 @@

Large .form-control border radius

+
@@ -425,6 +450,7 @@

Placeholder text color

+
@@ -440,6 +466,7 @@

Small .form-control height

+
@@ -453,6 +480,7 @@

Background color for textual input addons

+
@@ -477,6 +505,7 @@

Dropdown menu border-color for IE8.

+
@@ -492,6 +521,7 @@

Hover color for dropdown links.

+
@@ -507,6 +537,7 @@

Active dropdown menu item background color.

+
@@ -541,6 +572,7 @@

Deprecated @screen-phone as of v3.0.1

+
@@ -555,6 +587,7 @@

Deprecated @screen-tablet as of v3.0.1

+
@@ -569,6 +602,7 @@

Deprecated @screen-desktop as of v3.0.1

+
@@ -583,6 +617,7 @@

Deprecated @screen-lg-desktop as of v3.0.1

+
@@ -614,6 +649,7 @@

Point at which the navbar becomes uncollapsed.

+
@@ -636,6 +672,7 @@
+
@@ -665,6 +702,7 @@
+
@@ -677,6 +715,7 @@
+
@@ -689,6 +728,7 @@
+
@@ -701,6 +741,7 @@
+
@@ -713,6 +754,7 @@
+
@@ -725,6 +767,7 @@
+
@@ -737,6 +780,7 @@
+
@@ -749,6 +793,7 @@
+
@@ -761,6 +806,7 @@
+
@@ -773,6 +819,7 @@
+
@@ -785,6 +832,7 @@
+
@@ -797,6 +845,7 @@
+
@@ -821,6 +870,7 @@
+
@@ -840,6 +890,7 @@
+
@@ -852,6 +903,7 @@
+
@@ -886,6 +938,7 @@
+
@@ -898,6 +951,7 @@
+
@@ -910,6 +964,7 @@
+
@@ -937,6 +992,7 @@
+
@@ -949,6 +1005,7 @@
+
@@ -968,6 +1025,7 @@
+
@@ -992,6 +1050,7 @@
+
@@ -1004,6 +1063,7 @@
+
@@ -1016,6 +1076,7 @@
+
@@ -1046,6 +1107,7 @@

Tooltip background color

+
@@ -1078,6 +1140,7 @@

Popover border color

+
@@ -1093,6 +1156,7 @@

Popover arrow width

+
@@ -1108,6 +1172,7 @@

Popover outer arrow color

+
@@ -1131,6 +1196,7 @@

Success label background color

+
@@ -1146,6 +1212,7 @@

Danger label background color

+
@@ -1174,6 +1241,7 @@

Modal title line-height

+
@@ -1189,6 +1257,7 @@

Modal content border color for IE8

+
@@ -1204,6 +1273,7 @@

Modal header border color

+
@@ -1217,6 +1287,7 @@
+
@@ -1237,6 +1308,7 @@
+
@@ -1249,6 +1321,7 @@
+
@@ -1261,6 +1334,7 @@
+
@@ -1273,6 +1347,7 @@
+
@@ -1303,6 +1378,7 @@

Variable for setting rounded corners on progress bar.

+
@@ -1318,6 +1394,7 @@

Warning progress bar color

+
@@ -1346,6 +1423,7 @@

List group border radius

+
@@ -1361,6 +1439,7 @@

Background color of active list items

+
@@ -1376,6 +1455,7 @@

Text color of disabled list items

+
@@ -1390,6 +1470,7 @@
+
@@ -1413,6 +1494,7 @@
+
@@ -1426,6 +1508,7 @@

Border color for elements within panels

+
@@ -1438,6 +1521,7 @@
+
@@ -1450,6 +1534,7 @@
+
@@ -1462,6 +1547,7 @@
+
@@ -1474,6 +1560,7 @@
+
@@ -1486,6 +1573,7 @@
+
@@ -1498,6 +1586,7 @@
+
@@ -1520,6 +1609,7 @@

Thumbnail border color

+
@@ -1562,6 +1652,7 @@
+
@@ -1576,6 +1667,7 @@
+
@@ -1600,6 +1692,7 @@

Breadcrumb background color

+
@@ -1630,6 +1723,7 @@
+
@@ -1642,6 +1736,7 @@
+
@@ -1680,6 +1775,7 @@
+
@@ -1692,6 +1788,7 @@
+
@@ -1718,6 +1815,7 @@

Abbreviations and acronyms border color

+
@@ -1733,6 +1831,7 @@

Blockquote font size

+
@@ -1748,6 +1847,7 @@

Width of horizontal description list titles

+
diff --git a/docs/_jade/customizer-variables.jade b/docs/_jade/customizer-variables.jade index 3c74573be0..39d3f9f194 100644 --- a/docs/_jade/customizer-variables.jade +++ b/docs/_jade/customizer-variables.jade @@ -8,7 +8,9 @@ each section in sections if subsection.heading h3(id=subsection.id)= subsection.heading div.row - each variable in subsection.variables + each variable, index in subsection.variables + if index > 0 && index % 3 === 0 + div.clearfix div.bs-customizer-input label(for="input-" + variable.name)= variable.name input.form-control( From a43d4767ba7a1d8d313f9c418a378b6749dd6040 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 27 Oct 2014 15:02:21 -0700 Subject: [PATCH 2/4] .bs-customizer-input => .col-xs-4 --- docs/_includes/customizer-variables.html | 746 +++++++++++------------ docs/_jade/customizer-variables.jade | 2 +- docs/assets/css/src/docs.css | 7 - 3 files changed, 374 insertions(+), 381 deletions(-) diff --git a/docs/_includes/customizer-variables.html b/docs/_includes/customizer-variables.html index d489704091..cd98145139 100644 --- a/docs/_includes/customizer-variables.html +++ b/docs/_includes/customizer-variables.html @@ -3,50 +3,50 @@

Colors

Gray and brand colors for use across Bootstrap.

-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
@@ -54,28 +54,28 @@

Scaffolding

Settings for some of the most global styles.

-
+

Background color for <body>.

-
+

Global text color on <body>.

-
+

Global textual link color.

-
+

Link hover color set via darken() function.

-
+

Link hover decoration.

@@ -84,89 +84,89 @@

Typography

Font, line-height, and color for body text, headings, and more.

-
+
-
+
-
+

Default monospace fonts for <code>, <kbd>, and <pre>.

-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+

Unit-less line-height for use in components like buttons.

-
+

Computed "line-height" (font-size * line-height) for use with margin, padding, etc.

-
+

By default, this inherits from the <body>.

-
+
-
+
-
+
@@ -174,17 +174,17 @@

Iconography

Specify custom location and filename of the included Glyphicons icon font. Useful for those including Bootstrap via Bower.

-
+

Load fonts from this directory.

-
+

File name for all font files.

-
+

Element ID within SVG icon file.

@@ -193,79 +193,79 @@

Components

Define common padding and border radius sizes and more. Values based on 14px text and 1.428 line-height (~20px to start).

-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+

Global color for active items (e.g., navs or dropdowns).

-
+

Global background color for active items (e.g., navs or dropdowns).

-
+

Width of the border for generating carets that indicator dropdowns.

-
+

Carets increase slightly in size for larger components.

@@ -274,38 +274,38 @@

Tables

Customizes the .table component with basic values, each used across all table variations.

-
+

Padding for <th>s and <td>s.

-
+

Padding for cells in .table-condensed.

-
+

Default background color used for all tables.

-
+

Background color used for .table-striped.

-
+

Background color used for .table-hover.

-
+
-
+

Border color for table and cell borders.

@@ -314,174 +314,174 @@

Buttons

For each of Bootstrap's buttons, define text, background and border color.

-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+

Forms

-
+

<input> background color

-
+

<input disabled> background color

-
+

Text color for <input>s

-
+

<input> border color

-
+

Default .form-control border radius

-
+

Large .form-control border radius

-
+

Small .form-control border radius

-
+

Border color for inputs on focus

-
+

Placeholder text color

-
+

Default .form-control height

-
+

Large .form-control height

-
+

Small .form-control height

-
+
-
+
-
+

Background color for textual input addons

-
+

Border color for textual input addons

@@ -490,65 +490,65 @@

Dropdown menu container and contents.

-
+

Background for the dropdown menu.

-
+

Dropdown menu border-color.

-
+

Dropdown menu border-color for IE8.

-
+

Divider color for between dropdown items.

-
+

Dropdown link text color.

-
+

Hover color for dropdown links.

-
+

Hover background for dropdown links.

-
+

Active dropdown menu item text color.

-
+

Active dropdown menu item background color.

-
+

Disabled dropdown menu item background color.

-
+

Text color for headers within dropdown menus.

-
+

Deprecated @dropdown-caret-color as of v3.1.0

@@ -557,76 +557,76 @@

Media queries breakpoints

Define the breakpoints at which your layout will change, adapting to different screen sizes.

-
+

Deprecated @screen-xs as of v3.0.1

-
+

Deprecated @screen-xs-min as of v3.2.0

-
+

Deprecated @screen-phone as of v3.0.1

-
+

Deprecated @screen-sm as of v3.0.1

-
+
-
+

Deprecated @screen-tablet as of v3.0.1

-
+

Deprecated @screen-md as of v3.0.1

-
+
-
+

Deprecated @screen-desktop as of v3.0.1

-
+

Deprecated @screen-lg as of v3.0.1

-
+
-
+

Deprecated @screen-lg-desktop as of v3.0.1

-
+
-
+
-
+
@@ -634,23 +634,23 @@

Grid system

Define your custom responsive grid.

-
+

Number of columns in the grid.

-
+

Padding between columns. Gets divided in half for the left and right.

-
+

Point at which the navbar becomes uncollapsed.

-
+

Point at which the navbar begins collapsing.

@@ -659,30 +659,30 @@

Container sizes

Define the maximum width of .container for different screen sizes.

-
+
-
+

For @screen-sm-min and up.

-
+
-
+

For @screen-md-min and up.

-
+
-
+

For @screen-lg-min and up.

@@ -690,167 +690,167 @@
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
@@ -858,179 +858,179 @@

Shared nav styles

-
+
-
+
-
+
-
+

Tabs

-
+
-
+
-
+
-
+
-
+
-
+
-
+

Pills

-
+
-
+
-
+

Pagination

-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+

Pager

-
+
-
+
-
+
-
+
-
+
-
+
-
+

Jumbotron

-
+
-
+
-
+
-
+
-
+
@@ -1038,86 +1038,86 @@

Form states and alerts

Define colors for form feedback states and, by default, alerts.

-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+

Tooltips

-
+

Tooltip max width

-
+

Tooltip text color

-
+

Tooltip background color

-
+
-
+

Tooltip arrow width

-
+

Tooltip arrow color

@@ -1125,55 +1125,55 @@

Popovers

-
+

Popover body background color

-
+

Popover maximum width

-
+

Popover border color

-
+

Popover fallback border color

-
+

Popover title background color

-
+

Popover arrow width

-
+

Popover arrow color

-
+

Popover outer arrow width

-
+

Popover outer arrow color

-
+

Popover outer arrow fallback color

@@ -1181,44 +1181,44 @@

Labels

-
+

Default label background color

-
+

Primary label background color

-
+

Success label background color

-
+

Info label background color

-
+

Warning label background color

-
+

Danger label background color

-
+

Default label text color

-
+

Default text color of a linked label

@@ -1226,69 +1226,69 @@

Modals

-
+

Padding applied to the modal body

-
+

Padding applied to the modal title

-
+

Modal title line-height

-
+

Background color of modal content area

-
+

Modal content border color

-
+

Modal content border color for IE8

-
+

Modal backdrop background color

-
+

Modal backdrop opacity

-
+

Modal header border color

-
+

Modal footer border color

-
+
-
+
-
+
@@ -1296,111 +1296,111 @@

Alerts

Define alert colors, border radius, and padding.

-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+

Progress bars

-
+

Background color of the whole progress component

-
+

Progress bar text color

-
+

Variable for setting rounded corners on progress bar.

-
+

Default progress bar color

-
+

Success progress bar color

-
+

Warning progress bar color

-
+

Danger progress bar color

-
+

Info progress bar color

@@ -1408,219 +1408,219 @@

List group

-
+

Background color on .list-group-item

-
+

.list-group-item border color

-
+

List group border radius

-
+

Background color of single list items on hover

-
+

Text color of active list items

-
+

Background color of active list items

-
+

Border color of active list elements

-
+

Text color for content within active list items

-
+

Text color of disabled list items

-
+

Background color of disabled list items

-
+

Text color for content within disabled list items

-
+
-
+
-
+

Panels

-
+
-
+
-
+
-
+
-
+
-
+

Border color for elements within panels

-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+

Thumbnails

-
+

Padding around the thumbnail image

-
+

Thumbnail background color

-
+

Thumbnail border color

-
+

Thumbnail border radius

-
+

Custom text color for thumbnail captions

-
+

Padding around the thumbnail caption

@@ -1628,82 +1628,82 @@

Wells

-
+
-
+

Badges

-
+
-
+

Linked badge text color on hover

-
+
-
+

Badge text color in active nav link

-
+

Badge background color in active nav link

-
+
-
+
-
+
-
+
-
+
-
+

Breadcrumb background color

-
+

Breadcrumb text color

-
+

Text color of current page in the breadcrumb

-
+

Textual separator for between breadcrumb elements

@@ -1711,144 +1711,144 @@
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+

Close

-
+
-
+
-
+

Code

-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+

Type

-
+

Horizontal offset for forms and lists.

-
+

Text muted color

-
+

Abbreviations and acronyms border color

-
+

Headings small color

-
+

Blockquote small color

-
+

Blockquote font size

-
+

Blockquote border color

-
+

Page header border color

-
+

Width of horizontal description list titles

-
+

Horizontal line color.

diff --git a/docs/_jade/customizer-variables.jade b/docs/_jade/customizer-variables.jade index 39d3f9f194..bd0df1d139 100644 --- a/docs/_jade/customizer-variables.jade +++ b/docs/_jade/customizer-variables.jade @@ -11,7 +11,7 @@ each section in sections each variable, index in subsection.variables if index > 0 && index % 3 === 0 div.clearfix - div.bs-customizer-input + div.col-xs-4 label(for="input-" + variable.name)= variable.name input.form-control( id="input-" + variable.name diff --git a/docs/assets/css/src/docs.css b/docs/assets/css/src/docs.css index 428a543210..431ee905fd 100644 --- a/docs/assets/css/src/docs.css +++ b/docs/assets/css/src/docs.css @@ -1342,13 +1342,6 @@ h1[id] { font-weight: normal; } -.bs-customizer-input { - float: left; - width: 33.333333%; - padding-right: 15px; - padding-left: 15px; -} - /* Downloads */ .bs-customize-download .btn-outline { padding: 20px; From 0b9f69b9c85cb611caaa264479bcad28522637d9 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 27 Oct 2014 15:26:48 -0700 Subject: [PATCH 3/4] Update Sauce iOS Safari test to iOS 8.0 [skip validator] --- grunt/sauce_browsers.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grunt/sauce_browsers.yml b/grunt/sauce_browsers.yml index 8014bfcb80..c895bab299 100644 --- a/grunt/sauce_browsers.yml +++ b/grunt/sauce_browsers.yml @@ -57,7 +57,7 @@ { browserName: "iphone", platform: "OS X 10.9", - version: "7.1" + version: "8.0" }, # iOS Chrome not currently supported by Sauce Labs From 22e1f94b52b741c62d3f7d9d7891b395e7bb2372 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 27 Oct 2014 15:53:41 -0700 Subject: [PATCH 4/4] Increase timeouts in tooltip unit tests to avoid spurious Sauce failures Fixes #14851 --- js/tests/unit/tooltip.js | 62 ++++++++++++++++++++-------------------- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/js/tests/unit/tooltip.js b/js/tests/unit/tooltip.js index 351dd61cb5..4fbd91dc37 100644 --- a/js/tests/unit/tooltip.js +++ b/js/tests/unit/tooltip.js @@ -803,16 +803,16 @@ $(function () { var $tooltip = $('') .appendTo('#qunit-fixture') - .bootstrapTooltip({ delay: 15 }) + .bootstrapTooltip({ delay: 150 }) setTimeout(function () { - ok(!$('.tooltip').is('.fade.in'), '10ms: tooltip is not faded in') - }, 10) + ok(!$('.tooltip').is('.fade.in'), '100ms: tooltip is not faded in') + }, 100) setTimeout(function () { - ok($('.tooltip').is('.fade.in'), '20ms: tooltip is faded in') + ok($('.tooltip').is('.fade.in'), '200ms: tooltip is faded in') start() - }, 20) + }, 200) $tooltip.trigger('mouseenter') }) @@ -822,17 +822,17 @@ $(function () { var $tooltip = $('') .appendTo('#qunit-fixture') - .bootstrapTooltip({ delay: 15 }) + .bootstrapTooltip({ delay: 150 }) setTimeout(function () { - ok(!$('.tooltip').is('.fade.in'), '10ms: tooltip not faded in') + ok(!$('.tooltip').is('.fade.in'), '100ms: tooltip not faded in') $tooltip.trigger('mouseout') - }, 10) + }, 100) setTimeout(function () { - ok(!$('.tooltip').is('.fade.in'), '20ms: tooltip not faded in') + ok(!$('.tooltip').is('.fade.in'), '200ms: tooltip not faded in') start() - }, 20) + }, 200) $tooltip.trigger('mouseenter') }) @@ -842,21 +842,21 @@ $(function () { var $tooltip = $('') .appendTo('#qunit-fixture') - .bootstrapTooltip({ delay: { show: 0, hide: 15 }}) + .bootstrapTooltip({ delay: { show: 0, hide: 150 }}) setTimeout(function () { ok($('.tooltip').is('.fade.in'), '1ms: tooltip faded in') $tooltip.trigger('mouseout') setTimeout(function () { - ok($('.tooltip').is('.fade.in'), '10ms: tooltip still faded in') + ok($('.tooltip').is('.fade.in'), '100ms: tooltip still faded in') $tooltip.trigger('mouseenter') - }, 10) + }, 100) setTimeout(function () { - ok($('.tooltip').is('.fade.in'), '20ms: tooltip still faded in') + ok($('.tooltip').is('.fade.in'), '200ms: tooltip still faded in') start() - }, 20) + }, 200) }, 0) $tooltip.trigger('mouseenter') @@ -867,17 +867,17 @@ $(function () { var $tooltip = $('') .appendTo('#qunit-fixture') - .bootstrapTooltip({ delay: 15 }) + .bootstrapTooltip({ delay: 150 }) setTimeout(function () { - ok(!$('.tooltip').is('.fade.in'), '10ms: tooltip not faded in') + ok(!$('.tooltip').is('.fade.in'), '100ms: tooltip not faded in') $tooltip.trigger('mouseout') - }, 10) + }, 100) setTimeout(function () { - ok(!$('.tooltip').is('.fade.in'), '20ms: tooltip not faded in') + ok(!$('.tooltip').is('.fade.in'), '200ms: tooltip not faded in') start() - }, 20) + }, 200) $tooltip.trigger('mouseenter') }) @@ -887,27 +887,27 @@ $(function () { var $tooltip = $('') .appendTo('#qunit-fixture') - .bootstrapTooltip({ delay: { show: 15, hide: 0 }}) + .bootstrapTooltip({ delay: { show: 150, hide: 0 }}) setTimeout(function () { - ok(!$('.tooltip').is('.fade.in'), '10ms: tooltip not faded in') + ok(!$('.tooltip').is('.fade.in'), '100ms: tooltip not faded in') $tooltip.trigger('mouseout') - }, 10) + }, 100) setTimeout(function () { - ok(!$('.tooltip').is('.fade.in'), '25ms: tooltip not faded in') + ok(!$('.tooltip').is('.fade.in'), '250ms: tooltip not faded in') start() - }, 25) + }, 250) $tooltip.trigger('mouseenter') }) - test('should wait 20ms before hiding the tooltip', function () { + test('should wait 200ms before hiding the tooltip', function () { stop() var $tooltip = $('') .appendTo('#qunit-fixture') - .bootstrapTooltip({ delay: { show: 0, hide: 15 }}) + .bootstrapTooltip({ delay: { show: 0, hide: 150 }}) setTimeout(function () { ok($tooltip.data('bs.tooltip').$tip.is('.fade.in'), '1ms: tooltip faded in') @@ -915,13 +915,13 @@ $(function () { $tooltip.trigger('mouseout') setTimeout(function () { - ok($tooltip.data('bs.tooltip').$tip.is('.fade.in'), '10ms: tooltip still faded in') - }, 10) + ok($tooltip.data('bs.tooltip').$tip.is('.fade.in'), '100ms: tooltip still faded in') + }, 100) setTimeout(function () { - ok(!$tooltip.data('bs.tooltip').$tip.is('.in'), '20ms: tooltip removed') + ok(!$tooltip.data('bs.tooltip').$tip.is('.in'), '200ms: tooltip removed') start() - }, 20) + }, 200) }, 0)