From 928bdcadc56cef30b4483616c4b2eee7cfa34bd2 Mon Sep 17 00:00:00 2001 From: GeoSot Date: Mon, 31 Jan 2022 00:31:07 +0200 Subject: [PATCH] Carousel: make direct triggering of slid event, instead of using a callback --- js/src/carousel.js | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/js/src/carousel.js b/js/src/carousel.js index 00d9304953..b8d921e422 100644 --- a/js/src/carousel.js +++ b/js/src/carousel.js @@ -363,15 +363,6 @@ class Carousel extends BaseComponent { this._setActiveIndicatorElement(nextElement) this._activeElement = nextElement - const triggerSlidEvent = () => { - EventHandler.trigger(this._element, EVENT_SLID, { - relatedTarget: nextElement, - direction: eventDirectionName, - from: activeElementIndex, - to: nextElementIndex - }) - } - nextElement.classList.add(orderClassName) reflow(nextElement) @@ -387,7 +378,12 @@ class Carousel extends BaseComponent { this._isSliding = false - setTimeout(triggerSlidEvent, 0) + EventHandler.trigger(this._element, EVENT_SLID, { + relatedTarget: nextElement, + direction: eventDirectionName, + from: activeElementIndex, + to: nextElementIndex + }) } this._queueCallback(completeCallBack, activeElement, this._isAnimated())