rooty/Bootstrap
0
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2025-02-12 09:54:25 +01:00
Code Issues Actions Packages Releases Activity

Update tests to check for noop to be removed

Browse Source
This commit is contained in:
Rohit Sharma 2021-04-08 01:28:05 +05:30 committed by XhmikosR
parent 5f946d3a86
commit bac0b0c899
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
js/tests/unit/dropdown.spec.js
View File

@ -1,5 +1,6 @@
import Dropdown from '../../src/dropdown' import Dropdown from '../../src/dropdown'
import EventHandler from '../../src/dom/event-handler' import EventHandler from '../../src/dom/event-handler'
import { noop } from '../../src/util'
/** Test helpers */ /** Test helpers */
import { getFixture, clearFixture, createEvent, jQueryMock } from '../helpers/fixture' import { getFixture, clearFixture, createEvent, jQueryMock } from '../helpers/fixture'
@ -252,7 +253,7 @@ describe('Dropdown', () => {
btnDropdown.addEventListener('shown.bs.dropdown', () => { btnDropdown.addEventListener('shown.bs.dropdown', () => {
expect(btnDropdown.classList.contains('show')).toEqual(true) expect(btnDropdown.classList.contains('show')).toEqual(true)
expect(btnDropdown.getAttribute('aria-expanded')).toEqual('true') expect(btnDropdown.getAttribute('aria-expanded')).toEqual('true')
expect(EventHandler.on).toHaveBeenCalled() expect(EventHandler.on).toHaveBeenCalledWith(jasmine.any(Object), 'mouseover', noop)
dropdown.toggle() dropdown.toggle()
}) })
@ -260,7 +261,7 @@ describe('Dropdown', () => {
btnDropdown.addEventListener('hidden.bs.dropdown', () => { btnDropdown.addEventListener('hidden.bs.dropdown', () => {
expect(btnDropdown.classList.contains('show')).toEqual(false) expect(btnDropdown.classList.contains('show')).toEqual(false)
expect(btnDropdown.getAttribute('aria-expanded')).toEqual('false') expect(btnDropdown.getAttribute('aria-expanded')).toEqual('false')
expect(EventHandler.off).toHaveBeenCalled() expect(EventHandler.off).toHaveBeenCalledWith(jasmine.any(Object), 'mouseover', noop)
document.documentElement.ontouchstart = defaultValueOnTouchStart document.documentElement.ontouchstart = defaultValueOnTouchStart
done() done()

4
js/tests/unit/tooltip.spec.js
View File

@ -450,7 +450,7 @@ describe('Tooltip', () => {
tooltipEl.addEventListener('shown.bs.tooltip', () => { tooltipEl.addEventListener('shown.bs.tooltip', () => {
expect(document.querySelector('.tooltip')).not.toBeNull() expect(document.querySelector('.tooltip')).not.toBeNull()
expect(EventHandler.on).toHaveBeenCalled() expect(EventHandler.on).toHaveBeenCalledWith(jasmine.any(Object), 'mouseover', noop)
document.documentElement.ontouchstart = undefined document.documentElement.ontouchstart = undefined
done() done()
}) })
@ -889,7 +889,7 @@ describe('Tooltip', () => {
tooltipEl.addEventListener('hidden.bs.tooltip', () => { tooltipEl.addEventListener('hidden.bs.tooltip', () => {
expect(document.querySelector('.tooltip')).toBeNull() expect(document.querySelector('.tooltip')).toBeNull()
expect(EventHandler.off).toHaveBeenCalled() expect(EventHandler.off).toHaveBeenCalledWith(jasmine.any(Object), 'mouseover', noop)
document.documentElement.ontouchstart = undefined document.documentElement.ontouchstart = undefined
done() done()
}) })