From 12a3bb31f82b7fee96dbd5d91f4a5bef90c7acd6 Mon Sep 17 00:00:00 2001 From: Alexander Prinzhorn Date: Fri, 27 Sep 2013 11:32:06 +0200 Subject: [PATCH] Only preventDefault on click on [data-toggle="modal"] when the element is a link In it's current state Bootstrap always prevents the default action for a click event on `[data-toggle="modal"]` elements (see https://github.com/twbs/bootstrap/blob/master/js/modal.js#L233). Instead this should only happen when the element is a link. --- js/modal.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/modal.js b/js/modal.js index 65eba481e5..349431d998 100644 --- a/js/modal.js +++ b/js/modal.js @@ -230,7 +230,7 @@ var $target = $($this.attr('data-target') || (href && href.replace(/.*(?=#[^\s]+$)/, ''))) //strip for ie7 var option = $target.data('modal') ? 'toggle' : $.extend({ remote: !/#/.test(href) && href }, $target.data(), $this.data()) - e.preventDefault() + if ($this.is('a')) e.preventDefault() $target .modal(option, this)