rooty/Bootstrap
0
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-01 13:24:25 +01:00
Code Issues Actions Packages Releases Activity

Remove the show property from the modal plugin (#32279)

Browse Source 
Drop the support of show property from the modal plugin.
When creating the new modal instance in v5, the `show` property does not work anymore, so instead of fixing the behavior just removing it permanently to keep the consistency between all the plugins. (All other plugins require the `show()` method to be called on the instances to be shown)

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
This commit is contained in:
Rohit Sharma 2020-11-30 15:42:40 +05:30 committed by GitHub
parent 03ed3e0b3b
commit c3689ac073
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
js/src/modal.js
View File

@ -37,15 +37,13 @@ const ESCAPE_KEY = 'Escape'
const Default = { const Default = {
backdrop: true, backdrop: true,
keyboard: true, keyboard: true,
focus: true, focus: true
show: true
} }
const DefaultType = { const DefaultType = {
backdrop: '(boolean|string)', backdrop: '(boolean|string)',
keyboard: 'boolean', keyboard: 'boolean',
focus: 'boolean', focus: 'boolean'
show: 'boolean'
} }
const EVENT_HIDE = `hide${EVENT_KEY}` const EVENT_HIDE = `hide${EVENT_KEY}`
@ -557,8 +555,6 @@ class Modal extends BaseComponent {
} }
data[config](relatedTarget) data[config](relatedTarget)
} else if (_config.show) {
data.show(relatedTarget)
} }
}) })
} }

6
site/content/docs/5.0/components/modal.md
View File

@ -877,12 +877,6 @@ Options can be passed via data attributes or JavaScript. For data attributes, ap
<td><code>true</code></td> <td><code>true</code></td>
<td>Puts the focus on the modal when initialized.</td> <td>Puts the focus on the modal when initialized.</td>
</tr> </tr>
<tr>
<td><code>show</code></td>
<td>boolean</td>
<td><code>true</code></td>
<td>Shows the modal when initialized.</td>
</tr>
</tbody> </tbody>
</table> </table>