From dcec1df61f107e2b449486aafefbb1d14abe0333 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 10 Sep 2024 17:07:45 +0300 Subject: [PATCH 1/2] Build(deps-dev): Bump postcss from 8.4.44 to 8.4.45 (#40806) Bumps [postcss](https://github.com/postcss/postcss) from 8.4.44 to 8.4.45. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/8.4.44...8.4.45) --- updated-dependencies: - dependency-name: postcss dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- package-lock.json | 8 ++++---- package.json | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package-lock.json b/package-lock.json index 1aade44f79..b43d3cd429 100644 --- a/package-lock.json +++ b/package-lock.json @@ -59,7 +59,7 @@ "lockfile-lint": "^4.14.0", "nodemon": "^3.1.4", "npm-run-all2": "^6.2.2", - "postcss": "^8.4.44", + "postcss": "^8.4.45", "postcss-cli": "^11.0.0", "rollup": "^4.21.2", "rollup-plugin-istanbul": "^5.0.0", @@ -9725,9 +9725,9 @@ } }, "node_modules/postcss": { - "version": "8.4.44", - "resolved": "https://registry.npmjs.org/postcss/-/postcss-8.4.44.tgz", - "integrity": "sha512-Aweb9unOEpQ3ezu4Q00DPvvM2ZTUitJdNKeP/+uQgr1IBIqu574IaZoURId7BKtWMREwzKa9OgzPzezWGPWFQw==", + "version": "8.4.45", + "resolved": "https://registry.npmjs.org/postcss/-/postcss-8.4.45.tgz", + "integrity": "sha512-7KTLTdzdZZYscUc65XmjFiB73vBhBfbPztCYdUNvlaso9PrzjzcmjqBPR0lNGkcVlcO4BjiO5rK/qNz+XAen1Q==", "dev": true, "funding": [ { diff --git a/package.json b/package.json index 9610689180..91e3bc01a3 100644 --- a/package.json +++ b/package.json @@ -143,7 +143,7 @@ "lockfile-lint": "^4.14.0", "nodemon": "^3.1.4", "npm-run-all2": "^6.2.2", - "postcss": "^8.4.44", + "postcss": "^8.4.45", "postcss-cli": "^11.0.0", "rollup": "^4.21.2", "rollup-plugin-istanbul": "^5.0.0", From fecd219983539aa0110a7e09d31b8aa4d5fb4348 Mon Sep 17 00:00:00 2001 From: Dmitry Date: Thu, 12 Sep 2024 09:45:08 +0200 Subject: [PATCH 2/2] Fix popover remaining open when toggled after being shown (#40803) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Dmitry Sergienko Co-authored-by: Julien Déramond --- js/src/tooltip.js | 1 - js/tests/unit/popover.spec.js | 20 ++++++++++++++++++++ 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/js/src/tooltip.js b/js/src/tooltip.js index 92d4553493..097477f7a1 100644 --- a/js/src/tooltip.js +++ b/js/src/tooltip.js @@ -160,7 +160,6 @@ class Tooltip extends BaseComponent { return } - this._activeTrigger.click = !this._activeTrigger.click if (this._isShown()) { this._leave() return diff --git a/js/tests/unit/popover.spec.js b/js/tests/unit/popover.spec.js index ba38ebe066..1c81ba7927 100644 --- a/js/tests/unit/popover.spec.js +++ b/js/tests/unit/popover.spec.js @@ -56,6 +56,26 @@ describe('Popover', () => { }) describe('show', () => { + it('should toggle a popover after show', () => { + return new Promise(resolve => { + fixtureEl.innerHTML = 'BS twitter' + + const popoverEl = fixtureEl.querySelector('a') + const popover = new Popover(popoverEl) + + popoverEl.addEventListener('shown.bs.popover', () => { + expect(document.querySelector('.popover')).not.toBeNull() + popover.toggle() + }) + popoverEl.addEventListener('hidden.bs.popover', () => { + expect(document.querySelector('.popover')).toBeNull() + resolve() + }) + + popover.show() + }) + }) + it('should show a popover', () => { return new Promise(resolve => { fixtureEl.innerHTML = 'BS twitter'