From 7a781b2ae00cfbc5f49530a4de1394c4008b499f Mon Sep 17 00:00:00 2001 From: "Patrick H. Lauke" Date: Tue, 11 Jul 2017 19:51:21 +0100 Subject: [PATCH 1/3] Remove ::first-letter and ::first-line selectors from print styles Bootstrap itself doesn't use any `::first-letter` or `::first-line` styles. These selectors also cause(d) problems in IE11 (see https://github.com/h5bp/html5-boilerplate/pull/1799) and currently cause a nasty rendering bug in Chrome where the first letter is vertically shifted (see https://github.com/twbs/bootstrap/issues/21771) As h5bp has now removed these as well, no need to keep and comment them out. See https://github.com/h5bp/html5-boilerplate/issues/1961 / https://github.com/h5bp/html5-boilerplate/pull/1962 --- scss/_print.scss | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/scss/_print.scss b/scss/_print.scss index e20219a38b..7f8d9900a3 100644 --- a/scss/_print.scss +++ b/scss/_print.scss @@ -12,15 +12,7 @@ @media print { *, *::before, - *::after, - p::first-letter, - div::first-letter, - blockquote::first-letter, - li::first-letter, - p::first-line, - div::first-line, - blockquote::first-line, - li::first-line { + *::after { // Bootstrap specific; comment out `color` and `background` //color: #000 !important; // Black prints faster: // http://www.sanbeiji.com/archives/953 From b14c5cc4b8c23c5630d2520cab7e5d8ef1556049 Mon Sep 17 00:00:00 2001 From: Casper Date: Wed, 12 Jul 2017 08:57:32 +0800 Subject: [PATCH 2/3] Fixed a word (connectinh / connecting) --- docs/4.0/components/collapse.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/4.0/components/collapse.md b/docs/4.0/components/collapse.md index 25b236e740..c77d436fb0 100644 --- a/docs/4.0/components/collapse.md +++ b/docs/4.0/components/collapse.md @@ -113,7 +113,7 @@ Using the [card]({{ site.baseurl }}/docs/{{ site.docs_version }}/components/card {% endexample %} -You can also create accordions with custom markup. Add the `data-children` attribute and specify a set of sibling elements to toggle (e.g., `.item`). Then, use the same attributes and classes as shown above for connectinh toggles to their associated content. +You can also create accordions with custom markup. Add the `data-children` attribute and specify a set of sibling elements to toggle (e.g., `.item`). Then, use the same attributes and classes as shown above for connecting toggles to their associated content. {% example html %}
From c00437ec1b47d1ec9c7e0b181afec87c2c480631 Mon Sep 17 00:00:00 2001 From: "Patrick H. Lauke" Date: Thu, 13 Jul 2017 00:25:40 +0100 Subject: [PATCH 3/3] Add badge counter example and accessibility advice --- docs/4.0/components/badge.md | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/docs/4.0/components/badge.md b/docs/4.0/components/badge.md index e2d92b08b3..4e80828a44 100644 --- a/docs/4.0/components/badge.md +++ b/docs/4.0/components/badge.md @@ -28,6 +28,36 @@ Badges scale to match the size of the immediate parent element by using relative
Example heading New
{% endhighlight %} +Badges can be used as part of links or buttons to provide a counter. + +
+ +
+ +{% highlight html %} + +{% endhighlight %} + +Note that depending on how they are used, badges may be confusing for users of screen readers and similar assistive technologies. While the styling of badges provides a visual cue as to their purpose, these users will simply be presented with the content of the badge. Depending on the specific situation, these badges may seem like random additional words or numbers at the end of a sentence, link or button. Unless the context is clear (as with the "Notifications" example, where it is arguably understandable that the "4" gives a count of the number of notifications), consider including additional context – for instance using a visually hidden piece of additional text. + +
+ +
+ +{% highlight html %} + +{% endhighlight %} + ## Contextual variations Add any of the below mentioned modifier classes to change the appearance of a badge.