0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-01 13:24:25 +01:00
Commit Graph

20424 Commits

Author SHA1 Message Date
Rohit Sharma
c3689ac073
Remove the show property from the modal plugin (#32279)
Drop the support of show property from the modal plugin.
When creating the new modal instance in v5, the `show` property does not work anymore, so instead of fixing the behavior just removing it permanently to keep the consistency between all the plugins. (All other plugins require the `show()` method to be called on the instances to be shown)

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-30 12:12:40 +02:00
XhmikosR
03ed3e0b3b tooltip.js: reuse existent variable 2020-11-30 12:07:51 +02:00
XhmikosR
dd992c7226 Add tests 2020-11-30 12:07:51 +02:00
Patrick H. Lauke
adc857f617 Extra check for existence of any aria-label
before overwriting it...
2020-11-30 12:07:51 +02:00
Matty Williams
b0372bb658 Accessibility update for tooltip.js
Update to the tooltip.js to add an aria-label attribute that contains the original title of the element, but only if the element doesn't have an existing aria-label attribute.

This is to address cases where screen readers are not capturing the aria-describedby attribute that is added when the tooltip is triggered.  This should also avoid a race condition between the screen reader and the appearance of the tooltip.
2020-11-30 12:07:51 +02:00
Rohit Sharma
af57444405
Keep rounded corners for the first .btn in vertical button group (#31303)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-30 11:09:55 +02:00
Martijn Cuppens
ff25a75320
Remove default linear gradient (#32277)
Remove the default invisible gradient causing the performance issue in #32266. By removing the custom property, the linear gradient will become invalid, thus not appear by default.

There can still be a performance issue with striped tables though.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-30 10:51:32 +02:00
Patrick H. Lauke
948f834347
Add mention of link underline change to migration and typography (#32281)
x-ref https://github.com/twbs/bootstrap/discussions/32276#discussioncomment-141850

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-30 07:02:03 +02:00
Rohit Sharma
04674f88b0 Remove setData from construtors (#32264) 2020-11-29 20:58:26 +02:00
Johann-S
4999c3dbbc remove data key in base component 2020-11-29 20:58:26 +02:00
Rohit Sharma
f6a8733741 Move VERSION to BaseComponent (#32254) 2020-11-29 20:58:26 +02:00
Johann-S
9eb9d02084 add dispose in base component 2020-11-29 20:58:26 +02:00
XhmikosR
51a208f119 Switch to Jasmine's toBeInstanceOf matcher 2020-11-29 20:58:26 +02:00
Johann-S
9f6b342dc7 create a base component 2020-11-29 20:58:26 +02:00
XhmikosR
c63aebc86b
homepage: fix wrong alt attribute (#32258) 2020-11-25 18:31:34 +02:00
XhmikosR
81ac002a02
npm scripts: run integration tests in parallel (#32232) 2020-11-25 09:29:16 +02:00
Rohit Sharma
c348ad4a94
Ability to add custom class in tooltip/popover (#32217)
Porting of #31834 to main.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-25 09:16:22 +02:00
XhmikosR
d61f506a5f
Update codeql.yml (#32125)
Specify the branches and clean up the comments
2020-11-24 08:35:33 +02:00
XhmikosR
7ff881c532
Update devDependencies (#32229)
* @babel/cli         ^7.12.1  →  ^7.12.8
* @babel/core        ^7.12.3  →  ^7.12.8
* @babel/preset-env  ^7.12.1  →  ^7.12.7
* eslint             ^7.13.0  →  ^7.14.0
* postcss             ^8.1.7  →   ^8.1.10
* postcss-cli         ^8.2.0  →   ^8.3.0
* rollup             ^2.33.2  →  ^2.33.3
* stylelint          ^13.7.2  →  ^13.8.0
2020-11-24 08:19:25 +02:00
XhmikosR
d8ff27721b
introduction: split comments (#32223) 2020-11-23 22:17:37 +02:00
XhmikosR
767db7b746
tests/integration/index.html: revert accidental changes 2020-11-23 22:14:52 +02:00
Rohit Sharma
7c7f08b5e0
Update bundle.js in tests/integration (#32233)
* Use `[].concat` instead of direct spreading nodelist

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-23 21:35:46 +02:00
XhmikosR
8f8787725b
Update _syntax.scss (#32117)
* Update _syntax.scss with the latest chroma selectors

* Sort selectors

* Remove no longer needed chroma workaround

* remove comments
2020-11-23 21:34:38 +02:00
XhmikosR
fdc40f5053
CI: specify FORCE_COLOR:2 (#32222)
This should show any colors in the output
2020-11-23 21:32:25 +02:00
XhmikosR
ee2bcdec3d
postcss.config.js: remove arrow return (#32235) 2020-11-23 16:11:16 +02:00
XhmikosR
3e823e0b75
Dist (#32216) 2020-11-23 15:17:16 +02:00
Noah Rosenzweig
21737ed530
Improve build/generate-sri.js regex (#29753)
When using single-quotes in config.yml, the previous
regular expression in build/generate-cli.js wasn't working correctly,
it was replacing ALL string values with hashes.
Now both double- and single-quotes can be used in config.yml,
and the RegExp will work as expected.

Also, allow trailing whitespaces and empty ("") values to be matched.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-21 21:39:33 +02:00
XhmikosR
d365831bce
docs: use event instead of e (#32226)
It's better for clarity.
2020-11-21 17:00:38 +02:00
XhmikosR
f4457bca02
Be consistent with Popper's name. (#32224)
The npm package is named "popper.js" but the project is named "Popper", so use the latter consistently.
2020-11-21 16:22:08 +02:00
Rohit Sharma
358c36d4b5
Add missing tags in unit tests (#32221) 2020-11-20 20:10:15 +02:00
Rohit Sharma
0839cbf04d
Don't hide modal when keyboard is set to false in modal's configuration (#32179)
* Don't hide modal when config.keyboard is false

* Update unit test

- Modal should not be closed when pressing esc key if keyboard = false
  and backdrop is 'static'

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-20 15:36:24 +02:00
Rohit Sharma
2630b05eb3
Make the attribute methods bs specific (#32173)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-20 11:13:13 +02:00
XhmikosR
a96b118f04
_reboot.scss: remove needless Stylelint disable (#32213) 2020-11-20 09:54:24 +02:00
XhmikosR
6637154beb
Revert "Use Hugo mounts for our docs vendor files." (#32210)
* Revert "Adapt to the recent main changes"

This reverts commit 50d8921670.

* Revert "Add Hugo Pipes logic for local and vendored scripts."

This reverts commit 3fcfd606f2.

* Revert "Use Hugo mounts for our docs vendor JS files."

This reverts commit 6b071116f3.
2020-11-19 21:09:34 +02:00
XhmikosR
50d8921670 Adapt to the recent main changes
* remove `bs-custom-file-input.min.js`
* switch to errorf
* change error message
2020-11-19 20:54:42 +02:00
Regis Philibert
3fcfd606f2 Add Hugo Pipes logic for local and vendored scripts. 2020-11-19 20:54:42 +02:00
XhmikosR
6b071116f3 Use Hugo mounts for our docs vendor JS files. 2020-11-19 20:54:42 +02:00
Gaël Poupard
268da84f16
fix(container): use $variable-prefix (#32201)
Missed that while merging.
2020-11-19 20:38:39 +02:00
XhmikosR
2185803964
Fix a few typos (#32204) 2020-11-19 20:32:35 +02:00
Martijn Cuppens
8f3c8a922a
Manually optimize SVGs (#32187) 2020-11-19 19:07:06 +01:00
XhmikosR
65d6c8a731
docs: update selector CodePen example (#32163) 2020-11-19 17:15:40 +02:00
XhmikosR
64a864075c
examples: add the version number in title (#32198) 2020-11-19 13:38:48 +02:00
Mark Otto
7fec0ec3d7 Update migration guide about w-100 2020-11-19 07:47:06 +02:00
XhmikosR
ecbc7189b6 examples: fix .btn-block instances 2020-11-19 07:47:06 +02:00
Jiang Yan
5501df0c29
Docs: fix homepage npm install version (#32194) 2020-11-19 07:42:44 +02:00
Patrick H. Lauke
5ec6400bd0
Docs: change sidebar collapse controls to actual button elements (#31098)
apart from the visual styling, there's probably no good reason why these shouldn't be `<button>` elements, semantically

the buttons still look a shade too button-like, despite using `.btn-light`. the last remnant of button styling can probably be suppressed further, *or* this makes the case for expanding the core button styles to have one that looks completely non-button and non-link like (for cases where an additional style/hint was given already, or it's clear from context that something's an actionable button or link)

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-18 20:20:05 +02:00
Matt Shaw
de8dbd72d8
correct "breakpoint" typo (#32191)
breakpoing --> breakpoint
2020-11-18 18:15:28 +02:00
Kyle Tsang
39b9879aa2
docs: Add missing .has-validation class for input group example (#32162)
Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-18 13:08:26 +02:00
XhmikosR
2d4f1b272c
Update karma.conf.js (#32182)
When we are on CI, this statement won't be reached.
2020-11-18 13:06:04 +02:00
Gaël Poupard
2b0b3091a0
docs(dropdowns): clarify where is .show applied (#32189)
Fixes #32712
2020-11-18 12:50:55 +02:00