rooty/Bootstrap
0
0
Fork 0
mirror of https://github.com/twbs/bootstrap.git synced 2024-11-29 11:24:18 +01:00
Code Issues Actions Packages Releases Activity
11,306 Commits 108 Branches 89 Tags 547 MiB
0c1daaf2ce
Commit Graph

962 Commits

Author SHA1 Message Date
Patrick H. Lauke
0c1daaf2ce Remove broken/vestigial unit test 
Overall logic for this test appears broken, possibly relating to an
older version of Bootstrap that did not require explicit
`data-toggle="button"` on single toggle buttons?
 2015-05-01 12:58:10 +01:00
Patrick H. Lauke
f9cd88e09f Fix radio and checkbox keyboard handling 
Fix for problem that emerged from #16226 (`.active` class not actually
being applied) and expansion of the script to also correctly handle
keyboard interaction with checkboxes in `data-toggle="button"` groups
 2015-05-01 12:19:19 +01:00
XhmikosR
3e7ca3bbc8 Minor lint tweaks. 2015-04-28 11:03:37 +03:00
F A T
aa479892d5 Merge pull request #16152 from jarthod/tooltip-placement-viewport-fix 
Tooltip/popover: Fix auto placement to use viewport
 2015-04-27 11:28:54 -07:00
Chris Rebert
cdb37dce3a Set box-sizing: border-box on .container-viewport in #16142 testcase 
Otherwise, the test doesn't properly fail when the fix is reverted.
 2015-04-27 01:23:39 -07:00
Adrien
37a10d37c1 Compare tooltip right offset to viewport right offset (and not width) 
Closes #16142 by merging it.
 2015-04-27 01:13:16 -07:00
Chris Rebert
fc372952e2 Throw error when tooltip/popover template has multiple top-level elements 
Closes #16219.
 2015-04-25 13:16:53 -07:00
Adrien Siami
e949505b89 Allow viewport option to be a function 
Closes #16151 by merging a rebased version of it that adds docs and 1 more assertion.
 2015-04-21 22:20:15 -07:00
Chris Rebert
c6b62f0cd9 Merge pull request #16147 from Johann-S/event_inserted 
Fixes #16124.
 2015-04-21 21:40:14 -07:00
Niels Steenbeek
7429fc7ff9 Tooltip: Destroy $tip, $arrow, $viewport to avoid memory leak 
Closes #16039.
 2015-04-20 23:29:31 -07:00
Patrick H. Lauke
8549722846 Merge pull request #16226 from patrickhlauke/radio-toggle-kbd-fix 
Fix radio button toggle behavior for keyboard users
 2015-04-17 18:19:11 +02:00
Patrick H. Lauke
66d71136e6 Fix existing radio button unit test 2015-04-11 19:24:21 +02:00
Patrick H. Lauke
1b9baa0d98 Don't preventDefault radio buttons 
as this breaks keyboard navigation for radio button toggles (see
https://github.com/twbs/bootstrap/issues/16223)
 2015-04-11 19:21:55 +02:00
Chris Rebert
b8935a5d0c Use .dropdown-menu instead of ARIA roles for dropdown keydown event handler; fixes #16090 2015-04-08 19:20:15 -07:00
Johann-S
3d71eae301 Add event after template inserted 2015-04-08 13:10:53 +02:00
Adrien Jarthon
5921724d9c fixed IE incompatible CSS 2015-03-29 19:16:59 +02:00
Adrien Jarthon
df96c3e615 Added non-regression test & fixed existing one 2015-03-29 14:59:21 +02:00
Heinrich Fenkart
da63ff2e95 JSCS: Add "disallowSpacesInFunctionDeclaration" 
Valid:

    function a() {}

Invalid:

    function a () {}
 2015-03-26 18:28:17 +01:00
Chris Rebert
6c5e7dfce1 rm redundant aria-hidden usage from Modals; fixes #16020 2015-03-25 18:06:47 -07:00
Adrien Jarthon
0e8e5222ff Tooltip/popover: Fix auto placement to use viewport 
Currently, auto placement is using the container dimensions (if provided) or the element's parent to determine where to open the tooltip:
```javascript
var $container   = this.options.container ? $(this.options.container) : this.$element.parent()
var containerDim = this.getPosition($container)
```
This is quite broken in fact, because the parent element could be just a small div outside the element for example, leading in a totally random placement (placing the tooltip on top even if there's no room). And the container can also be outside of the viewport.

This fix simply uses the viewport instead, that's the purpose of the viewport actually, to position the tooltip.
So the auto placement should use it to find where there's more room.
By default this is body, which is good.
 2015-03-25 18:05:58 +01:00
Chris Rebert
d37bc2ae65 Merge pull request #15987 from twbs/fix-15972 
add role="button" to a[data-toggle="collapse"]
 2015-03-24 08:57:56 -07:00
Emmanuel Bourgerie
fa9d28b634 Fix #16072: Clicking into input field within dropdown no longer closes the dropdown 
Closes #16073 by merging it
 2015-03-21 16:00:15 -07:00
Chris Rebert
9aad9a4164 Merge pull request #16024 from twbs/unnecessary-parsing 
avoid unnecessary HTML string building+parsing
 2015-03-18 22:28:07 -07:00
Chris Rebert
4d652035dc v3.3.2 => v3.3.4 2015-03-16 08:39:31 -07:00
Maxim Andrukhovych
83371735fc Fixed proper navigation element selection on backward scrolling (from the bottom to the top) 2015-03-10 20:04:15 +00:00
Chris Rebert
1383b88328 Merge pull request #16012 from twbs/refs-12761 
Disable jQuery event aliases when running test suite
 2015-03-09 17:47:51 -07:00
Chris Rebert
a14665e73e avoid unnecessary HTML string building+parsing 2015-03-09 06:47:34 -07:00
Chris Rebert
a5243ad3d0 Affix: $('body') => $(document.body) 2015-03-09 06:43:41 -07:00
Chris Rebert
725c6848c3 Disable jQuery event aliases when running test suite 
To ensure that we don't accidentally use any of the aliases.
This should prevent any future regressions from #12761.
Also updates the test suite since it now can't use these aliases either.
 2015-03-09 01:05:43 -07:00
Chris Rebert
21d56378e1 Merge pull request #16011 from twbs/fix-15315 
.collapse('hide') on hidden uninit-ed collapsible no longer shows it
 2015-03-09 01:03:27 -07:00
Chris Rebert
a134491fe5 add togglable scrollbar-inducing content to Modal visual test 2015-03-07 06:40:57 -08:00
Chris Rebert
6ddb8c2dd7 add static navbar to Modal visual test 2015-03-07 06:39:46 -08:00
Chris Rebert
64ca888cbc Merge pull request #15999 from twbs/kkirsche-includeTestsReadme 
Document JS test suite basics
 2015-03-06 23:28:30 -08:00
Kevin Kirsche
ba2f7e92d0 [Fixes #15951] Document JS test suite basics 
X-Ref: #15953
Closes #15952 by merging a tweaked version of it.
[skip sauce]
[skip validator]
 2015-03-06 23:27:00 -08:00
Chris Rebert
5c8d56d515 Collapse unit test: rm check that no-op hide adds style="height: 0px" 
Appears to be unnecessary and is broken by #16011,
which is otherwise quite sane.
 2015-03-06 18:10:53 -08:00
Chris Rebert
872e56fcf2 .collapse('hide') on hidden uninit-ed collapsible no longer shows it; fixes #15315 
Thanks to @peterblazejewicz & @Nikita240
Adds unit tests based on #14417
X-Ref: #14282
Closes #15807
 2015-03-06 06:58:48 -08:00
Chris Rebert
27bbc7dbe9 Hiding an uninitialized tooltip/popover no longer initializes it; fixes #15874 2015-03-03 22:22:13 -08:00
Chris Rebert
cc39f5c52d add role="button" to a[data-toggle="collapse"]; fixes #15972 2015-03-03 13:18:36 -08:00
Chris Rebert
168297c779 rm semicolon for sake of fat's eccentric tastes 
Erratum from #15496
 2015-03-03 13:06:32 -08:00
Heinrich Fenkart
420a8088a4 Merge pull request #15961 from kkirsche/ImplementAssertExpect 
[Fixes #15953] Implement assert.expect in each unit test
 2015-03-03 15:52:05 +01:00
Kevin Kirsche
4febcb4b49 [Fixes #15953] Implement assert.expect in each unit test 
[Fixes #15953] Implement `assert.expect` in each unit test
 2015-03-03 08:45:07 -05:00
Heinrich Fenkart
f5beebe726 Modal: Fix backdrop not readjusting when height changes 
Fixes #15136.
Closes #15345.
Closes #15314.
Refs #14724, #14927.
 2015-03-03 05:27:26 +01:00
Chris Rebert
46f5a8f478 Merge pull request #15970 from twbs/the-future-is-now-qunit 
Disable deprecated QUnit global methods
 2015-03-02 02:39:29 -08:00
XhmikosR
f8e34ff48b Disable es3 for tests and customizer.js. 2015-03-02 11:16:06 +02:00
Chris Rebert
c291c12cb1 Disable deprecated global QUnit method aliases to prevent backsliding on QUnit v2 readiness 2015-03-01 19:50:11 -08:00
Chris Rebert
c80872235f Merge pull request #15955 from twbs/fixture-on-screen-ios 
Unit tests: Only display fixture on-screen for iOS
 2015-03-01 18:28:46 -08:00
Chris Rebert
015e63f6df Merge pull request #15593 from neoeno/handle_multiple_zero_offset_scrollspy_elements 
Handle multiple zero-offset Scrollspy elements.
 2015-03-01 16:04:04 -08:00
Caden Lovelace
a1aa0f8afd Handle multiple zero-offset Scrollspy elements. 
When the first two elements in a scrollspy content block have a document
offset of zero (i.e. they're hard against the top of the page),
Scrollspy would switch between them on every scroll event.

This could happen, for example, in a system of nested sections:

```
<section id="animals">
  <section id="dogs">
	Content
  </section>
</section>
```

This ocurred because Scrollspy's check to see if it's at the end of the
array of sections uses `!arr[index]`. This misses the case where
`arr[index]` does exist and is zero.

This commit explicitly checks the array bounds.
 2015-03-01 23:55:39 +00:00
Heinrich Fenkart
20fb55a840 Unit tests: Only display fixture on-screen for iOS 
Since only on iOS tests fail when the fixture is displayed off-screen, see https://travis-ci.org/twbs/bootstrap/jobs/52605742
 2015-03-01 09:49:59 +01:00
Heinrich Fenkart
4345e24479 Use different way to make failing test more visible in Sauce 2015-03-01 09:20:00 +01:00