Chris Rebert
66c81fe4a1
Port #19220 to v3
...
js/tests/index.html: Replace jQuery event alias methods with functions that throw explanatory errors, instead of with undefined
Refs https://github.com/twbs/bootstrap/pull/19219#issuecomment-184653699
[skip validator]
2016-02-16 14:24:39 -08:00
Patrick H. Lauke
eabdad7208
Visual/manual test for checkbox/radio button kbd behavior
2016-02-16 22:13:55 +00:00
Fabrice Daugan
ad1e98d094
button.js: Fix keyboard navigation
...
This PR fixes the keyboard navigation again while still keeping #16223 fixed.
Closes #19192
2016-02-16 04:38:05 -08:00
Sean Jones
9f2f51073c
enforceFocus event.target - event is undefined
...
event.target should be e.target within enforceFocus method.
2016-01-15 12:13:40 +00:00
Chris Rebert
cf3f8e0d58
Update copyright years to 2016
...
[ci skip]
2016-01-01 12:22:03 -08:00
Chris Rebert
aeb25ba521
Modal: Ignore spurious focus
event that Firefox fires at document
when switching back to its tab
...
Fixes #18365
Ports #18638 to v3
Refs https://bugzilla.mozilla.org/show_bug.cgi?id=1228802
2015-12-22 23:21:51 -07:00
Chris Rebert
50ce63b5e5
Add visual test for #18365
...
See also https://bugzilla.mozilla.org/show_bug.cgi?id=1228802
2015-12-22 23:18:06 -07:00
Chris Rebert
40996725ce
js/tests/unit/modal.js: Fix typo
...
[ci skip]
2015-12-22 17:11:18 -07:00
Mark Otto
910400e897
bump version
2015-11-24 11:07:36 -08:00
Baraa Hamodi
85bc0338d1
Documentation clean up and consistency; closes #17625
...
[skip sauce]
2015-09-28 12:37:35 -07:00
Johann-S
ef1ce9ac0b
Fix triggering of {shown,hidden}.bs.dropdown events so relatedTarget gets set properly
...
Fixes #16828
Closes #16865
2015-07-27 00:58:51 -07:00
Melinda Sarnicki Bernardo
cebea5b6f6
Removes unnecessary period at end of comment
2015-07-02 19:30:11 -07:00
Mark Otto
83bfff7f07
bump version
2015-06-16 09:10:22 -07:00
Patrick H. Lauke
5fd7bc1554
generalize dropdowns / drop role="menu"
...
as role="menu" is a very specific (and strict) ARIA pattern for
desktop-like application menus, and our dropdowns are often used
as pure navigation dropdowns, this change abandons ARIA menus for
a more open-ended and light-weight approach
(see http://heydonworks.com/practical_aria_examples/#submenus and
http://www.w3.org/WAI/tutorials/menus/flyout/#improve-screen-reader-support-using-wai-aria )
note that in dropdown.js, switched to now target ``.dropdown-menu``
instead of ``role["menu"]`` - this also prevents bootstrap scripts
from "bleeding" into non-bootstrap components on the same page.
also removed the ``role=["listbox"]`` part, which appears to be
vestigial/unused (only place in bootstrap that uses that
role are carousels, and their key handling is done separately)
2015-06-02 11:03:21 +01:00
XhmikosR
315907c97c
Use https
when possible.
2015-05-17 12:43:20 +03:00
XhmikosR
1eba173c9e
Update jQuery to v1.11.3.
2015-05-10 01:22:23 +03:00
XhmikosR
a2f81ceb57
phantom.js: switch to unicode characters that work on Windows too.
2015-05-05 06:58:54 +03:00
XhmikosR
49c4556354
Comply to the new JSCS rules.
2015-05-05 06:50:18 +03:00
XhmikosR
93785be2c6
Update JSCS rules.
2015-05-05 06:50:18 +03:00
Chris Rebert
aa2c5b5672
Merge pull request #16014 from redbmk/issue-16008
...
Multiple tooltip triggers don't play well together
2015-05-04 15:07:17 -07:00
Patrick H. Lauke
a254782ca4
Merge pull request #16404 from patrickhlauke/radio-checkbox-kbd-toggle-fix
...
Fix radio and checkbox keyboard handling in .btn-group
2015-05-03 17:05:12 +01:00
Carlo Stearns
0689117f13
Fix issue where affixed element has incorrect positioning
...
when used with a sticky footer layout.
Adds visual test for affix with sticky footer.
Closes #15694 .
Refs #15032 .
2015-05-02 17:59:31 -07:00
Patrick H. Lauke
0c1daaf2ce
Remove broken/vestigial unit test
...
Overall logic for this test appears broken, possibly relating to an
older version of Bootstrap that did not require explicit
`data-toggle="button"` on single toggle buttons?
2015-05-01 12:58:10 +01:00
Patrick H. Lauke
f9cd88e09f
Fix radio and checkbox keyboard handling
...
Fix for problem that emerged from #16226 (`.active` class not actually
being applied) and expansion of the script to also correctly handle
keyboard interaction with checkboxes in `data-toggle="button"` groups
2015-05-01 12:19:19 +01:00
XhmikosR
3e7ca3bbc8
Minor lint tweaks.
2015-04-28 11:03:37 +03:00
Braden M. Kelley
4b269037cb
Multiple tooltip triggers don't play well together
...
Fixes issue #16008
2015-04-27 23:03:56 -07:00
F A T
aa479892d5
Merge pull request #16152 from jarthod/tooltip-placement-viewport-fix
...
Tooltip/popover: Fix auto placement to use viewport
2015-04-27 11:28:54 -07:00
Chris Rebert
cdb37dce3a
Set box-sizing: border-box
on .container-viewport in #16142 testcase
...
Otherwise, the test doesn't properly fail when the fix is reverted.
2015-04-27 01:23:39 -07:00
Adrien
37a10d37c1
Compare tooltip right offset to viewport right offset (and not width)
...
Closes #16142 by merging it.
2015-04-27 01:13:16 -07:00
Chris Rebert
fc372952e2
Throw error when tooltip/popover template has multiple top-level elements
...
Closes #16219 .
2015-04-25 13:16:53 -07:00
Adrien Siami
e949505b89
Allow viewport option to be a function
...
Closes #16151 by merging a rebased version of it that adds docs and 1 more assertion.
2015-04-21 22:20:15 -07:00
Chris Rebert
c6b62f0cd9
Merge pull request #16147 from Johann-S/event_inserted
...
Fixes #16124 .
2015-04-21 21:40:14 -07:00
Niels Steenbeek
7429fc7ff9
Tooltip: Destroy $tip, $arrow, $viewport to avoid memory leak
...
Closes #16039 .
2015-04-20 23:29:31 -07:00
Patrick H. Lauke
8549722846
Merge pull request #16226 from patrickhlauke/radio-toggle-kbd-fix
...
Fix radio button toggle behavior for keyboard users
2015-04-17 18:19:11 +02:00
Patrick H. Lauke
66d71136e6
Fix existing radio button unit test
2015-04-11 19:24:21 +02:00
Patrick H. Lauke
1b9baa0d98
Don't preventDefault radio buttons
...
as this breaks keyboard navigation for radio button toggles (see
https://github.com/twbs/bootstrap/issues/16223 )
2015-04-11 19:21:55 +02:00
Chris Rebert
b8935a5d0c
Use .dropdown-menu instead of ARIA roles for dropdown keydown event handler; fixes #16090
2015-04-08 19:20:15 -07:00
Johann-S
3d71eae301
Add event after template inserted
2015-04-08 13:10:53 +02:00
Adrien Jarthon
5921724d9c
fixed IE incompatible CSS
2015-03-29 19:16:59 +02:00
Adrien Jarthon
df96c3e615
Added non-regression test & fixed existing one
2015-03-29 14:59:21 +02:00
Heinrich Fenkart
da63ff2e95
JSCS: Add "disallowSpacesInFunctionDeclaration"
...
Valid:
function a() {}
Invalid:
function a () {}
2015-03-26 18:28:17 +01:00
Chris Rebert
6c5e7dfce1
rm redundant aria-hidden usage from Modals; fixes #16020
2015-03-25 18:06:47 -07:00
Adrien Jarthon
0e8e5222ff
Tooltip/popover: Fix auto placement to use viewport
...
Currently, auto placement is using the container dimensions (if provided) or the element's parent to determine where to open the tooltip:
```javascript
var $container = this.options.container ? $(this.options.container) : this.$element.parent()
var containerDim = this.getPosition($container)
```
This is quite broken in fact, because the parent element could be just a small div outside the element for example, leading in a totally random placement (placing the tooltip on top even if there's no room). And the container can also be outside of the viewport.
This fix simply uses the viewport instead, that's the purpose of the viewport actually, to position the tooltip.
So the auto placement should use it to find where there's more room.
By default this is body, which is good.
2015-03-25 18:05:58 +01:00
Chris Rebert
d37bc2ae65
Merge pull request #15987 from twbs/fix-15972
...
add role="button" to a[data-toggle="collapse"]
2015-03-24 08:57:56 -07:00
Emmanuel Bourgerie
fa9d28b634
Fix #16072 : Clicking into input field within dropdown no longer closes the dropdown
...
Closes #16073 by merging it
2015-03-21 16:00:15 -07:00
Chris Rebert
9aad9a4164
Merge pull request #16024 from twbs/unnecessary-parsing
...
avoid unnecessary HTML string building+parsing
2015-03-18 22:28:07 -07:00
Chris Rebert
4d652035dc
v3.3.2 => v3.3.4
2015-03-16 08:39:31 -07:00
Maxim Andrukhovych
83371735fc
Fixed proper navigation element selection on backward scrolling (from the bottom to the top)
2015-03-10 20:04:15 +00:00
Chris Rebert
1383b88328
Merge pull request #16012 from twbs/refs-12761
...
Disable jQuery event aliases when running test suite
2015-03-09 17:47:51 -07:00
Chris Rebert
a14665e73e
avoid unnecessary HTML string building+parsing
2015-03-09 06:47:34 -07:00