GeoSot
28c9002573
Modal: handle click event from backdrop callback
2022-01-30 15:39:34 +02:00
XhmikosR
62d86c07f8
Rename variables
2022-01-29 13:25:30 +02:00
XhmikosR
0c3dfe104b
Remove a few unneeded variables
2022-01-29 13:25:30 +02:00
Phil E. Taylor
c2db7108c2
Fix typo in comment ( #35564 )
...
s/moddal/modal
2021-12-18 07:58:31 +02:00
GeoSot
886b940796
Extract Component config functionality to a separate class ( #33872 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-12-10 18:18:18 +02:00
GeoSot
91ad255e07
Change adjustDialog's if conditions to improve readability
2021-11-25 19:23:49 +02:00
GeoSot
0f9fd75d6c
Respect modal's initial overflowY
2021-11-25 19:23:49 +02:00
GeoSot
cc3e5789ec
Remove some uncovered code that seems to be unused
2021-11-25 19:23:49 +02:00
GeoSot
92e664c921
Change check for dynamic modal
2021-11-25 19:23:49 +02:00
GeoSot
fc33ce4b46
Tweak methods
...
Name them to be more descriptive and have agnostic functionality
2021-11-25 19:23:49 +02:00
GeoSot
79e01c3bad
Some refactoring on modal, to improve readability and generic functionality
2021-11-25 19:23:49 +02:00
XhmikosR
e8f702666f
JS: minor refactoring ( #35183 )
...
* add missing comments
* shorten block comments
* reorder constants
* reorder public/private methods
* sort exports alphabetically in util/index.js
* fix a couple of typos
2021-10-13 15:19:28 +03:00
XhmikosR
c44d64ed71
Merge remote-tracking branch 'remotes/origin/v513'
2021-10-09 18:28:28 +03:00
XhmikosR
1a6fdfae6b
Bump version to 5.1.3.
2021-10-09 09:43:19 +03:00
XhmikosR
666fe596bf
Enable unicorn/no-array-for-each
rule
2021-10-05 19:52:11 +03:00
XhmikosR
5ecef8ac01
Release v5.1.2 ( #35114 )
2021-10-05 18:50:18 +03:00
XhmikosR
0d81d3cbc1
Release v5.1.1 ( #34869 )
...
* Prepare v5.1.1.
* Dist
2021-09-07 18:37:44 +03:00
GeoSot
1e5e655670
Fix modal when is triggered by bs-toggle
, to hide other open instances ( #34701 )
2021-08-10 17:55:34 +03:00
XhmikosR
f20fece3a8
Prepare v5.1.0. ( #34674 )
2021-08-04 18:41:51 +03:00
XhmikosR
6d707f4801
Enable a few eslint-config-xo rules ( #34620 )
...
* unicorn/prefer-dom-node-append
* unicorn/prefer-dom-node-remove
2021-07-30 00:23:00 +02:00
GeoSot
4bfd8a2cbc
Use a streamlined way to trigger component dismiss ( #34170 )
...
* use a streamlined way to trigger component dismiss
* add documentation
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-07-28 17:39:32 +03:00
Ryan Berliner
7646f6bd33
Add shift-tab keyboard support for dialogs (modal & Offcanvas components) ( #33865 )
...
* consolidate dialog focus trap logic
* add shift-tab support to focustrap
* remove redundant null check of trap element
Co-authored-by: GeoSot <geo.sotis@gmail.com>
* remove area support forom focusableChildren
* fix no expectations warning in focustrap tests
Co-authored-by: GeoSot <geo.sotis@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-07-27 08:01:04 +03:00
GeoSot
dfafb9a60c
modal: change data-dismiss
so that it can be outside of a modal using bs-target
( #33403 )
...
* change data-dismiss, so can be outside modal, using a bs-target
* Update site/content/docs/5.0/components/modal.md
Co-authored-by: Gaël Poupard <ffoodd@users.noreply.github.com>
2021-07-19 16:56:05 +03:00
XhmikosR
688bce4fa6
Release v5.0.2 ( #34276 )
...
* Bump version to v5.0.2.
* Dist
2021-06-22 21:29:16 +03:00
GeoSot
cb47b8c964
Refactor scrollbar.js to be used as a Class ( #33947 )
2021-06-06 09:26:36 +03:00
GeoSot
c98657b830
Add getOrCreateInstance
method in base-component ( #33276 )
...
Co-authored-by: Rohit Sharma <rohit2sharma95@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-06-03 18:53:27 +03:00
alpadev
4a5029ea29
Fix handling of transitionend events dispatched by nested elements( #33845 )
...
Fix handling of transitionend events dispatched by nested elements
Properly handle events from nested elements
Change `emulateTransitionEnd` to `executeAfterTransition` &&
2021-06-03 14:44:16 +03:00
alpadev
b513a19003
Fix prevented show event disables modals with fade class from being displayed again ( #34085 )
...
Fix modal, in case is faded, a prevented show event can cause show method to not be executed again.
2021-05-24 18:52:36 +03:00
GeoSot
2757fbe28e
Reset inside a Dialog does not work if data-dismiss="modal"
is set ( #33928 )
2021-05-18 09:26:22 +03:00
XhmikosR
58b1be927f
Release v5.0.1 ( #33972 )
...
* Bump version to 5.0.1.
* Dist
2021-05-13 19:22:20 +03:00
GeoSot
9fe36edf68
Extract static DATA_KEY
& EVENT_KEY
to base-component ( #33635 )
...
* Force each plugin that extends base-components to implement a static method `NAME()`
* Remove redundant `NAME` argument from 'Utils.defineJQueryPlugin' & fix test
2021-05-11 10:49:30 +03:00
GeoSot
03842b5f25
Refactor: move disposing properties into the base class ( #33740 )
...
Moves more functionality to `base-component`, transferring the responsibility of disposal to parent class.
Each component, dusting disposal, sets its protected properties to `null`. So the same can be done in one place for all children components .
2021-05-11 09:04:42 +03:00
GeoSot
90b1a6907e
Merge js-components 'transitionend' listener callbacks into one method
2021-05-10 13:59:55 -07:00
XhmikosR
bf09367486
Release v5.0.0 ( #33647 )
...
* Bump version to 5.0.0
* Fix npm tag
* Dist
2021-05-05 22:32:12 +03:00
GeoSot
80085a12f6
Decouple BackDrop from modal ( #32439 )
...
* Create backdrop.js util
* revert breaking changes
remove PromiseTimout usage
revert class name
* one more test | change bundlewatch.config
* add config obj to backdrop helper | tests for rootElement | use transitionend helper
* Minor tweaks — Renaming
Co-authored-by: Rohit Sharma <rohit2sharma95@gmail.com>
2021-04-14 13:28:50 -07:00
GeoSot
566451230f
Remove element event listeners through base component ( #33429 )
...
After some research, I found out that EventHandler saves all the custom events per element using namespace, and is capable of removing handlers using only the element and its namespace (`DATA_KEY`).
So, probably is better to utilize the base-component to do the same job.
2021-04-11 09:54:48 +03:00
GeoSot
7b7f4a5ced
Decouple Modal's scrollbar functionality ( #33245 )
2021-04-11 09:37:59 +03:00
GeoSot
317c2cd08e
Omit getting data-attributes from toggle element
2021-04-06 18:43:43 +03:00
GeoSot
752b001b0a
Simplify Modal config
2021-04-06 18:43:43 +03:00
Rohit Sharma
5cc53a0ef0
Use template literals instead of concatenation ( #33497 )
2021-03-30 08:57:05 +03:00
XhmikosR
220139a89f
Release v5.0.0-beta3 ( #33439 )
2021-03-23 18:26:54 +02:00
GeoSot
e163d98845
modal: move common code to a new isAnimated
method ( #33056 )
2021-03-08 18:35:59 +02:00
alpadev
48a95f7280
refactor: use a Map instead of an Object in dom/data ( #32180 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Rohit Sharma <rohit2sharma95@gmail.com>
2021-03-02 16:55:44 +02:00
Muhammadamin
056216a3bd
modal: don't add margin & padding when sticky is not full width ( #30621 )
...
* modal: don't add margin & padding when sticky is not full width
* Check if element is shorter than window
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Rohit Sharma <rohit2sharma95@gmail.com>
2021-02-23 14:52:09 +02:00
Rohit Sharma
dc5e3328c1
Allow constructors to accept a CSS selector ( #32245 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <otto@github.com>
2021-02-22 09:01:04 +02:00
XhmikosR
92434fa30f
util: change isRTL
to a function ( #32446 )
...
This allows the bundler to tree-shake the function.
2021-02-16 10:14:05 +02:00
XhmikosR
e50c11b8c6
Release v5.0.0-beta2 ( #32467 )
...
* Bump version to 5.0.0-beta2
* Dist
2021-02-10 18:14:51 +02:00
GeoSot
b5bf3131fb
modal: move common code to reusable functions ( #32511 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-14 21:22:09 +02:00
Rohit Sharma
e34481b6eb
Fix toggling modal when clicking on data-bs-toggle="modal"
( #32691 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-13 21:59:47 +02:00
XhmikosR
1edec546cb
Remove TRANSITION_END
from utils ( #32394 )
2020-12-10 16:54:50 +02:00