Pierre-Denis Vanduynslager
c80e13a48a
Use existing keycode constants in dropdown. ( #21697 )
2017-01-15 13:42:24 +11:00
Pierre-Denis Vanduynslager
4c2f544359
Merge branch 'twbs/v4-dev' into dropdown-keyboard
2017-01-06 15:57:15 -05:00
Mark Otto
045888fa38
version bump
2017-01-06 08:38:04 -08:00
Patrick H. Lauke
85a1fdcb29
Merge pull request #21093 from Johann-S/fixButtonGrpAria
...
Close #21090 - Fix aria-pressed attribute for buttons in container with data-attribute="buttons"
2017-01-05 09:35:43 +00:00
Pierre-Denis Vanduynslager
d1b742f228
Use pageYOffset instead of scrollY
2017-01-04 11:42:08 -08:00
Pierre-Denis Vanduynslager
67958f35e8
Merge conflict
2017-01-04 12:24:33 -05:00
Pierre-Denis Vanduynslager
c4867cfedb
Merge branch 'twbs/v4-dev' into dropdown-keyboard
...
# Conflicts:
# js/src/dropdown.js
2017-01-04 12:22:06 -05:00
Johann-S
0463b01282
Close #21090 - Fix aria-pressed attribute for buttons in container with data-toggle='buttons'
2017-01-04 11:02:16 +01:00
Pierre-Denis Vanduynslager
bbb0d2b573
Dropdown: close menu when focusing outside element ( #21375 )
...
* Close dropdown menu when focusing an outside element
* Update unit test to new markup
2017-01-02 14:44:27 -08:00
Mark Otto
c61a0059ad
update seletors in js
2017-01-02 11:52:38 -08:00
Johann-S
026e1a1421
Allow to use nav with tab JS
2016-12-31 00:54:00 -08:00
Pierre-Denis Vanduynslager
425d156df2
Merge branch 'twbs/v4-dev' into dropdown-keyboard
2016-12-28 19:57:38 -05:00
Max Beatty
aa7f95fd77
update click state when hiding so can be shown again by trigger. fixes #16732
2016-12-27 14:19:12 -08:00
Alessandro Rodi
9103bffe37
[ Fix #19849 ] Tabs are opened even if disabled. ( #20795 )
...
* [Fix #19849 ] Tabs are opened even if disabled.
* fix hund code review hints
* rollback hound issues because Travis fails
2016-12-24 23:31:34 -08:00
Johann-S
b0508a975d
Closes : #21412 : Fix unit test for carousel
2016-12-23 22:56:55 +11:00
Matheus Azzi
dab6a41e04
Carousel: Only prevents default for ARROW_LEFT and ARROW_RIGHT keys
...
Fixes 2 bugs:
1. All keydowns were being prevented. Because of that the user wasn't able to navigate in the whole page using ARROW_UP/ARROW_DOWN.
2. Even when is an input or textarea the keydowns were being prevented. Because of that the user wasn't able to type any text on these elements.
2016-12-23 17:55:40 +11:00
mr-july
1d6cdb65b3
scrollspy: fix wrong activation of all nested links ( #20304 )
...
* fix wrong activation of all nested links;
just first level item should be activated
* use template instead of string concatenation
2016-12-22 22:00:56 -08:00
Mark Otto
1f9619a517
Merge branch 'patch-1' of https://github.com/tracker1/bootstrap into tracker1-patch-1
2016-12-21 20:34:29 -08:00
Starsam80
d991c868a4
Fix tabs by using new classes
2016-12-07 21:20:18 -07:00
Starsam80
bf39bb3ac3
Rename .active
to .show
2016-12-07 21:20:15 -07:00
Mark Otto
1afb6959fa
remove commented out code
2016-12-04 21:05:57 -08:00
Mark Otto
1e3ec89355
Merge branch 'v4-dev' into carousel
2016-12-04 21:05:19 -08:00
Mark Otto
01f81dd552
fix js for previous
2016-12-04 20:27:21 -08:00
Mark Otto
94e2d80af4
pull in js changes from #18830
2016-12-04 19:53:16 -08:00
Johann
297c47c3fd
[V4] Throw error when a plugin is in transition ( #17823 )
...
* Throw error when a plugin is in transition
* Add unit tests about plugins in transition
2016-12-02 09:52:19 -08:00
Bardi Harborow
535fec93cf
Hide popovers when their containing modal is closed. ( #21227 )
2016-11-29 09:45:14 -08:00
Juno_okyo
8c17e5fb3c
Use multi-selector to remove the same event handler ( #20642 )
2016-11-28 13:42:32 -08:00
Mark Otto
82875586c1
Merge branch 'v4-js-carousel' of https://github.com/J2TeaM/bootstrap into J2TeaM-v4-js-carousel
2016-11-28 13:39:56 -08:00
Rob Ruana
5eddb0b0fd
Closes #21055 : Prevents ScrollSpy from clearing active item when Safari rubberbands ( #21056 )
...
When the rubberband effect causes Safari to scroll past the top of the
page, the value of scrollTop becomes negative. If the offset of the first
ScrollSpy target is 0 - essentially if the target is at the top of the
page - then ScrollSpy should not clear the active item. Conceptually, the
first item should remain active when rubberbanding past the top of the
page.
This commit fixes issue #21055 by verifying the first scrollspy target is
not at the top of the page before clearing the active nav-item.
2016-11-27 16:20:33 -08:00
Mark Otto
87a0749f89
Merge branch 'container-tooltip-option' into v4-dev
2016-11-26 17:02:40 -08:00
Mark Otto
b6b8280938
Merge pull request #18900 from vlastikcz/v4-dev-buttonChange
...
Button toggling - trigger change event on input. Fixes #16673 , fixes #17599 .
2016-11-26 01:18:21 -08:00
Mark Otto
ce31f54c36
Merge pull request #19058 from Johann-S/carouselInput
...
Carousel - Do not prevent on keydown for input and textarea
2016-11-26 01:14:55 -08:00
Mark Otto
b110070dcd
Follow up fix to #19953 for linting error in builds
...
See https://travis-ci.org/twbs/bootstrap/jobs/179010884 for build failure
2016-11-26 01:04:02 -08:00
Mark Otto
25d218b02d
Merge branch 'v4-dev-18796' of https://github.com/maxbeatty/bootstrap into maxbeatty-v4-dev-18796
2016-11-26 00:58:51 -08:00
Pierre-Denis Vanduynslager
3606c5b9c5
Dropdown perf - on keyboard nav, find active item in the active dropdown rather than the whole document ( #19953 )
2016-11-26 00:35:49 -08:00
andyexeter
0ded703f6b
Implement container option for tooltips and popovers.
2016-11-26 19:13:15 +11:00
matus
39d7861f34
Scrollspy selecting the last element when at the bottom of the page ( fixes #17739 )
2016-11-25 17:38:42 -08:00
Mark Otto
432fe74c31
Merge branch 'eslint' of https://github.com/bardiharborow/bootstrap into bardiharborow-eslint
2016-11-25 14:59:28 -08:00
Matt Hernandez
b1b1f30cbd
[ Fix #17371 ][V4] Deactivating dropdown links in nav tab ( #17642 )
...
* Fix bug with dropdown tab links not deactivating when other tab or dropdown link is clicked
* Revise bug fix for more stability
2016-11-25 14:56:41 -08:00
Bardi Harborow
c2616fb74e
Make JS compliant with the new ESLint rules.
2016-11-24 11:59:55 +11:00
Johann
a7f1b59959
Making .tooltip('show') throw an error on elements with display:none ( #20940 )
2016-10-31 20:33:53 -07:00
Bardi Harborow
0974267b8c
Move from $.proxy to es6 arrow functions. ( #21049 )
2016-10-31 20:32:36 -07:00
Ilias
bf43936377
Fix #17964 ( #17997 )
...
* Fix #17964
Some browsers are lazy when updating dom elements after transition effects. This can be fixed by reading element properties such as offsetHeight or offsetWidth. However, creating a function using the Function constructor just to access such element, results in a violation of Content Security Policy (where applied), which in turn crashes the application. This fix actually reverts to the way this was handled in v3 and should work as intended.
2016-10-30 14:47:14 -07:00
Johann-S
9d129a43d6
Use a single class name for opened/expanded/shown state of widgets
2016-10-25 14:07:41 +02:00
Mark Otto
73154d0392
Merge pull request #20467 from maxbeatty/v4-dev-17754
...
add support for ol in tab plugin
2016-10-24 20:50:52 -07:00
Mark Otto
60e51bc918
Merge pull request #18847 from Johann-S/fix18824
...
Fix bug multiple accordions collapse
2016-10-24 20:50:04 -07:00
Mark Otto
8ff7edaab4
version bump to alpha 5
2016-10-19 08:27:41 -07:00
Johann-S
9bc7de9395
Fix bug multiple accordions collapse
2016-10-19 09:35:48 +02:00
Johann-S
de1255b14e
Collapse using card component
2016-10-11 13:25:36 +02:00
Mark Otto
259fa88e3e
Merge pull request #17614 from Johann-S/patchTooltip
...
[Fix #17611 ][V4] Change destroy to dispose for tooltip in _JQueryInterface
2016-10-10 13:03:28 -07:00
Mark Otto
4d725c90d6
Merge pull request #17568 from Johann-S/fixCollapseHeight
...
[Fix #17555 ][V4] fix resetting style on closing collapse
2016-10-09 20:32:40 -07:00
Mark Otto
e7f79b32f2
Merge branch 'tooltip-arrow' of https://github.com/brnrdog/bootstrap into brnrdog-tooltip-arrow
2016-10-09 19:56:30 -07:00
Bardi Harborow
2e69dfa8c1
Fix broken/redirected links, moving to HTTPS where possible. ( #20557 )
2016-10-03 09:55:59 -07:00
J2TeaM
4f520c7ff3
Merge #20563 and #20567
2016-09-07 10:09:54 +07:00
J2TeaM
4f5a7c96e7
Fix eslint (prefer-template)
2016-09-07 03:17:19 +07:00
J2TeaM
edc43a4ea6
Remove classes at one time
2016-09-07 02:55:48 +07:00
Mark Otto
5495a4b3d3
versions
2016-09-05 12:41:44 -07:00
Max Beatty
dc1b4e78d4
add support for ol in tab plugin. fixes #17754
2016-08-04 16:57:08 -07:00
Max Beatty
bfa714ae1e
prevent navigating to area href when modal target. fixes #18796
2016-08-04 13:47:30 -07:00
Mark Otto
24e992a6ff
bump versions
2016-07-27 09:31:24 -07:00
Chris Rebert
c955868982
Enable more rules from ESLint 2.0; refs #19999 ( #20076 )
...
[skip sauce]
[skip validator]
2016-06-05 11:17:05 -07:00
Chris Rebert
2b16f5c510
Update ESLint to v2.5.3 ( #20043 )
...
Refs #19908 .
[skip sauce]
[skip validator]
2016-06-04 14:28:34 -07:00
Chris Rebert
5dcd1a743d
Tweak Esc key comment in modal.js
...
[skip sauce]
[skip validator]
2016-05-31 02:19:56 -07:00
Chris Rebert
c4add0c2f3
Comply with consistent-return ESLint rule
2016-05-31 00:45:32 -07:00
Chris Rebert
5a35ad6d74
Use named constants for magic numbers ( #19992 )
...
Mostly KeyboardEvent.which and MouseEvent.which values.
[skip validator]
2016-05-30 23:42:00 -07:00
Pierre-Denis Vanduynslager
ab2fc63d08
Dropdown: remove dependency to role="menu", role="listbox" a and li elements => fix keyboard navigation
2016-05-22 02:16:27 -04:00
akai
4d1b9d7ce7
Remove stray "~" in modal paddingRight value ( #19932 )
...
[skip validator]
2016-05-18 13:53:01 -07:00
Patrick H. Lauke
b107e3342a
Handle aria-hidden on modal container when showing/hiding
...
Fixes #19878
2016-05-11 02:01:56 +01:00
Chris Rebert
afdd62d161
Modal: Remove IE8-specific window.innerWidth workaround
...
[skip validator]
2016-04-21 01:15:24 -07:00
Michael J. Ryan
681d390a05
Update tooltip.js
...
match project's style check
2016-03-14 13:29:03 -07:00
Michael J. Ryan
1a23279237
Update tooltip.js
...
Don't reference `Tether` via attachment to `window`, with the update one can import bootstrap providing the dependencies in webpack with:
```
new webpack.ProvidePlugin({
$: 'jquery',
jQuery: 'jquery',
Tether: 'tether',
});
```
Then inside one's own bootstrap/globals, `import 'bootstrap';` will simply work, and $/jQuery can be used from there.
I had wanted to do this, but also expose jQuery, Tether, etc when in development build in my code, but if I provide `window.Tether`, I can't then expose it to the outside...
2016-03-14 13:18:08 -07:00
Patrick H. Lauke
701b12bf58
Replace jQuery with vanilla JS
2016-02-17 15:21:02 +00:00
Patrick H. Lauke
a496cb8be4
Focus (visually hidden) input radio/checkbox
...
This allows for keyboard navigation (e.g. arrow keys left/right to
trigger different radio buttons) following an initial mouse click
interaction
2016-02-16 14:29:59 +00:00
Johann-S
14ec4fdfc1
Carousel - Do not prevent on keydown for input and textarea
2016-02-01 00:06:07 +01:00
Chris Rebert
f2d77b674c
scrollspy.js: Avoid gratuitous non-ASCII for consistency+compatibility
...
Fixes #19028
[skip sauce]
[skip validator]
2016-01-26 11:58:40 -08:00
Kotas Vlastimil
866e99b00c
Button toggling - trigger change event on input
...
Bootstrap’s .button styles can be applied to other elements, such as labels, to provide checkbox or radio style button toggling.
When the checkbox or radio state is changed, there should be triggered the change event. Currently, the change event is triggered on the Button, which is not correct. Only input fields do support the change event.
2016-01-14 20:26:32 +01:00
Chris Rebert
ad4c0ee52f
Exempt getUID() from ESLint's no-bitwise rule
...
[skip sauce]
[skip validator]
2015-12-24 18:53:08 -07:00
Chris Rebert
74f1d3b9b8
Merge pull request #18393 from twbs/dropdown-bitwise-less-tricksy
...
dropdown.js: Use more straightforward phrasing for index bound check
2015-12-24 08:16:19 -07:00
Chris Rebert
d12ed5520e
Modal: Ignore spurious focus
event that Firefox fires at document
when switching back to its tab
...
Fixes #18365
Refs https://bugzilla.mozilla.org/show_bug.cgi?id=1228802
2015-12-22 23:08:03 -07:00
Chris Rebert
31d4139a74
Update version numbers using npm script
...
Errata from:
* 8ce5da3026
* 5d3144e8fb
which missed a few numbers.
[skip sauce]
[skip validator]
2015-12-08 18:16:47 -08:00
Mark Otto
5d3144e8fb
manually bump versions because npm script wasn't working for me
2015-12-08 09:36:08 -08:00
Chris Rebert
75c39f9138
Fix version numbers is JS files; fixes #18435
...
[skip sauce]
[skip validator]
2015-12-05 02:19:46 -08:00
XhmikosR
92d0a71fb6
Merge pull request #18391 from twbs/double-bitwise-not-comment
...
util.js: Add comment explaining ~~ trick
2015-12-05 10:37:27 +02:00
XhmikosR
79a4273891
Tweak ESLint rules.
2015-12-03 08:41:46 +02:00
Chris Rebert
31ca64232d
dropdown.js: Use more straightforward phrasing for index lower bound check
...
[skip sauce]
[skip validator]
2015-11-30 23:59:39 -08:00
Chris Rebert
a887a1207c
util.js: Add comment explaining ~~ trick
...
[skip sauce]
[skip validator]
2015-11-30 23:47:56 -08:00
Jacob Thornton
ece98f980c
add undefined for now
2015-11-14 20:43:45 -08:00
Jacob Thornton
d600831a15
add explicit error for lack of tether in tooltips - fixes #17273
2015-11-14 20:35:10 -08:00
Jacob Thornton
186c1c6d80
Merge branch 'v4-dev' of https://github.com/lincolndbryant/bootstrap into lincolndbryant-v4-dev
2015-11-14 19:49:48 -08:00
Jon Tewksbury
2d87ec9a64
Add eslint no-undef rule and resolve errors
2015-11-03 15:04:26 -08:00
Johann-S
817d997b75
Use Page Visibility API in Carousel; fixes #17706
...
Avoids cycling carousels when the page isn't visible.
Closes #17710
Refs #15566
2015-10-11 15:10:49 -07:00
Johann-S
21a65f181e
Add throw error for undefined method on plugins
2015-10-02 10:01:24 +02:00
Johann-S
6d451ad99d
Change destroy -> dispose
2015-09-16 09:46:55 +02:00
Johann-S
32f9a5d6a5
fix resetting style on closing collapse
2015-09-11 10:45:08 +02:00
muzige2000
3af4560c67
Modals: Fix bad paddingRight calculation; fixes #17399
...
We want to sum two numbers, not concatenate their stringifications.
Closes #17457 by merging a tweaked version of it.
2015-09-03 01:25:38 -07:00
Gleb Mazovetskiy
c7d8e7a077
Accept elements as the tooltip / popover content
...
When a DOM node is passed to an HTML tooltip, the `title` node is only
moved if it is not already in the tooltip. Otherwise, `empty()` is used
instead of `detach()` before appending the `title` to avoid memory
leaks. If a DOM node is passed to a plain text tooltip, its text is
copied via jQuery `.text()`.
Replaces `.detach()` with `.empty()`, as `.detach()` is almost never
useful but instead leaks memory. The difference between `empty` and
`detach` is that the latter keeps all the attached jQuery events/data.
However, since we do not return the previous children, the user would
have to keep these themselves, thus they can `detach()` if necessary.
This is a port of https://github.com/twbs/bootstrap/pull/14552 to v4.
2015-08-31 01:06:13 +01:00
Bernardo Gurgel Filho
8ef66df6d7
Convert popover's arrows to generated CSS content via :before/:after
2015-08-26 17:20:01 -03:00
Bernardo Gurgel Filho
2ae5fdf9dd
Convert tooltip's arrows to generated CSS content via :before
2015-08-26 17:20:01 -03:00
Jelle Versele
54c4eb950b
fixes #17097 : Go back to using jQuery's text and html methods since innerText is nonstandard and not present in Firefox
...
Closes #17272 by merging a tweaked version of it.
[skip validator]
2015-08-26 01:00:46 -07:00
lbryant
8b15b5a262
_removeTetherClasses is no longer referenced
2015-08-20 01:22:16 -04:00
lbryant
926fb11158
use Tether addTargetClasses: false option instead of manually removing them
2015-08-20 01:03:29 -04:00
Jacob Thornton
03e732708c
rewrite tab with new active shit
2015-08-18 22:03:34 -07:00
Jacob Thornton
4e45e2363c
Merge branch 'v4' of github.com:twbs/derpstrap into v4
2015-08-18 21:23:53 -07:00
Jacob Thornton
fd65b9f32e
some minor alert shit
2015-08-18 20:33:57 -07:00
Jacob Thornton
18ff57a183
js tests passing + eslint
2015-08-18 19:22:46 -07:00
Jacob Thornton
19e43b62ed
use proxy not bind in alert
2015-08-18 17:01:56 -07:00
Jacob Thornton
05c7a37507
fix dropdown test
2015-08-15 12:17:13 -07:00
Jacob Thornton
c830956d17
change modal.js to use is-fixed classes to target padding-right
2015-08-15 12:10:24 -07:00
Jacob Thornton
11abb0f7e9
fix modal
2015-08-12 21:12:03 -07:00
fat
6b2b0ed32f
al tests passing, dist rebuilt, w/typechecker
2015-05-13 14:52:46 -07:00
fat
eaab1def7a
add simple type checker implementation
2015-05-13 14:46:50 -07:00
fat
b0d142334f
fix #15301
2015-05-13 13:43:56 -07:00
fat
7ef0e52fd0
add "focus" option for turning off modal focusing #16050
2015-05-13 13:22:26 -07:00
fat
da495ee24c
address https://github.com/twbs/bootstrap/pull/16135
2015-05-13 13:15:11 -07:00
fat
f8b2569ec8
implement global dispose method
2015-05-13 12:48:34 -07:00
fat
ab1578465a
grunt test-js, grunt dist-js now working
2015-05-12 16:52:54 -07:00
fat
a58febf71a
popover passing as well
2015-05-12 14:35:00 -07:00
fat
3452e8dc83
rewritten tooltip + tether integration and death to our positioner jank
2015-05-11 23:32:37 -07:00
fat
8eee78ca15
tab es6
2015-05-11 12:29:06 -07:00
fat
2d91494d96
scrollspy es6
2015-05-11 12:05:35 -07:00
fat
ca9c850ebb
add getters for Version and Default where applicable
...
add modal my gawd
2015-05-10 19:45:38 -07:00
fat
bbb97a8660
add dropdown
2015-05-10 13:47:11 -07:00
fat
8bab38bb71
add collapse
2015-05-09 23:04:58 -07:00
fat
1b183e2ff7
carousel -> es6
2015-05-07 22:26:40 -07:00
fat
6605051882
button -> es6
2015-05-07 17:14:38 -07:00
fat
c3a79b1a8c
change the export pattern to protect against leaking globals
2015-05-07 16:34:28 -07:00
fat
0724bd91ff
es6 alert :|
2015-05-07 12:57:31 -07:00