0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-12 00:08:59 +01:00
Commit Graph

64 Commits

Author SHA1 Message Date
domq
616ce9b75a Fix double-transition bug (#26452)
By applying the transition: CSS property only to classes that are
active during sliding, we avoid an unnecessary, non-zero-time
animation that although mostly invisible, does interfere with e.g.
z-index based parallax
2018-05-18 18:59:52 +03:00
Varunram
4bc5cc149a Closes #26300: Add cursor pointer to carousel indicators 2018-04-23 21:55:45 -07:00
Tom Swirly
a0c7473a34 Tiny grammar and punctuation tweaks to a comment.
1. It's == "it is"

2. The subject of the sentence is "Only one" (not "these") so the verb must agree with it.

Feel free to do nothing with this change, use it, etc - I just saw this while reading through the code.
2018-04-01 23:08:58 +03:00
Jacob Müller
27f553c965 Replace "loose" HEX values with their respective variables (#25672) 2018-03-12 19:19:37 +02:00
Mark Otto
663057d441
Feature: Add carousel fade option (#22958)
* Move helpful code comments

* Add .carousel-fade option to Sass

* Document example of the fade carousel

* more logical warning of the .active class on carousel items
2018-01-21 22:51:08 -08:00
XhmikosR
29d58fb758 Enable stylelint's function-comma-space-after. (#24501)
The option is set to `always-single-line` in stylelint-config-standard which we extend.
2017-10-23 00:00:00 +03:00
Mark Otto
06641ca0b3 Gradients and shadows (#24429)
* Update the form focus mixin to use a manual `$enable-shadows` check so we can always ensure a focus state for accessibility and consistency

* - Add new `$input-btn-focus-width` and `$input-btn-focus-color` variables.

- Replace separate `$btn-focus-box-shadow` and `$input-focus-box-shadow`
variables with unified `$input-btn-focus-box-shadow` to match our
combined variables approach elsewhere.

* Put new focus width var to use in buttons mixins

* use new button input-box shadow var

* Add a new mixin for quickly adding linear gradient to components when $enable-gradients is set to true

* use correct var

* fix focus shadows in button mixins

* Add opt-in gradients to alerts, buttons, carousel, custom radios and checkboxes, custom file input, and dropdown items

* Generate .bg-gradient- utilities

* add headings to colors page and document bg-gradient utils

* update the button color for active status, check with yiq as it's done for basic state and hover state
2017-10-19 09:03:33 -07:00
Mark Otto
2bf4de0698 Update carousel display settings
Use `display: block` since we're not really using any flex styles on the `.carousel-items` (only their controls and indicators). For the indicators, since moving to `width`, our indicators grow to fill available space, so we need to change `flex: 1 0 auto` to `flex: 0 1 auto` to prevent that.
2017-07-01 16:59:16 -07:00
Mark Otto
75156f419a using max-width in flex: 1 0 auto; in ie11 offsets the center-aligned contents 2017-07-01 11:21:20 -07:00
Mark Otto
2d4534e112 use @supports to apply transform3d to those who can do it, then provide a non-3d fallback to ie11 2017-07-01 11:21:20 -07:00
Mark Otto
0c59741812 property order 2017-04-08 16:29:21 -07:00
Pierre-Denis Vanduynslager
73cfefd594 Do not stretch images in carousel-item 2017-04-08 16:29:21 -07:00
Mark Otto
ab67ffe167 Ensure carousel works in IE10/11
- Drops the `if-supports-3d-transforms()` mixin since all our browsers do support it

- Updates carousel to not rely on that mixin
2017-04-08 16:29:21 -07:00
Mark Otto
02e0fdbd52 Remove cursor: pointer; (#21812)
* Remove most of custom cursor: pointer; implementations

* turns out that's not so much of a thing
2017-01-23 22:15:28 -08:00
Quy
28072f153c Update carousel comments (#21501) 2017-01-01 12:00:17 -08:00
Mark Otto
736be8fca6 linting 2016-12-22 14:58:40 -08:00
Mark Otto
135b65ded4 text-align doesn't apply here, so we can nuke it 2016-12-22 14:58:40 -08:00
Mark Otto
be7a8c68f7 Redo controls in flexbox
- Drops the absolute positioning of the icons within the left/right controls. We have to keep the controls themselves positioned though since we're overlapping HTML elements here.

- No more position, left, right, or margins involved; just some justify-content and align-items.

- Add some comments for explaining which flex property-value pair does what.

- Remove the unapplied font and line-height stuff now that we're all SVGs and flexbox here.
2016-12-22 14:58:40 -08:00
Mark Otto
1706f494f0 flexbox powered indicators
This revamps the indicators to use flexbox instead of inline-block for added flexbility (hah). Indicators now automatically scale based on the number of elements present, and max out at the `$carousel-indicator-width` instead of always being that wide.
2016-12-22 14:58:40 -08:00
Mark Otto
d426c3c50e start small--set flex instead of block for active items 2016-12-22 14:58:40 -08:00
Tom Lutzenberger
e1653edb95 Add variables for transitions (#21345)
* Add variables for transitions

* Add variables for transitions
2016-12-19 20:33:17 -08:00
Mark Otto
4ef547f4bb drop the .carousel-control base class 2016-12-04 23:19:54 -08:00
Mark Otto
e331db31fd linting 2016-12-04 22:19:20 -08:00
Mark Otto
89f5e65cfb drop the fixed width of the indicators. instead use the carousel-control width as margins to ensure content doesn't overlap 2016-12-04 22:05:05 -08:00
Mark Otto
1980854c14 rename var 2016-12-04 22:01:31 -08:00
Mark Otto
410bf38a4f there's no font, so rip that var 2016-12-04 21:55:46 -08:00
Mark Otto
990db2496f rip responsive styles; they're unnecessary and likely require overriding anyway 2016-12-04 21:55:02 -08:00
Mark Otto
1abe4c83a8 redo control icons to use open iconic svgs inlined 2016-12-04 21:54:45 -08:00
Mark Otto
d157fcebba rename control left and right to prev and next; simplify styling by removing gradient 2016-12-04 21:54:04 -08:00
Mark Otto
5c93cb7c81 code comment 2016-12-04 21:39:54 -08:00
Mark Otto
8f06eebe44 rename and un-nest icons 2016-12-04 21:39:46 -08:00
Mark Otto
c2c4b5ba76 remove comment 2016-12-04 21:39:27 -08:00
Mark Otto
1e3ec89355 Merge branch 'v4-dev' into carousel 2016-12-04 21:05:19 -08:00
Mark Otto
6782dd6e92 nuke the text-shadow 2016-12-04 20:37:30 -08:00
Mark Otto
fd87c19e79 linting 2016-12-04 20:27:33 -08:00
Mark Otto
6d28f07582 redesign indicators 2016-12-04 20:14:33 -08:00
Mark Otto
ba329cfd6a redo css more
- fix naming of left/right controls
- drop the absolute positioning of things and rely on only 3d transforms
- remove img styles and require classes to avoid inline-block line-height stuff
2016-12-04 19:52:49 -08:00
Starsam80
b226766b62 Remove lots of duplication + minor cleanup (#21238)
* Remove comment that duplicated some code
* Use transition mixin whenever possible
* Create a new function to reduce duplication
* Use the new `breakpoint-infix` method
2016-11-28 13:23:59 -08:00
Mark Otto
23664d3a90 fix nesting and syntax error 2016-11-25 23:43:12 -08:00
Mark Otto
ef818c0799 Start renaming carousel classes
- Un-nests .carousel-item
- Appends .carousel-item- to .left, .right, .next, and .prev
- Chain .carousel-item to .active where approproriate
2016-11-25 23:42:16 -08:00
Chris Rebert
3593ee85c1 Add @supports feature query for Carousel CSS 3D transforms; fixes #15534 (#19751)
[skip sauce]
[skip validator]
2016-11-25 14:51:55 -08:00
Mark Otto
d6412cddc8 Merge pull request #19236 from twbs/carousel-icon-width
Extract $carousel-icon-width variable
2016-05-08 13:33:05 -07:00
Chris Rebert
105bfbc5f9 Extract $carousel-indicators-width variable
[skip sauce]
[skip validator]
2016-02-17 21:10:20 -08:00
Mark Otto
bfe20c2971 Merge pull request #19242 from twbs/carousel-caption-width
Extract $carousel-caption-width variable
2016-02-17 08:55:16 -08:00
Chris Rebert
cbdb043ee3 Extract $carousel-caption{-sm-up}-width variables
[skip sauce]
[skip validator]
2016-02-16 21:45:16 -08:00
Chris Rebert
104ace17cb Extract $carousel-indicator{-active}-size variables
[skip sauce]
[skip validator]
2016-02-16 21:00:10 -08:00
Chris Rebert
9f85c6e1d1 Extract $carousel-control-sm-up-size variable
[skip sauce]
[skip validator]
2016-02-16 20:50:48 -08:00
Chris Rebert
3003f530c9 Extract $carousel-icon-width variable
[skip sauce]
[skip validator]
2016-02-16 20:46:52 -08:00
Chris Rebert
44a1361079 Rename gradient mixins to match new naming convention
gradient-{horizontal=>x}[-three-colors]
gradient-{vertical=>y}[-three-colors]
2016-01-13 15:34:01 -08:00
Chris Rebert
1a0a2186b8 scss/_carousel.scss: Add missing backticks in comment
[ci skip]
2015-11-05 16:30:57 -08:00