Chris Rebert
6c5e7dfce1
rm redundant aria-hidden usage from Modals; fixes #16020
2015-03-25 18:06:47 -07:00
Chris Rebert
d37bc2ae65
Merge pull request #15987 from twbs/fix-15972
...
add role="button" to a[data-toggle="collapse"]
2015-03-24 08:57:56 -07:00
Emmanuel Bourgerie
fa9d28b634
Fix #16072 : Clicking into input field within dropdown no longer closes the dropdown
...
Closes #16073 by merging it
2015-03-21 16:00:15 -07:00
Maxim Andrukhovych
83371735fc
Fixed proper navigation element selection on backward scrolling (from the bottom to the top)
2015-03-10 20:04:15 +00:00
Chris Rebert
725c6848c3
Disable jQuery event aliases when running test suite
...
To ensure that we don't accidentally use any of the aliases.
This should prevent any future regressions from #12761 .
Also updates the test suite since it now can't use these aliases either.
2015-03-09 01:05:43 -07:00
Chris Rebert
5c8d56d515
Collapse unit test: rm check that no-op hide adds style="height: 0px"
...
Appears to be unnecessary and is broken by #16011 ,
which is otherwise quite sane.
2015-03-06 18:10:53 -08:00
Chris Rebert
872e56fcf2
.collapse('hide') on hidden uninit-ed collapsible no longer shows it; fixes #15315
...
Thanks to @peterblazejewicz & @Nikita240
Adds unit tests based on #14417
X-Ref: #14282
Closes #15807
2015-03-06 06:58:48 -08:00
Chris Rebert
27bbc7dbe9
Hiding an uninitialized tooltip/popover no longer initializes it; fixes #15874
2015-03-03 22:22:13 -08:00
Chris Rebert
cc39f5c52d
add role="button" to a[data-toggle="collapse"]; fixes #15972
2015-03-03 13:18:36 -08:00
Heinrich Fenkart
420a8088a4
Merge pull request #15961 from kkirsche/ImplementAssertExpect
...
[Fixes #15953 ] Implement assert.expect in each unit test
2015-03-03 15:52:05 +01:00
Kevin Kirsche
4febcb4b49
[ Fixes #15953 ] Implement assert.expect in each unit test
...
[Fixes #15953 ] Implement `assert.expect` in each unit test
2015-03-03 08:45:07 -05:00
Heinrich Fenkart
f5beebe726
Modal: Fix backdrop not readjusting when height changes
...
Fixes #15136 .
Closes #15345 .
Closes #15314 .
Refs #14724 , #14927 .
2015-03-03 05:27:26 +01:00
XhmikosR
f8e34ff48b
Disable es3 for tests and customizer.js.
2015-03-02 11:16:06 +02:00
Chris Rebert
015e63f6df
Merge pull request #15593 from neoeno/handle_multiple_zero_offset_scrollspy_elements
...
Handle multiple zero-offset Scrollspy elements.
2015-03-01 16:04:04 -08:00
Caden Lovelace
a1aa0f8afd
Handle multiple zero-offset Scrollspy elements.
...
When the first two elements in a scrollspy content block have a document
offset of zero (i.e. they're hard against the top of the page),
Scrollspy would switch between them on every scroll event.
This could happen, for example, in a system of nested sections:
```
<section id="animals">
<section id="dogs">
Content
</section>
</section>
```
This ocurred because Scrollspy's check to see if it's at the end of the
array of sections uses `!arr[index]`. This misses the case where
`arr[index]` does exist and is zero.
This commit explicitly checks the array bounds.
2015-03-01 23:55:39 +00:00
Mark Otto
c16fee5efd
Merge branch 'master' into v4
...
Conflicts:
.travis.yml
Gruntfile.js
bower.json
dist/css/bootstrap.css
dist/css/bootstrap.css.map
dist/css/bootstrap.min.css
dist/js/bootstrap.js
dist/js/bootstrap.min.js
docs/_data/glyphicons.yml
docs/_includes/components/breadcrumbs.html
docs/_includes/components/button-dropdowns.html
docs/_includes/components/button-groups.html
docs/_includes/components/dropdowns.html
docs/_includes/components/glyphicons.html
docs/_includes/components/labels.html
docs/_includes/components/list-group.html
docs/_includes/components/media.html
docs/_includes/components/navs.html
docs/_includes/components/panels.html
docs/_includes/components/progress-bars.html
docs/_includes/components/thumbnails.html
docs/_includes/components/wells.html
docs/_includes/css/buttons.html
docs/_includes/css/forms.html
docs/_includes/css/helpers.html
docs/_includes/css/images.html
docs/_includes/css/less.html
docs/_includes/customizer-variables.html
docs/_includes/getting-started/accessibility.html
docs/_includes/getting-started/browser-device-support.html
docs/_includes/getting-started/community.html
docs/_includes/getting-started/examples.html
docs/_includes/getting-started/grunt.html
docs/_includes/getting-started/license.html
docs/_includes/getting-started/template.html
docs/_includes/header.html
docs/_includes/js/affix.html
docs/_includes/js/alerts.html
docs/_includes/js/carousel.html
docs/_includes/js/collapse.html
docs/_includes/js/dropdowns.html
docs/_includes/js/modal.html
docs/_includes/js/overview.html
docs/_includes/js/popovers.html
docs/_includes/js/scrollspy.html
docs/_includes/js/tabs.html
docs/_includes/js/tooltips.html
docs/_includes/js/transitions.html
docs/_includes/nav/javascript.html
docs/_layouts/default.html
docs/assets/css/docs.min.css
docs/assets/css/src/docs.css
docs/assets/js/customize.min.js
docs/assets/js/docs.min.js
docs/assets/js/raw-files.min.js
docs/assets/js/vendor/FileSaver.js
docs/assets/js/vendor/autoprefixer.js
docs/assets/js/vendor/uglify.min.js
docs/dist/css/bootstrap.css
docs/dist/css/bootstrap.css.map
docs/dist/css/bootstrap.min.css
docs/dist/js/bootstrap.min.js
docs/examples/blog/index.html
docs/examples/carousel/index.html
docs/examples/cover/index.html
docs/examples/dashboard/index.html
docs/examples/narrow-jumbotron/narrow-jumbotron.css
docs/examples/navbar-fixed-top/index.html
docs/examples/navbar-static-top/index.html
docs/examples/non-responsive/index.html
docs/examples/non-responsive/non-responsive.css
docs/examples/theme/index.html
grunt/configBridge.json
js/affix.js
js/carousel.js
js/collapse.js
js/dropdown.js
js/modal.js
js/popover.js
js/scrollspy.js
js/tab.js
js/tests/unit/affix.js
js/tests/unit/button.js
js/tests/unit/carousel.js
js/tests/unit/modal.js
js/tests/unit/tooltip.js
js/tooltip.js
less/badges.less
less/glyphicons.less
less/type.less
less/variables.less
package.json
scss/_dropdown.scss
scss/_forms.scss
test-infra/npm-shrinkwrap.json
2015-03-01 13:44:10 -08:00
Ivan Cheung
d5071b19f1
Update all collapse triggers with .collapsed class and aria-expanded
...
Fixes #15741
Closes #15751 by merging it.
2015-02-26 18:48:20 -08:00
Chris Rebert
9afb61fffd
QUnit.jsDump => QUnit.dump
...
Refs http://qunitjs.com/upgrade-guide-2.x/#replace-qunit-jsdump-with-qunit-dump
2015-02-25 23:29:27 -08:00
Heinrich Fenkart
3bb05b5fbb
Unit tests: Use new names of module hooks
...
Refs #15893
2015-02-26 08:20:42 +01:00
nakupanda
142a9e4ae0
Modal: Apply any preexisting body padding again after closing
2015-02-26 08:02:06 +01:00
vsn4ik
b395f3526e
Dropdowns: Skip .disabled instead of .divider on keydown event
...
Fixes #15147 .
Closes #15520 by merging it.
2015-02-26 06:42:09 +01:00
Chris Rebert
804457c474
fix 2 typos in modal unit test assertion messages
2015-02-24 23:49:08 -08:00
Heinrich Fenkart
c40c31a308
Dropdown unit tests: Tiny style changes
2015-02-25 02:53:39 +01:00
Chris Rebert
2a6207c0c9
Merge pull request #15904 from kkirsche/patch-8
...
Closes #15904
2015-02-24 14:11:03 -08:00
Kevin Kirsche
696fc2e53c
Add unit test of aria-expanded to dropdown suite
...
Redo of #15876
2015-02-24 14:09:08 -08:00
Kevin Kirsche
30d8cdf639
Add tests for aria-hidden of modal
...
Add tests for `aria-hidden` of modal
Use strictEqual of 1 here instead of 2 asserts
2015-02-24 16:29:40 -05:00
Chris Rebert
9c75c855c6
JS unit tests: equal() => strictEqual()
...
[skip validator]
2015-02-23 22:43:17 -08:00
Chris Rebert
118b8c2695
JS unit tests: use QUnit.module() & QUnit.test() everywhere
...
[skip validator]
2015-02-23 22:14:11 -08:00
Chris Rebert
7c19fee3f1
JS unit tests: use modern QUnit assert object everywhere
2015-02-23 22:14:11 -08:00
fat
1e9e3316b6
kill affix
2015-02-11 11:40:57 -08:00
fat
834220ea20
bootstrap onto closure
2015-02-11 11:29:43 -08:00
Chris Rebert
cd4467b194
Merge pull request #15496 from twbs/15484-alternative
...
Make $(document).tooltip({...}) without a `selector` throw an error
2015-01-28 11:05:40 -08:00
Chris Rebert
9238337cbb
Merge branch 'master' into v4
2015-01-21 13:00:12 -08:00
Chris Rebert
1652efc3f6
tweak 'close reopened modal' unit test to work under new QUnit API
2015-01-20 20:18:33 -08:00
Chris Rebert
df73535a2d
fix bug in tab show/shown relatedTarget unit test
2015-01-20 20:16:42 -08:00
Chris Rebert
b56d97f210
update JS unit tests to future-proof QUnit 1.16.0 API
...
[skip validator]
2015-01-20 19:57:51 -08:00
Chris Rebert
f6a837cbf1
Make $(document).tooltip({...}) without a selector throw an error
...
Closes #15484
2015-01-05 14:22:49 -08:00
Mark Otto
0e5d17d5f6
Merge branch 'master' into v4
...
Conflicts:
Gruntfile.js
dist/css/bootstrap-theme.css
dist/css/bootstrap-theme.css.map
dist/css/bootstrap-theme.min.css
dist/css/bootstrap.css
dist/css/bootstrap.css.map
dist/css/bootstrap.min.css
dist/js/bootstrap.min.js
docs/_data/glyphicons.yml
docs/_includes/components/alerts.html
docs/_includes/components/badges.html
docs/_includes/components/breadcrumbs.html
docs/_includes/components/button-dropdowns.html
docs/_includes/components/button-groups.html
docs/_includes/components/dropdowns.html
docs/_includes/components/glyphicons.html
docs/_includes/components/input-groups.html
docs/_includes/components/jumbotron.html
docs/_includes/components/labels.html
docs/_includes/components/list-group.html
docs/_includes/components/media.html
docs/_includes/components/navbar.html
docs/_includes/components/navs.html
docs/_includes/components/page-header.html
docs/_includes/components/pagination.html
docs/_includes/components/panels.html
docs/_includes/components/progress-bars.html
docs/_includes/components/responsive-embed.html
docs/_includes/components/thumbnails.html
docs/_includes/components/wells.html
docs/_includes/css/buttons.html
docs/_includes/css/code.html
docs/_includes/css/forms.html
docs/_includes/css/grid.html
docs/_includes/css/helpers.html
docs/_includes/css/images.html
docs/_includes/css/less.html
docs/_includes/css/tables.html
docs/_includes/css/type.html
docs/_includes/customizer-variables.html
docs/_includes/getting-started/accessibility.html
docs/_includes/getting-started/disabling-responsiveness.html
docs/_includes/getting-started/download.html
docs/_includes/getting-started/whats-included.html
docs/_includes/js/alerts.html
docs/_includes/js/buttons.html
docs/_includes/js/carousel.html
docs/_includes/js/collapse.html
docs/_includes/js/modal.html
docs/_includes/js/overview.html
docs/_includes/js/popovers.html
docs/_includes/js/tabs.html
docs/_includes/js/tooltips.html
docs/_includes/nav/components.html
docs/_includes/nav/javascript.html
docs/_jade/customizer-variables.jade
docs/_layouts/default.html
docs/about.html
docs/assets/css/docs.min.css
docs/assets/css/src/docs.css
docs/assets/js/customize.min.js
docs/assets/js/raw-files.min.js
docs/assets/js/src/customizer.js
docs/customize.html
docs/dist/css/bootstrap-theme.css.map
docs/dist/css/bootstrap.css
docs/dist/css/bootstrap.css.map
docs/dist/css/bootstrap.min.css
less/glyphicons.less
less/mixins/vendor-prefixes.less
less/navbar.less
less/popovers.less
less/tables.less
less/theme.less
less/tooltip.less
less/variables.less
package.json
scss/_carousel.scss
scss/_close.scss
scss/_forms.scss
test-infra/npm-shrinkwrap.json
2015-01-03 20:08:58 -08:00
Chris Rebert
adaabab81b
Revert "Allow multiple delegated tooltip selectors on a node"
...
This reverts commit 1b3237629a#14189 because it caused major regressions.
Fixes #15168 .
We'll try to revisit #14167 's feature request in Bootstrap v4.
[skip validator]
2014-12-29 20:08:22 -08:00
Chris Rebert
32cb071594
Remove semicolons from #15425 because fat
2014-12-29 18:34:35 -08:00
Chris Rebert
27bfef5b35
Add regression test for #14244 .
...
Special thanks to @programcsharp
[skip validator]
2014-12-29 16:09:37 -08:00
Chris Rebert
05d1877985
update JS to use .{tooltip,popover}-{left,right,top,bottom}
2014-12-29 12:34:09 -08:00
Chris Rebert
6a5bc63649
rename .arrow => .popover-arrow
2014-12-29 12:33:06 -08:00
Chris Rebert
c7ef5810e1
rename .item => .carousel-item
2014-12-17 18:44:55 -08:00
Dan Dascalescu
2c64fc2c4d
Fix copy/paste error
2014-11-28 04:30:04 -08:00
Chris Rebert
bc5a753b67
fix affix-top unit test to properly clean up after itself
2014-11-20 23:26:37 -08:00
Nick O'Donoghue
da79ab9488
add unit test for affix-top for padding issue
2014-11-17 18:17:40 -08:00
Chris Rebert
8008fe707e
add unit tests for Carousel's 'wrap' option
2014-11-15 22:37:55 -08:00
Heinrich Fenkart
1d55ada581
Dropdown: ignore keydown events coming from inputs and textareas
...
Fixes #15084 .
2014-11-12 02:01:25 +01:00
Chris Rebert
469dc3ab1f
Have Carousel ignore keyboard events from <input>s or <textarea>s; fixes #14991
2014-11-04 16:23:44 -08:00
Heinrich Fenkart
ed3a65f084
Handle collapsed class on triggers even when manually invoked
...
Fixes #13636 .
2014-10-29 04:34:05 +01:00
Heinrich Fenkart
e851b8685a
Merge pull request #14457 from hnrch02/button-set-val-after-event-loop
...
Change value of stateful button after event loop
2014-10-29 04:28:22 +01:00
Chris Rebert
22e1f94b52
Increase timeouts in tooltip unit tests to avoid spurious Sauce failures
...
Fixes #14851
2014-10-27 15:53:43 -07:00
Heinrich Fenkart
007fbdb66d
Remove faulty unit test from 9740d8b
...
This would only work with transitions but since we disable them for unit tests, this delivers unreliably results.
2014-10-26 04:56:52 +01:00
Heinrich Fenkart
5da85f8e8b
Follow-up to 9740d8b: fix small typo
2014-10-26 04:41:47 +01:00
Phil Hughes
9740d8bb69
Fix tooltip occasionally not hiding when using a hide delay
...
Fixes #14375 .
Closes #14519 by merging it.
2014-10-26 04:38:18 +01:00
Andrew S. Brown
1b3237629a
Allow multiple delegated tooltip selectors on a node
...
Fixes #14167 .
Closes #14189 by merging it.
2014-10-26 03:51:55 +01:00
Heinrich Fenkart
0e991ccba2
Follow-up to e8af21c: rm unused variable in unit test
2014-10-26 03:16:05 +01:00
Tadeu Zagallo
e8af21cc9d
Clear scrollspy selection above first section
...
Closes #13563 by merging it.
2014-10-26 03:14:08 +01:00
Cameron Little
0755d529c6
Tabs plugin accessibility
...
Added support for `aria-expanded` toggling via JavaScript. Added
`aria-controls`, `aria-expanded`, `aria-labelledby` to tabs docs.
Added `aria-expanded` unit test for the tabs plugin.
See also #13554 .
Closes #14154 by merging it.
2014-10-26 02:25:47 +01:00
Heinrich Fenkart
3c98dd35ba
Fix IE8 unit test breakage introduced by #14767
2014-10-22 22:09:58 +02:00
Phil Hughes
ab8dbc214e
Implement hide and hidden events for tabs
...
Closes #14772 .
2014-10-22 21:42:35 +02:00
saranya.r
e2cfbd5f2d
Fixes tooltip misplacements in scrollable viewports with auto positioning
...
Fixes #14756 .
Closes #14767 .
2014-10-22 21:35:44 +02:00
Patrick H. Lauke
e1d40f7633
Add aria-pressed to single toggle buttons
...
also includes tiny fix/clarification to two existing unit tests for the
.active class, adding data-toggle=“button” explicitly to the tested
buttons
Closes #14819 .
2014-10-22 21:02:19 +02:00
Heinrich Fenkart
e811a24118
Don't fire show event if show is prevented because other element is still transitioning
...
Fixes #14844 .
Closes #14845 .
2014-10-22 04:25:05 +02:00
fat
4bbe80658a
fixes #13816 Modal dialog closes when dragging and releasing mouse button outside dialog
2014-10-09 20:01:51 -07:00
XhmikosR
909a178362
Change Twitter links to use https.
2014-10-07 15:28:41 +03:00
Heinrich Fenkart
61705d35fa
Small clean-up in scrollspy unit test
2014-10-07 06:57:46 +02:00
Chris Rebert
d361470487
tooltip unit tests: fix typo in test description
2014-10-03 16:26:53 -07:00
Heinrich Fenkart
038a63b0eb
Add keyboard option to carousel
...
Also adds unit tests for keyboard events.
Fixes #14468 .
2014-10-03 05:16:31 +02:00
Jacob
b702889613
Merge pull request #14626 from twbs/carousel-pause-hover-non-mobile
...
Only enable `pause: hover` for non-touch browsers
2014-10-02 20:09:20 -07:00
Chris Rebert
4d9890ea2e
Use container instead of parent for tooltip/popover auto-placement calcs
...
Fixes #14561 . Big thanks to @wickstargazer.
[skip validator]
2014-09-24 20:46:49 -07:00
Heinrich Fenkart
24ae068f21
Tooltip: Rely on getBoundingClientRect for width and height
...
Fixes #14553 .
2014-09-25 01:35:51 +02:00
Heinrich Fenkart
c37c1a6743
Only enable pause: hover for non-touch browsers
...
Fixes #11967 .
2014-09-23 23:34:58 +02:00
Heinrich Fenkart
3beeb32bb0
Follow-up to #14581 : Use div instead of HTML5 section for IE8
2014-09-17 23:33:22 +02:00
saranya.r
db9e8ee813
Fix tooltip misplacement with "auto top"
...
Fixes #14322 .
Closes #14581 .
2014-09-17 23:11:04 +02:00
Chris Rebert
73e3db0a2f
Must explicitly destroy tooltip in SVG unit test since its container is body.
...
Leaking tooltips across tests leads to confusion and sadness.
2014-09-15 20:01:06 -07:00
Peter West
4c98507010
Correctly selects arrow placement for a tooltip
...
Fixes #13696 .
Fixes #13696 .
Fixes #14197 .
Closes #13718 .
2014-09-13 04:25:34 +02:00
Heinrich Fenkart
9b9e2f5d13
grunt and missing new line
2014-09-09 01:23:48 +02:00
Patrick H. Lauke
fb1ca10b99
ARIA support for collapse
...
Added handling of aria-expanded=true/false to collapse.js, updated
documentation to include advice on making expand/collapse controls
accessible, updated examples and javascript documentation to use
aria-expanded and aria-controls (when targetting single collapsible
element, using ID rather than class selector)
Closes #14147 .
Closes #14153 .
2014-09-09 01:19:20 +02:00
Heinrich Fenkart
787404e090
Merge pull request #14287 from hnrch02/revert-13855-modal-mousedown
...
Revert #13855 due to #14263
2014-09-08 22:23:43 +02:00
Jacob
c22b270582
Merge pull request #14273 from sgonyea/master
...
Fix hover-popover/tooltip flickering when mouse re-enters
2014-09-07 10:36:45 -07:00
Scott Gonyea
aac0e16452
Fix hover-tooltip flickering when mouse re-enters
...
- is(':visible') seems to be the only reliable check, without a refactoring of how hoverState is used
- tests need improvement
2014-08-28 17:17:50 -07:00
Heinrich Fenkart
c207b5b66b
Change value of stateful button after event loop
...
Fixes #14450
2014-08-26 03:02:29 +02:00
Mark Otto
875006d08c
Merge pull request #14417 from twbs/fat-14282
...
fixes #14282 - Already Visible collapse gets closed when …
2014-08-23 12:58:24 -07:00
fat
9c2e54bfec
fixes #14282 - Already Visible collapse gets closed when .collapse('show') is called
2014-08-18 19:58:19 -07:00
Chris Rebert
6b7142212f
consistently use <nav> instead of <div> for .navbar in docs
2014-08-15 18:09:05 -07:00
Heinrich Fenkart
75bffd84ae
Use closest .alert for alert dismissal; closes #14306
2014-08-04 19:33:42 +02:00
Chris Rebert
08393bf68a
Fix #14076 : Add unit test for tooltips on SVG elements
...
[skip validator]
2014-08-01 12:10:00 -07:00
Chris Rebert
cbba8e53df
Fix #13818 by using more robust "find next carousel item" logic
...
Also adds another test for #9461 : carousel next/prev should ignore non-items
2014-07-31 11:36:24 -07:00
Heinrich Fenkart
18c0a1c977
Revert "Use mousedown instead of click for backdrop click detection; fixes #13816 "
2014-07-30 23:54:25 +02:00
fat
9b90b87099
speed up js tests a bit
2014-07-16 22:22:42 -07:00
Heinrich Fenkart
1719d2b051
document.head is undefined in IE8
2014-07-09 00:42:02 +02:00
Heinrich Fenkart
05ddea314c
Fix IE8 reporting height style as all uppercase
2014-07-09 00:42:02 +02:00
Chris Rebert
21571b3412
Fix invalid HTML in "should allow html entities" tooltip unit test
...
Refs #14090 .
Also, fix one typo.
2014-07-08 14:40:20 -07:00
fat
587c09cb48
fix scrollspy test in firefox mac os
2014-07-06 21:50:46 -07:00
Jacob
b5d86ad0bd
Merge pull request #13853 from hnrch02/unit-tests-cleanup
...
Major unit tests cleanup
2014-07-06 21:43:48 -07:00
Mark Otto
ac18e5811d
jscs fix
2014-07-06 15:08:33 -07:00
fat
cb19f4f227
Merge branch 'breaddevil-replace-scrollspy-default-behavior-test'
2014-07-06 14:11:38 -07:00
fat
b19719ea1a
Merge branch 'replace-scrollspy-default-behavior-test' of git://github.com/breaddevil/bootstrap into breaddevil-replace-scrollspy-default-behavior-test
...
Conflicts:
js/tests/unit/scrollspy.js
2014-07-06 14:11:23 -07:00
