0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-13 01:08:58 +01:00
Commit Graph

6 Commits

Author SHA1 Message Date
XhmikosR
6c7dcc6882
placeholder.svg: Partially revert the changes from c0e42cb. (#28216)
It broke the example include.
2019-02-09 13:10:29 +02:00
XhmikosR
c0e42cb89e
Optimize and normalize SVGs. (#28200)
Mostly be consistent with the attributes' order and improve compression when possible.
2019-02-07 15:01:25 +02:00
Patrick H. Lauke
c031584bcd
SVG accessibility fixes (#27826)
* SVG accessibility fixes

- add `focusable="false"` to all SVGs, to stop IE from including the `<svg>` in its default focus cycle
- completely hide decorative SVGs using `aria-hidden="true"`
- add `role="img"` to meaningful/"content" SVGs, ensure they have an appropriate `<title>` and/or `aria-label`
- simplify placeholder default title

* Simplify usage of placeholder.svg in the docs

- in most cases, no need for separate/redundant text and title (now that we make text itself part of the alternative text explicitly)
- no need (expect in rare cirumstances) to describe the placeholder image (unless the look of the image is important/the actual content, as is the case with the image thumbnail class)

* Simplify example.html rewriting of <svg> to <img> code sample

- as the `alt` for the placeholder isn't really important, just add an ellipsis instead (otherwise, to be correct, we'd have to construct the whole "title+text" construct like we do now in the
placeholder.svg itself

* Change svgo configuration to retain role attribute and add/force focusable=false

- regarding `focusable=false`, see https://github.com/svg/svgo/issues/1011 (which would be the "proper" SVGO fix) and the (hacky) solution https://github.com/svg/svgo/pull/817
2018-12-13 13:09:47 +00:00
m5o
31d6d03c47 Placeholders: use our gray colors (#27701)
Previously we were using the old holder.js colors.
2018-11-21 20:59:21 +02:00
XhmikosR
2ac3db8384 Tweak placeholder.svg.
* always include the title
* make it possible to skip adding the title by passing `title=' '`
* remove viewBox since we don't need it
2018-11-20 21:31:28 +02:00
Martijn Cuppens
072b5ab7fd Replace holder.js with SVGs. 2018-11-20 21:31:28 +02:00