0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-05 17:24:20 +01:00
Commit Graph

79 Commits

Author SHA1 Message Date
Martijn Cuppens
d479fd89d0 Remove attribute selectors (#28988) 2019-07-12 13:15:50 +03:00
Mark Otto
1d4d9f8d89 Drop all hover mixins
Previously deprecated in v4.x, this clears out the now unused Sass option and removes some unused mixins. Arguably we could remove more, but I like the hover-focus mixin and we make extensive use of it across the project.
2019-05-08 20:58:07 +03:00
GeoSot
275cd7f91e Separate $btn-link colors from $link-color (#28681) 2019-04-23 16:12:51 +03:00
Martijn Cuppens
8b41cb1368 Optional btn & input font sizes (#28068) 2019-02-07 19:47:24 +02:00
Bardi Harborow
b5fb4f7d6b Add text-decoration to .btn-link. (#28169) 2019-02-06 22:33:03 +01:00
Martijn Cuppens
e1b990fb90 Move hand cursor for buttons to reboot 2019-01-04 11:53:32 +02:00
Martijn Cuppens
a6669b478b Fix btn focus color (#27178) 2018-10-17 23:21:33 +03:00
Martijn Cuppens
e604958641 Variable .btn and .form-control font sizes (#26908) 2018-09-18 15:35:25 +03:00
Martijn Cuppens
bf4dab72df #27220: cleanup .btn-link hover/focus properties (#27250) 2018-09-17 09:34:34 -03:00
Martijn Cuppens
97eea3b2bf Set .btn base color 2018-09-02 16:28:42 -07:00
Martijn Cuppens
3ef2db1e85 Move transparent background to .btn and remove background-image 2018-09-02 16:28:42 -07:00
Rowan-James Tran
24bdadf9d3 Remove nowrap from .btn 2018-08-19 11:17:10 -07:00
Martijn Cuppens
c74a32703a Allow background images for active buttons 2018-07-20 19:25:01 -05:00
Peter Etelej
fb15575ec5 Disable link functionality on disabled btn-link (#25645)
Future-proof disabling of clicks on disabled `btn-link`. Fixes #25639
ensuring consistency between `btn-link` `<button>`s and `<a>`s when disabled.
2018-03-12 19:36:25 +02:00
Mark Otto
a0936c326f Outline button hover color (#25339) 2018-01-18 01:45:25 +02:00
Patrick H. Lauke
1f490ec165
Consistently use :disabled rather than [disabled] selector (#25317)
Closes https://github.com/twbs/bootstrap/issues/25316
2018-01-15 20:51:01 +00:00
Mark Otto
afc984dca7 line break 2017-12-27 17:56:28 -08:00
Mark Otto
9023909484 fix mixin include 2017-12-27 17:56:28 -08:00
Mark Otto
97cfe5a582 Only apply the active and focus shadow on the focus state for :active 2017-12-27 17:56:28 -08:00
patrickhlauke
e3f9c463fc Opinionated: reintroduce cursor:pointer
Explicitly re-adds the "hand" `cursor:pointer` for non-disabled `.btn`, `.close`, `.navbar-toggler` elements, as well as forcing `page-link` pagination controls to always have the "hand" cursor (even if an author uses it on, say, `<button>` elements for a dynamically updating in-page pagination).

Controversial, as everybody jumped on the bandwagon following this article https://medium.com/simple-human/buttons-shouldnt-have-a-hand-cursor-b11e99ca374b - which does have its merits of course, but there are also counter-arguments like http://kizu.ru/en/issues/cursor-pointer/

And seeing the amount of issues we've seen following the change, and the potential complexity needed to consistently address the cursor issue (see https://github.com/twbs/bootstrap/issues/24156 where i explore how the cursor needs to be based on "intent", and how that's tough to determine), I'm favouring an opinionated take here of just reintroducing the `cursor:pointer`.
2017-12-27 16:28:10 -08:00
Andres Galante
b755883059 Adds underline back to btn-link on focus 2017-11-08 11:05:12 -05:00
Patrick Yeo
e2c15da967 Move hardcoded opacity value in .btn:disabled to variable $btn-disabled-opacity (#24680) 2017-11-06 13:34:42 -08:00
Mark Otto
af9df8c308 update new focus and shadow properties to use vars 2017-10-25 12:30:29 -07:00
Mark Otto
04b32db845 Merge branch 'btn_input_split_variables' of https://github.com/isychev/bootstrap into isychev-btn_input_split_variables 2017-10-22 19:59:20 -07:00
Mark Otto
1f42d79561 Merge branch 'v4-dev' into btn_input_split_variables 2017-10-22 14:26:49 -07:00
XhmikosR
52d99a887e Refactor a few selectors. (#24404)
1. move a couple of them before the more specific ones.
2. change nesting to be under the same parent selector
3. use the ampersand more
2017-10-23 00:17:28 +03:00
Mark Otto
06641ca0b3 Gradients and shadows (#24429)
* Update the form focus mixin to use a manual `$enable-shadows` check so we can always ensure a focus state for accessibility and consistency

* - Add new `$input-btn-focus-width` and `$input-btn-focus-color` variables.

- Replace separate `$btn-focus-box-shadow` and `$input-focus-box-shadow`
variables with unified `$input-btn-focus-box-shadow` to match our
combined variables approach elsewhere.

* Put new focus width var to use in buttons mixins

* use new button input-box shadow var

* Add a new mixin for quickly adding linear gradient to components when $enable-gradients is set to true

* use correct var

* fix focus shadows in button mixins

* Add opt-in gradients to alerts, buttons, carousel, custom radios and checkboxes, custom file input, and dropdown items

* Generate .bg-gradient- utilities

* add headings to colors page and document bg-gradient utils

* update the button color for active status, check with yiq as it's done for basic state and hover state
2017-10-19 09:03:33 -07:00
i.sychev
58e553d7bc append btn-* and input-* variables and extends their from input-btn-* variables 2017-10-19 10:05:07 +03:00
Prateek Goel
de3973b5e7 Ensure active button styles are not applied to disabled buttons 2017-10-09 18:32:48 -04:00
XhmikosR
7b766e1ad5 Switch to stylelint. (#23572) 2017-10-02 20:34:56 -07:00
Andres Galante
906db62ee2 removes border radius from btn-link (#24128) 2017-10-02 18:56:50 -07:00
Svyatoslav Polishchuk
70ca04bbdc replaced basic line-heights variable with button's line-heights variable for button size classes 2017-08-22 11:08:22 -07:00
Mark Otto
5b8738afc1 Fix .btn-outline-light hover color
Uses some if/else action to ensure there's readable text on hover. Swapped out a hex value to a variable while I was in there.

Fixes #23398, fixes #23351.
2017-08-14 21:07:35 -07:00
Mark Otto
cd22eb1da0 Button code cleanup (#22951)
* use a mixin there
* revamp .btn-link to match default and outline variants
* remove unnecessary properties
2017-08-13 14:55:28 -07:00
Patrick H. Lauke
edae6a2e1d Remove box-shadow from .btn-link:focus (#22998)
When focused, these buttons styled as links still give good visible focus indication through the underline, so this should not be a concern. Closes #22655
2017-07-05 10:54:26 +02:00
Mark Otto
597e9f8618 remove - vars, update docs to generate from data yml files, update mixins, and generate card, button, bg, and color classes from the sass map 2017-06-18 02:57:16 -07:00
Patrick Yeo
dd0ce3e4b2 Rename variable $input-border-focus to $input-border-color-focus (#22413)
* Rename variable $input-border-focus to $input-border-color-focus
* Rename variables $pagination-hover-border, $pagination-active-border, $pagination-disabled-border to $pagination-hover-border-color, $pagination-active-border-color, $pagination-disabled-border-color, respectively
* Rename variables $state-*-border to $state-*-border-color, respectively
* Rename variables $alert-*-border to $alert-*-border-color
* Rename $list-group-active-border to $list-group-active-border-color
* Rename $table-inverse-border to $table-inverse-border-color
* Rename $btn-*-border to $btn-*-border-color
* Rename $navbar-*-toggler-border to $navbar-*-toggler-border-color
2017-04-16 15:45:10 -07:00
Patrick H. Lauke
7056f70240 Remove cursor: not-allowed styles 2017-04-10 22:10:20 +01:00
Mark Otto
296c99020c Revamp button and input vars while fixing #21587 (#22287) 2017-03-28 09:28:27 -07:00
Dominic Watson
b3aa5ec360 Use btn-$variant-color variables for outlined btns (#22164)
Despite now having the ability to override outline-variant color, it's not actually being used so each are still #fff

Related: https://github.com/twbs/bootstrap/pull/20734
2017-03-12 18:25:56 -07:00
Mark Otto
b449e6b65e create a variable for the focus box-shadow, use it in the button base class
also be sure to apply it for the active state when shadows are enabled
2016-12-28 15:12:04 -08:00
Mark Otto
232e86d0b4 remove cursor: pointer
shoutout https://medium.com/simple-human/buttons-shouldnt-have-a-hand-cursor-b11e99ca374b#.riy12ck0m
2016-12-28 15:12:04 -08:00
Mark Otto
62c4cb29fb redo outlines
- removes original outline removal (hah)
- replaces it with an explicit `outline: 0` on `.btn`
- instead of replicating `:hover` for `:focus`, uses custom and themed `box-shadow` for an "outline"
- not mapped to the `$enable-shadows` variable because accessibility
2016-12-28 15:12:04 -08:00
Mark Otto
7aa2a52069 Redo button states
Trying to simplify our output here by revamping these selectors. We overcomplicated things by setting hover styles for nearly every state (disabled and active included), and we set them in the wrong order.

This commit does the following:

- Reorders states so disabled comes before active, thereby removing the need to set disabled-active styles.

- Removes all focus and hover styles from disabled states as those will naturally inherit from the default button state.

- Renamed `.open` to `.show` to fix dropdown toggle highlighting.

- Tweaked some indendation in the Sass.
2016-12-28 15:12:04 -08:00
Mark Otto
150625265b fixes #21415 by moving disabled .btn-link color to the default state 2016-12-28 15:12:04 -08:00
Tom Lutzenberger
e1653edb95 Add variables for transitions (#21345)
* Add variables for transitions

* Add variables for transitions
2016-12-19 20:33:17 -08:00
Simon Bächler
8402d2321f Use a variable for the default font weights. Fixes #20741
Websites might use different weights such as medium or thin or use light as default weight instead of normal.
Also referenced: #18605 and #16170.
2016-10-19 21:41:27 +02:00
Mark Otto
38c93371c1 updated button/form-control padding and line-height
- Moves from no set line-height (inherited of 1.5) to declared 1.25 for
all inputs and buttons (regardless of size modifier).

- Updates padding to be `.5rem` instead of `.375rem` so that padding is
more likely to be whole numbers based on the root font-size.

- Whole numbers will be beneficial in avoiding odd fractional pixels
that can lead to misalignment as shown in #18607.

- Large buttons and inputs are now a tad wider, and smaller
buttons/inputs a tad shorter and narrower, too.
2016-02-07 22:46:50 -08:00
Mark Otto
1db8dc10b5 Remove line-height from button mixin calls 2016-02-07 22:39:49 -08:00
Mark Otto
03ec195974 linter overhaul 2016-02-06 12:28:18 -08:00