GeoSot
328f723008
Tooltip: remove title attribute before show & add tests ( #35456 )
2021-12-07 15:51:56 +02:00
Louis-Maxime Piton
d8999dd566
Tests: Minor fixes ( #35455 )
2021-12-02 12:01:11 +02:00
GeoSot
385fea49e8
Tooltip/Popover: add underscore prefix to protected functions
2021-12-01 18:00:36 +02:00
GeoSot
c69ccba08c
Tooltip: Change _enter
& _leave
to work without arguments
2021-12-01 18:00:36 +02:00
GeoSot
cab62af2e6
Fix popover arrow & tooltip template after the setContent
addition ( #35441 )
2021-12-01 15:10:10 +02:00
GeoSot
44a6cd724c
Tooltip: remove leftover method ( #35440 )
...
Remove a leftover after #32692
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-12-01 14:53:56 +02:00
XhmikosR
11ce6c2dcd
tests: fix a few typos
2021-12-01 14:30:49 +02:00
XhmikosR
f8f9dc3b5c
tests: remove extra spaces, unneeded arrays and add missing newlines
2021-12-01 14:30:49 +02:00
XhmikosR
eb54e1a1ce
tests: tweak Jasmine's matchers usage
...
Use:
* toBeNull
* toEqual
* toBeTrue
* toBeFalse
* toHaveSize
* toHaveClass
2021-12-01 14:30:49 +02:00
GeoSot
6f077ff7bc
Clean tooltip component unneeded functionality ( #32692 )
2021-11-25 20:08:11 +02:00
GeoSot
94a596fbcb
Add a template factory helper to handle all template cases ( #34519 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-11-25 19:14:02 +02:00
XhmikosR
a260967a55
tests: minor cleanup ( #35138 )
...
* tests: minor cleanup
* tests: use the util noop function
2021-10-08 12:32:11 +03:00
XhmikosR
666fe596bf
Enable unicorn/no-array-for-each
rule
2021-10-05 19:52:11 +03:00
GeoSot
a6a2d1e2df
Regression on tooltip template creation process. ( #34628 )
...
* Regression on tooltip template creation process.
* check if template content does not exist, or given argument is empty
* call `setContent()` once.
2021-08-03 11:59:33 +03:00
XhmikosR
6d707f4801
Enable a few eslint-config-xo rules ( #34620 )
...
* unicorn/prefer-dom-node-append
* unicorn/prefer-dom-node-remove
2021-07-30 00:23:00 +02:00
GeoSot
c98657b830
Add getOrCreateInstance
method in base-component ( #33276 )
...
Co-authored-by: Rohit Sharma <rohit2sharma95@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-06-03 18:53:27 +03:00
alpadev
4a5029ea29
Fix handling of transitionend events dispatched by nested elements( #33845 )
...
Fix handling of transitionend events dispatched by nested elements
Properly handle events from nested elements
Change `emulateTransitionEnd` to `executeAfterTransition` &&
2021-06-03 14:44:16 +03:00
GeoSot
9e4f87ae8f
Allow use of dispose/hide
methods on Tooltip & Popover from jQueryInterface, when component does not exists. ( #33371 )
2021-05-20 16:16:55 +03:00
GeoSot
9a9e22475c
Popover/Tooltip: streamline config property to start with underscore ( #33381 )
2021-05-12 12:15:59 +03:00
Ben Lertlumprasertkul
052def4568
Remove potential false positive assertions ( #33288 )
...
* Remove potential false positive assertions
querySelector() returns null but
expect(document.querySelector('...')).toBeDefined()
tests that the value is not undefined
* Migrated assertions from .toBeDefined() to .not.toBeNull() for .getInstance() calls in tests
* Migrate offcanvas assertions from .toBeDefined() to .not.toBeNull() for .getInstance() call
* convert more cases to not.toBeNull assertions
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-05-11 08:45:57 +03:00
Rohit Sharma
bac0b0c899
Update tests to check for noop
to be removed
2021-04-11 09:42:52 +03:00
Ryan Berliner
99b2c0b390
only trigger tooltip inserted event on true dom insert
2021-03-16 07:48:50 +02:00
Ryan Berliner
6ef70b342c
prevent quick interactions from misplacing tooltips
2021-03-16 07:48:50 +02:00
Ryan Berliner
d491c29aa0
prevent tooltip from being deleted on quick re-activations
2021-03-16 07:48:50 +02:00
Rohit Sharma
dc5e3328c1
Allow constructors to accept a CSS selector ( #32245 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <otto@github.com>
2021-02-22 09:01:04 +02:00
Kyle Tsang
02dbd87ffa
Fix event handler removal in dropdown/carousel dispose ( #33000 )
...
* Fix event handler removal in carousel dispose
* Fix event handler removal in dropdown dispose
* Test event handlers in scrollspy dispose
* Test event handlers in toast dispose
* Test event handlers in tooltip dispose
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Rohit Sharma <rohit2sharma95@gmail.com>
2021-02-12 07:51:34 +02:00
Rohit Sharma
f7088e5d28
Add function type for popperConfig
option ( #32882 )
...
* Add function type for `popperConfig` option
* Update .bundlewatch.config.json
* copy edits
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <markdotto@gmail.com>
2021-02-09 21:16:13 +02:00
Rohit Sharma
b1bd54955e
Restore offset
option for tooltip/popover components
2021-01-28 12:23:33 +02:00
Rohit Sharma
c9cd741aff
Throw a TypeError
instead of the generic Error
( #32585 )
...
* Change from Error to TypeError
* Convert the `NAME` to upper case to make the consistency in the error message
* Update the remaining tests to be stricter
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-13 22:13:30 +02:00
Rohit Sharma
ebce95dc60
Tooltip - Add missing callback in async spec ( #32465 )
2020-12-14 13:02:34 +02:00
Rohit Sharma
4535b09c46
Tooltip - check if tip and its parent node exist in dispose method ( #32420 )
2020-12-10 21:06:41 +02:00
Johann-S
adfdf7160b
Update to popper.js v2.x
2020-12-06 18:42:40 +02:00
Gaël Poupard
9488978fb5
feat(RTL): implement RTL
...
Using RTLCSS directives, renaming things to use logical names and following best practices.
2020-12-04 07:52:03 +02:00
XhmikosR
dd992c7226
Add tests
2020-11-30 12:07:51 +02:00
XhmikosR
51a208f119
Switch to Jasmine's toBeInstanceOf
matcher
2020-11-29 20:58:26 +02:00
Johann-S
9f6b342dc7
create a base component
2020-11-29 20:58:26 +02:00
Rohit Sharma
c348ad4a94
Ability to add custom class in tooltip/popover ( #32217 )
...
Porting of #31834 to main.
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-25 09:16:22 +02:00
XhmikosR
f4457bca02
Be consistent with Popper's name. ( #32224 )
...
The npm package is named "popper.js" but the project is named "Popper", so use the latter consistently.
2020-11-21 16:22:08 +02:00
Rohit Sharma
418f17ee2b
Add bs
in data attributes
...
- Add `bs` in data APIs everywhere
- Update unit tests
2020-11-14 07:09:15 +02:00
XhmikosR
71010cb1e9
tests: switch to using toContain()
to check for substring presence ( #32043 )
2020-11-02 14:42:40 +02:00
Hiws
43b4252a34
fix tooltip hide method when already hidden ( #31115 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-09-24 14:55:38 +03:00
Tanguy Krotoff
d80a9fc553
Fix tooltip when hovering a children element (delegateTarget) ( #30928 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-06-18 10:02:44 +03:00
XhmikosR
967e6071ba
tests: streamline HTML end tags ( #30648 )
2020-05-06 09:20:08 +03:00
XhmikosR
ed94976ea8
Use textContent
instead of innerText
. ( #30462 )
...
It's supported by all of our supported browsers.
2020-03-29 09:53:57 +03:00
Johann-S
26d86fce2a
fix: remove make array util function ( #30430 )
2020-03-25 16:35:02 +02:00
XhmikosR
577bf8b14d
Rename "js/tests/units" to "js/tests/unit". ( #29503 )
2019-10-09 01:27:43 +03:00