0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-11-29 11:24:18 +01:00
Commit Graph

66 Commits

Author SHA1 Message Date
Mark Otto
fc3f4b67d6
Add dark mode support (#35857)
* Add dark mode to docs

* Minor fix: missing space indentation

* Minor fix: revert utilities/z-index added-in modification

* Remove prev: and next: from doc because extracted to another PR

* Use .bg-body-tertiary in all Utilities > Overflow examples

* fix example

* Fix up spacing examples

* Update box-shadow Sass variables and utilities to auto-adjust to color modes

* Remove unused docs class

* Refactor form styles to use CSS variable for background images on .form-check and .form-switch

* Fix docs selector

* Rename shortcut for clarity

* Heading consistency

* Reintroduce missing 4th grid item in Utilities > Spacing example

* Fix bundlewatch

* .bd-callout* rendering is OK so removing comments in the code

* Update scss/_utilities.scss

Co-authored-by: Julien Déramond <julien.deramond@orange.com>

* Fix gutters example styling

* Fix text colors on background utils docs

* redesign and fix up position marker example, which doesn't show nicely in darkmode but at least isn't broken

* fix some color utils examples

* Deprecate mixin notice

* Deprecate notice for list-group-item-variant() mixin

* Revamp new link CSS vars

* Use map-keys in some each Sass files

* Remove list-group-item-variant mixin ref in sass loop desc

* Display CSS vars scoped to our built-in dark mode

* Revert previous commit

* Fix list group variant link

* Fix typo

* Remove imports of alert/list-group mixins in scss/_mixins.scss

* Small formatting + comments removal in scss/_content.scss

* Fix alert links colors

* fix dropdown border-radius mixin

* fix link color and underline again, this time using CSS var override for color var and fallback value for the underline

* fix colors on docs navbar for dark mode

* remove two changes

* missing ref

* another link underline fix, just use sass vars for link decoration for now

* missing color bg docs, plus move dropdown override to scss

* more changes from review

* fix some examples, drop unused docs navbar styles, update docs navbar color mode to use mixin

* Few fixes around type

- Restored CSS variable for color on headings, this time with a fallback value
- In conjunction, restored and wrapped the default CSS var with a null value check
- Split headings and paragraphs docs in Reboot, elaborated on them

* Restyle custom details > summary element in docs

* Rewrite some migration docs

* fix form checks

* Fix up some navbar styling, tweak docs callout

* Fix select images, mostly for validation styling

* Clean up some migration notes, document some new form control CSS vars, mention new variables-dark in sass docs

* Update site/content/docs/5.2/components/scrollspy.md

Co-authored-by: Julien Déramond <julien.deramond@orange.com>

* Apply suggestions from code review

Co-authored-by: Julien Déramond <julien.deramond@orange.com>

* mention form control css vars in migration guide

* Tweak grid and flex docs background examples

* clarify some docs

* fix some more things

Co-authored-by: Julien Déramond <juderamond@gmail.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
2022-11-28 22:30:26 -08:00
Julien Déramond
a153f360ee Fix pagination page items border radius 2022-07-25 16:00:47 -06:00
Mark Otto
427c089961 Stylelint: Disable custom-property-empty-line-before 2022-05-22 19:58:14 -07:00
louismaxime.piton
00d028e646 Adding @include everytime it's not the case 2022-03-31 14:41:02 -07:00
Julien Déramond
7f35bc5b65
Define Pagination font size CSS var (#35917)
Co-authored-by: Mark Otto <markd.otto@gmail.com>
2022-03-24 21:14:42 -07:00
Mark Otto
11751c613f Fixes #36015: Fix pagination link border-radius if statement 2022-03-17 13:39:17 -07:00
Mark Otto
acf6ea74a7
Add additional root variables, rename $variable-prefix to $prefix (#35981)
* Add additional root variables, rename $variable-prefix to $prefix

- Adds new root CSS variables for border-radius, border-width, border-color, and border-style
- Adds new root CSS variables for heading-color, link-colors, code color, and highlight color
- Replaces most instances of Sass variables (for border-radius, border-color, border-style, and border-width) for CSS variables inside _variables.scss
- Updates $mark-padding to be an even pixel number
- Renames $variable-prefix to $prefix throughout

* Bundlewatch
2022-03-13 10:13:09 -07:00
A Web Artisan
ce655ee6f2
Allow to set active and disabled class also to .page-link (#35804)
Sometimes we can set `.active` class only to link tag and not parent.
Since active status style is applied only to `.page-link` and not `.page-item`, would also make more sense to just add the active class to `.page-link` itself.

The other way to set `.active` class to `.page-item` still remain, so there is not BC.

Allow to set also `.disabled` class to `.page-link`

Co-authored-by: Gaël Poupard <ffoodd@users.noreply.github.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <markd.otto@gmail.com>
2022-03-11 21:25:41 +02:00
Mark Otto
48a7160cf4
Convert pagination component to CSS variables (#35399)
* Convert pagination component to CSS variables

* Use RFS mixin

* Remove the useless fallback
2022-02-16 10:26:24 -08:00
Mark Otto
071f914fa1
Add two new variables for pagination border-radius values (#32423)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-12-14 15:34:01 +02:00
Gaël Poupard
9488978fb5 feat(RTL): implement RTL
Using RTLCSS directives, renaming things to use logical names and following best practices.
2020-12-04 07:52:03 +02:00
Samarth Arora
5512dde203 Add transition to Pagination buttons just like other Bootstrap buttons 2020-08-03 09:57:12 -07:00
Martijn Cuppens
b531bda07c Improve gradients
- Use a semitransparent gradient from light to dark which works on any background-color
- Store the gradient as a custom property (--bs-gradient)
- Remove `.bg-gradient-*` variants in favour of `.bg-gradient` which works even when `$enable-gradients` are enabled
- Add gradients to navbar, active page links and badges when gradients are enabled
2020-05-15 15:03:12 +03:00
Martijn Cuppens
7fc4037a02 Remove redundant text decoration from hover states 2020-03-20 09:35:55 +01:00
Martijn Cuppens
d9215ebd5a
$link-decoration: underline affects some components (#30262)
Co-authored-by: Shohei Yoshida <fellows3@gmail.com>
Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com>
2020-03-05 15:22:52 +01:00
Martijn Cuppens
4387038421 Simplify disabled styles (#29296)
* Simplify disabled styles

* Mention pointer-events usage
2019-12-27 18:40:06 +02:00
Martijn Cuppens
007ea0d8d0 Clean up line heights & add line height utilities (#29271) 2019-08-30 10:42:41 +03:00
GeoSot
4ae6a29b12 Allow .page-links to get left margin. (#28948)
* Allow .page-links to get left margin.

* Add border-radius to page-links in case they have left margin

* Apply MartijnCuppens suggestion to _pagination.scss

Co-Authored-By: Martijn Cuppens <martijn.cuppens@gmail.com>

* Plus if/else Rules

* Formatting fixes

* Fix border-radius for pagination-size

* Use mixin for default pagination sizing
2019-08-03 07:11:57 -07:00
Martijn Cuppens
f5f09d8b0b
Remove redundant border radius on pagination (#28980)
Pagination used to have box shadow back in the days which required this property, but nowadays it's redundant. (see 0cd186183c/less/pagination.less (L17))
2019-07-02 08:08:12 +02:00
Shohei Yoshida
1a41b0ffa6 Fix z-index according to our z-index rule (#28784)
https://getbootstrap.com/docs/4.3/extend/approach/#z-index-scales
2019-05-18 16:30:57 +02:00
Martijn Cuppens
e1b990fb90 Move hand cursor for buttons to reboot 2019-01-04 11:53:32 +02:00
Patrick Yeo
4f35e53216 Pagination move .page-link:focus outline value to variable $pagination-focus-outline so we can unset it via Sass and don't have to re-implement browser defaults 2018-04-01 18:16:49 -07:00
Martijn Cuppens
5158338b7c Fix pagination buttons hover z-index (#25532) 2018-02-03 09:54:08 +02:00
Patrick H. Lauke
1f490ec165
Consistently use :disabled rather than [disabled] selector (#25317)
Closes https://github.com/twbs/bootstrap/issues/25316
2018-01-15 20:51:01 +00:00
Mark Otto
2dc5762f96 Update pagination focus styles
- Drops the hover-focus mixin for standard :hover
- Adds explicit :focus styles to match button, input, etc with a box-shadow
- Adjusts z-index values to ensure the layers go initial, hover, active, focus

Fixes #24838.
2018-01-02 21:49:01 -08:00
patrickhlauke
e3f9c463fc Opinionated: reintroduce cursor:pointer
Explicitly re-adds the "hand" `cursor:pointer` for non-disabled `.btn`, `.close`, `.navbar-toggler` elements, as well as forcing `page-link` pagination controls to always have the "hand" cursor (even if an author uses it on, say, `<button>` elements for a dynamically updating in-page pagination).

Controversial, as everybody jumped on the bandwagon following this article https://medium.com/simple-human/buttons-shouldnt-have-a-hand-cursor-b11e99ca374b - which does have its merits of course, but there are also counter-arguments like http://kizu.ru/en/issues/cursor-pointer/

And seeing the amount of issues we've seen following the change, and the potential complexity needed to consistently address the cursor issue (see https://github.com/twbs/bootstrap/issues/24156 where i explore how the cursor needs to be based on "intent", and how that's tough to determine), I'm favouring an opinionated take here of just reintroducing the `cursor:pointer`.
2017-12-27 16:28:10 -08:00
XhmikosR
52d99a887e Refactor a few selectors. (#24404)
1. move a couple of them before the more specific ones.
2. change nesting to be under the same parent selector
3. use the ampersand more
2017-10-23 00:17:28 +03:00
rmacklin
9e6dabbb10 Reduce z-indexes in button-group, input-group, list-group, and pagination to the minimum necessary (#24315)
These were using `z-index: 2` to "Place active items above their
siblings for proper border styling". However, using `z-index: 1` is
sufficient for accomplishing that goal.

In input-group, there were also three `z-index: 3` rules for the
hover/focus/active states. I reduced these to `z-index: 2` since they
just needed to be "one more than normal" (i.e. one more than what is now
`z-index: 1` after my changes).

These changes can be verified by viewing the documentation pages for
Button group, Input group, List group, and Pagination before and after
this commit and observing that the active elements are still "above"
their siblings, so their borders look correct.
2017-10-20 10:01:29 +03:00
Andres Galante
bbb6ab1275 changes reset for mixin list reset on pagination 2017-09-30 23:36:30 -07:00
Patrick Yeo
34257d25a5 Pagination border-widths greater than 1px cause uneven borders between items 2017-08-10 23:24:37 -07:00
Patrick Yeo
dd0ce3e4b2 Rename variable $input-border-focus to $input-border-color-focus (#22413)
* Rename variable $input-border-focus to $input-border-color-focus
* Rename variables $pagination-hover-border, $pagination-active-border, $pagination-disabled-border to $pagination-hover-border-color, $pagination-active-border-color, $pagination-disabled-border-color, respectively
* Rename variables $state-*-border to $state-*-border-color, respectively
* Rename variables $alert-*-border to $alert-*-border-color
* Rename $list-group-active-border to $list-group-active-border-color
* Rename $table-inverse-border to $table-inverse-border-color
* Rename $btn-*-border to $btn-*-border-color
* Rename $navbar-*-toggler-border to $navbar-*-toggler-border-color
2017-04-16 15:45:10 -07:00
Patrick H. Lauke
7056f70240 Remove cursor: not-allowed styles 2017-04-10 22:10:20 +01:00
Mark Otto
d91481397e linting 2016-12-28 15:13:43 -08:00
Mark Otto
3fd9557cfd no need to float, but do set display: block;
this, coupled with the move to flex, fixes #20029
2016-12-28 15:13:43 -08:00
Mark Otto
79fd05d209 remove plain-hover-focus mixins 2016-12-28 15:13:43 -08:00
Mark Otto
bd6e047152 no need for cursor: default, since, well, it's the default 2016-12-28 15:13:43 -08:00
Mark Otto
c52049e5a7 add a comment here to explain some things 2016-12-28 15:13:43 -08:00
Mark Otto
e3d01a326b .page-item's don't need this anymore (they're flex items) 2016-12-28 15:13:43 -08:00
Mark Otto
e81aa62af6 remove default margin, allow folks to use utils instead 2016-12-28 15:13:43 -08:00
Mark Otto
645330a755 update pagination list reset styles 2016-12-28 15:13:43 -08:00
Mark Otto
c73bea60de move pagination to flexbox 2016-12-28 15:13:43 -08:00
Stefan Staynov
0051be1657 Set line-height for page-links (#21052) 2016-11-27 23:37:36 -08:00
Mark Otto
c13215d038 Fixes #21094: Move text-decoration override from the default link state to the hover/focus state so it can override the global styles properly 2016-11-23 11:37:56 -08:00
Mark Otto
ba37c37615 Redo line-height globally
- Rename -height to -height-base to match other vars
- Drop use of -height across the board and rely on it to be inherited
- Adjust padding of .dropdown-header to account for different line-height of h6 heading element (this needs refactoring for variables and rems also)
2016-02-03 19:45:13 -08:00
Patrick H. Lauke
348763d65c Add pointer-events:none to disabled pagination/pager links
as currently this was missed out (compared to disabled `a.btn`)
2015-12-27 10:03:09 +00:00
Chris Rebert
8b0d737a56 scss/_pagination.scss: Reassert #18257
[skip sauce]
2015-12-08 00:01:58 -08:00
Mark Otto
4dd60d8310 fix variable 2015-12-07 23:46:56 -08:00
Chris Rebert
e7edf10473 .page => .page-item 2015-12-07 22:37:17 -08:00
Chris Rebert
0c1df9912f Refactor pagination code to remove unnecessary ancestor requirements in selectors 2015-12-07 22:37:17 -08:00
Chris Rebert
5f35ce2095 .page>{a,span => .page-link} 2015-12-07 22:37:17 -08:00