0
0
mirror of https://github.com/twbs/bootstrap.git synced 2024-12-01 13:24:25 +01:00
Commit Graph

1677 Commits

Author SHA1 Message Date
Andrew Luca
bd2851938a test(Modal): check if modal is disposed 2018-10-30 16:28:32 +01:00
Andrew Luca
65dc8c9070 refactor(Modal): add _isTransitioning default value
Having variables initialised from start `_isTransitioning` is better.
Would be better to add an eslint rule to check for undeclared variables use.
Reordered enter checks for `show` and `hide` by priority.
2018-10-30 16:28:32 +01:00
XhmikosR
02df7cd0d2
Fix util tests on IE 10 (#27556) 2018-10-30 15:29:04 +02:00
Martijn Cuppens
5aed968750 Prevent the background to be shown when transitioning 2018-10-30 08:57:02 +02:00
Johann-S
2868f07240 update our coverage required for branches and functions 2018-10-29 14:49:29 +01:00
Johann-S
91f8077ed5 add unit tests for our carousel 2018-10-29 14:49:29 +01:00
Johann-S
2c2d04aba5 add unit test to test tabs can be removed without throwing error 2018-10-29 14:01:03 +01:00
dercodercom
a282c22fc7 Update tab.js
I'm using Tab.js with remove function and get an error "TypeError: container is undefined [more info]", with this check the error is fixed.
2018-10-29 14:01:03 +01:00
Martijn Cuppens
45610a0f39 fix tab fade out (#27533) 2018-10-29 09:54:45 +01:00
Johann-S
ffc8d507c7 calculate modal transition duration based on modal-dialog element 2018-10-28 23:59:17 +02:00
Andrew Luca
1f1308ba22 test(Modal): reuse _getScrollbarWidth in tests 2018-10-21 17:45:02 +02:00
XhmikosR
0a3755b30a
Fix typo in the Popper.js checks. (#27488) 2018-10-21 11:51:20 +03:00
Johann-S
b1dc6b324c avoid drag img 2018-10-20 15:32:09 +03:00
patrickhlauke
8883ccb205 Set touch-action to "none"
Firefox currently seems extremely fickle - with `pan-y` if fires pointercancel as soon as a touch strays even a pixel or so vertically.
While `touch-action: pan-y` would be ideal (allowing users to scroll the page even when their finger started the scroll on the carousel), this prevents a swipe that isn't perfectly/only horizontal to be recognised by Firefox.
2018-10-20 15:32:09 +03:00
patrickhlauke
9164f77269 Refactor (and correct) start/move/end functions
in particular, no need to use originEvent, and preventDefault() only needed for touch events
2018-10-20 15:32:09 +03:00
patrickhlauke
39ae077837 Remove unnecessary pointer event listeners
these may also be the cause of weird behavior in Chrome/Surface, where scrolling vertically triggers slide advance
2018-10-20 15:32:09 +03:00
patrickhlauke
6be7293a85 Abandon swipe altogether if more than one touch detected 2018-10-20 15:32:09 +03:00
patrickhlauke
7b8f01d839 Use correct touch-action values
- my fault, my original advice of using `touch-action: pan-x` is exactly the value we *don't* want to have the browser handle...
2018-10-20 15:32:09 +03:00
Johann-S
735c374e9c use pointer events if available 2018-10-20 15:32:09 +03:00
Johann-S
c08652cfe8 swipe left/right without hammerjs 2018-10-20 15:32:09 +03:00
Johann-S
caefd70463 Add touch support in our carousel with HammerJS. 2018-10-20 15:32:09 +03:00
galczo5
6cbcd03efb Add show and hide methods to dropdown (#27370) 2018-10-20 14:27:51 +03:00
XhmikosR
ea575bc1a7 js/tests/visual: fix popper script.
Broken after 787441d.
2018-10-14 08:17:40 +03:00
XhmikosR
339311ddb5 Fix invalid selectors in tests and examples. 2018-10-14 08:17:40 +03:00
Johann-S
7c7a1706c3 remove useless iife 2018-09-26 15:03:38 +02:00
Mark Otto
f6244654a6 dist 2018-09-18 21:35:40 -07:00
Christopher Morrissey
ea0faadde5 feature(carousel): carousel-item interval (#26667)
adds the ability to assign data-interval to an individual carousel-item
2018-09-18 15:55:48 +03:00
XhmikosR
787441d4bf docs: use the bundle dist file. 2018-09-18 12:50:18 +03:00
Mark Otto
b68ea572da dist 2018-09-17 12:34:34 -07:00
XhmikosR
0b97d1b0c4 Use https in more places and fix a few redirects. 2018-09-14 18:27:55 +03:00
Johann-S
a689120fd2 throw error when folks try to use a bad selector 2018-09-13 22:13:36 +02:00
Johann-S
9efed82522 refactor karma config in one file 2018-09-13 21:59:37 +02:00
Johann-S
c543f360c9 do not use coverage files on browserstack 2018-09-13 21:59:37 +02:00
Johann-S
6e2a823a44 collapse children with no data-parent 2018-09-10 21:10:00 +02:00
Johann-S
a3e45d8ced
add information about valid selectors (#27137) 2018-08-31 21:00:29 +02:00
Johann-S
54d86e6249 move away from sauce labs to browserstack 2018-08-30 22:17:15 +02:00
Mark Otto
c0fd91788e dist 2018-08-18 20:22:08 -07:00
XhmikosR
acd19de6a9 Use ES6 arrow function. 2018-08-12 22:22:12 +03:00
Johann-S
eab9da5beb fix(util): use querySelector for ids 2018-08-12 17:01:01 +02:00
Johann-S
6b92321f6a fix(util): use getElementById when it's possible 2018-08-07 18:49:02 +02:00
jarstelfox
198091d635 Fix dispose causing popover title to change
see: https://github.com/twbs/bootstrap/issues/26847
in v4, destroy was replaced by dispose
2018-08-02 13:51:08 +02:00
Mark Otto
3b55873438 Ship v4.1.3 2018-07-24 08:54:34 -07:00
Mark Otto
72447ad497 dist 2018-07-23 17:51:14 -07:00
Johann-S
d18045210c fix(tests): visual plugins tests 2018-07-23 17:29:53 -07:00
Mark Otto
c4ccfbe04e Ship v4.1.2 2018-07-12 09:27:14 -07:00
Mark Otto
0e920ce3f4 Reorganize docs for easier deploys
With the current docs directory setup, I'm making too many mistakes and have to manually address path changes and directory moves on deploy. This makes for a frustrating experience developing locally and shipping releases. With this PR, we're basically back to the same setup from v3—duplicating the dist directory into our docs directory. Not the most ideal, but very straightforward for me as the release manager.
2018-07-11 23:30:46 -07:00
Mark Otto
9e126b26a8 dist 2018-07-11 21:42:55 -07:00
Johann-S
283ab30164 fix(modal): fix unit test and resetting style 2018-07-11 11:05:38 +02:00
Catalin Zalog
cb82394fc8 fix(modal): removes .navbar-toggler margin 2018-07-11 11:05:38 +02:00
Johann-S
e57a2f244b fix(tooltip): get tip on placement change 2018-06-25 16:54:14 +02:00
jakubhonisek
49e094619b feat(dropdown): add original click event 2018-06-25 15:29:34 +02:00
Mark Otto
eadeab9d1c dist 2018-06-21 22:55:23 -07:00
Johann-S
a79b8aa16a refactor(plugins): query elements without jquery 2018-06-03 11:40:08 +02:00
Johann-S
b1eb3fccfa refactor(plugins): improve how we query elements 2018-06-01 10:30:11 +02:00
Johann-S
cc61edfa8a fix(scrollspy): xss in target option 2018-06-01 09:10:25 +02:00
Johann-S
149096016f fix(collapse): xss in parent option 2018-06-01 09:10:25 +02:00
Johann-S
2d90d369bb fix(tooltip): xss in container option 2018-06-01 09:10:25 +02:00
Johann-S
f2aab5ea99 fix(tooltip): remove useless unit test 2018-05-22 17:26:21 +03:00
Johann-S
0338b61eb6 chore(deps): update qunit and karma-qunit 2018-05-22 17:26:21 +03:00
Mark Otto
779ad9f174 Bump version to v4.1.1 2018-04-30 09:04:33 -07:00
Mark Otto
496311bf97 dist 2018-04-29 22:22:04 -07:00
XhmikosR
5fd67a6f86 Bump version to 4.1.0 for remaining files. 2018-04-16 09:37:58 +03:00
Johann-S
ba10b63c9d fix issue related to Object.keys and Dropdown issue 2018-04-13 18:59:30 +02:00
Swardu
c3caf7ee4e Docs/examples: change links to Sass documentation and example.com to https 2018-04-12 11:56:33 +01:00
MietekN
418fd76ba9 modal use global scope for default 2018-04-12 11:21:10 +02:00
Johann-S
0871d69ec9
v4 improve coverage (#25945)
* Improve code coverage for our Button plugin

* improve coverage for our Alert plugin

* test tooltip update method

* test update and dispose for dropdown

* increase code coverage requirements
2018-04-10 09:28:29 +02:00
XhmikosR
875ed0b975 Clean up globals.
Also, add a missing license header in build/workbox.js.
2018-04-09 22:44:22 +03:00
Mark Otto
8f7bd41993
Ship v4.1.0 (#26218)
* update docs path from docs/4.0/ to docs/4.1/

* bump version to 4.1.0

* Update redirects to work for 4.1 docs move

* Update docs version switcher to include latest and link to 4.0 docs

* re-run dist

* Update package-lock.json

* Update docs-navbar.html
2018-04-09 09:00:23 -07:00
XhmikosR
95cdfa2a65 Use https when possible. 2018-04-02 19:19:09 +03:00
Mark Otto
b744ba2c08 dist 2018-03-31 13:59:37 -07:00
Johann-S
fd57d371f8 fix bundle and run test against it 2018-03-29 21:21:31 -07:00
vsn4ik
68db42c9f8 Fix skip element disabled via attribute when using keyboard navigation 2018-03-26 09:37:25 +02:00
XhmikosR
2cd700313d Remove the local jquery-1.9.1.min.js. 2018-03-21 12:15:47 +02:00
XhmikosR
f5e16ceccc tests: load 3rd-party libs from the local node_modules folder.
This reduces duplication and the chances to forget to update something.
2018-03-21 12:15:47 +02:00
XhmikosR
e0ab096bac Update all devDependencies.
Kept back karma-qunit and qunitjs because tests fail.
2018-03-21 12:15:47 +02:00
XhmikosR
1615a76f83 Use sinon from cdnjs. 2018-03-21 12:15:47 +02:00
XhmikosR
7d3ca1b2ea tests: use QUnit from the jQuery CDN. 2018-03-21 12:15:47 +02:00
Johann-S
9191fa73df throw error when coverage is under our thresholds 2018-03-21 07:04:24 +01:00
Johann-S
bedc96e48b Use transitionEnd in QUnit since we moved away from PhantomJS 2018-03-20 15:56:51 +01:00
Johann-S
4d5c5923fa Add Sinon to do better unit test 2018-03-13 15:37:11 +01:00
Johann-S
2c41b0aea6 fix get the transition duration parent 2018-03-13 12:57:44 +01:00
Martijn Cuppens
1fadad1c33 Variable transition durations (#25662) 2018-03-13 09:59:20 +01:00
Johann-S
fb60a4a986 Add a bit of documentation on how to run the code coverage (#25783) 2018-03-06 07:35:28 +02:00
Johann-S
e43f97304e add code coverage 2018-03-05 10:04:54 +01:00
Mark Otto
a651d7337b dist 2018-03-03 14:10:49 -08:00
Ed Morley
b33316dba3 Fix leftover reference to v4.0.0-alpha.6
Running `./build/change-version.js v4.0.0-alpha.6 v4.0.0` fixed this,
so the version change script works fine. I'm presuming instead this
change was just omitted from 35f80bb12e, and then wouldn't have
been caught by subsequent runs of `change-version`, since it only
ever replaces the exact old version string specified.
2018-03-03 21:07:35 +01:00
Martijn Cuppens
29f178d891 Remove unused variable (#25670)
This variable is not used anywhere.

Leftover from #18373.
2018-02-25 11:22:50 +02:00
Mark Otto
f3cec5e7f9 dist 2018-02-24 12:44:44 -08:00
Martijn Cuppens
8cfbf6933b Consistent usage of $(document.body) instead of $('body') (#25671) 2018-02-21 09:01:02 +01:00
Mark Otto
6a52ebfe1a dist 2018-02-19 14:50:56 -08:00
Martijn Cuppens
3dd0bde664 Fix carousel transition duration (#25218) 2018-02-19 10:10:25 +01:00
Johann-S
65ae622d40 Dropdown - Allow to disable Popper.js style (#24092)
* Dropdown - Allow to disable Popper.js style

* Update dropdown.js

* Update dropdown.html

* copy changes
2018-02-11 16:45:59 -08:00
Mark Otto
e373fbea92 dist 2018-02-11 14:53:29 -08:00
Johann-S
5a6be71791 Remove escaping selector and add a warning to inform folks to escape their selectors (#25390) 2018-01-21 22:02:16 +02:00
denisx
db70164d13 ignore case (#25373)
Less on 2 symbols
2018-01-21 21:51:49 +02:00
719media
bd9084d249 Update dropdown.js to allow referenceElement (#25219) 2018-01-21 19:09:23 +01:00
Mark Otto
572d00ac7e Bump version to 4.0.0 2018-01-18 10:24:51 -08:00
Mark Otto
6d8d8639f3 dist 2018-01-11 22:42:40 -08:00
XhmikosR
80d0943b95 Comply to the new rules. 2018-01-11 18:48:46 +02:00
XhmikosR
6d336502c7 Clean up and tweak ESLint rules.
Also, refactor ESLint and stylelint config files; now everything will work from our root dir.
2018-01-11 18:48:46 +02:00
Łukasz
1a231e4bee Check for window before window.QUnit (#25199) 2018-01-08 13:15:22 +01:00
Mark Otto
34cd2038d2 dist 2018-01-03 16:03:22 -08:00
Martijn Cuppens
a1d134f8a8 Multiple accordion support (#25161) 2018-01-03 16:40:58 +02:00
Mark Otto
44eebe40de dist 2018-01-01 20:29:19 -08:00
Martijn Cuppens
ae71e71fe1 Allow nested structure for accordions (#25121)
This commit allows nested structures for accordions. Also a part of
the documentation about data-children is removed because this
functionality didn't work and it's not applicable anymore.

Tests with the collapse accordion are also a bit adjusted to the new
situation.
2017-12-31 14:53:33 +02:00
Mark Otto
5b8eaffc12 dist 2017-12-30 19:41:36 -08:00
XhmikosR
bf0e753517
Update devDependencies and gems. (#25083) 2017-12-31 02:03:22 +02:00
Mark Otto
ced70da441 Update version to 4.0.0-beta.3 2017-12-28 09:50:04 -08:00
Mark Otto
935d45f461 dist 2017-12-22 16:21:54 -08:00
Troy Morehouse
6f1e746d70 tooltip+popover: add boundary config option (#24979) 2017-12-12 11:36:54 +02:00
Troy Morehouse
8839c03865 dropdown: add boundary config option (#24976) 2017-12-12 11:28:30 +02:00
Mr_Green
9d373d7112 Use only transitionend event (#24962) 2017-12-07 12:10:18 +01:00
Johann-S
a07bc5dbcb Update README.md (#24912) 2017-11-29 18:42:09 +02:00
Alessandro Chitolina
80d4a51e79 tab.js: do not remove fade class if there's no initial active pane 2017-11-26 20:29:19 +01:00
Johann-S
e8ba37139f Allow us to run our unit test on differents jquery version 2017-11-23 10:41:56 +02:00
Edward Betts
ffc5965f2c Correct spelling mistakes. (#24778) 2017-11-15 04:12:38 -05:00
Vasilii Artemchuk
2cafb9f127 Simplify spread (#24774) 2017-11-15 09:44:17 +01:00
Johann-S
9a0bba9afa
Object spread : less jQuery more ES6 (#24665) 2017-11-13 11:25:36 +01:00
Vasilii Artemchuk
5a2d6c70f4 Use native pseudo-selectors instead of jQuery selectors (#24713) 2017-11-09 07:51:19 +02:00
Mark Otto
9c213b7f27 upgrade to node 8.9.x and dist 2017-11-07 22:45:26 -06:00
XhmikosR
4bacf8dd04 Update devDependencies. 2017-11-08 01:04:31 +02:00
XhmikosR
fc9967e175
Fix test failure with jQuery 1.9.1 (#24706) 2017-11-07 14:13:52 +02:00
Johann-S
79d6b574cc
Escape ID in Util.getSelectorFromElement (#24700) 2017-11-07 12:41:06 +01:00
Johann-S
26dc17bcd2 Popover - call content once if it's a function. (#24690) 2017-11-07 09:18:52 +02:00
patrickhlauke
96a9fa1c82 Remove invalid example of title attribute in an SVG and related vnu error suppression 2017-10-31 21:36:17 +02:00
Mark Otto
2fec9f13cd dist 2017-10-30 12:48:13 -07:00
Johann-S
6d00ed586b Do not create a Popper.js instance when we don't need it 2017-10-30 09:51:57 +01:00
Mark Otto
c5af0a7d6a dist 2017-10-29 16:19:14 -07:00
Johann-S
2232b6b4d1 Throw error about Popper.js only when it's needed because some of our plugins don't use it (#24573) 2017-10-29 15:51:04 -07:00
Johann-S
e454c8ec1e Add dropright and dropleft (right and left placements for our dropdown) (#23860)
* Add dropright (right placement for our dropdown)

* Add dropleft

* moves drop left arrow to the left
2017-10-29 15:29:13 -07:00
Mark Otto
bc53cb8bc5 dist 2017-10-28 12:04:47 -07:00
Johann-S
41fbec1188 Fix unit tests. 2017-10-27 19:19:55 +03:00
Pierre-Denis Vanduynslager
6fe72c6de8 Dropdown handle keydown on input and textarea. 2017-10-27 19:19:55 +03:00
Mark Otto
8c587d4280 dist 2017-10-25 12:31:55 -07:00
Johann-S
988327032d Add unit tests for util.js 2017-10-25 12:59:40 +02:00
Johann-S
62fbb23ee6 Change Rollup config to wrap our dist files with jQuery instead of $ 2017-10-24 12:39:25 +02:00
XhmikosR
ca4ad8bee8 Clean up transitionEnd properties. (#24511)
We don't support Opera 12, and Firefox's property was the unprefixed one.
2017-10-23 10:45:27 +03:00
Johann-S
1487c3a994 Add Util.jQuery which will detect jQuery instead of relying on global $ (#24513) 2017-10-23 10:35:27 +03:00
XhmikosR
2ef5b90136 Tighten htmllint's rules. (#24471) 2017-10-22 15:02:24 +03:00
Mark Otto
dbf5405cfd fix version number 2017-10-19 12:23:29 -07:00
Mark Otto
cf00548f4e new version number 2017-10-19 12:23:29 -07:00
Mark Otto
6124e7f229 dist 2017-10-19 09:13:17 -07:00
XhmikosR
d763d019ad Make 1.9.1 the minimum jQuery version again. (#24434) 2017-10-19 09:02:27 -07:00
Mark Otto
7ce2b03b1a dist 2017-10-15 15:51:44 -07:00
Johann-S
8e7ba02c5c Modal plugin set _isTransitioning after the trigger of hide event 2017-10-10 14:19:22 +02:00
Vasilii Artemchuk
1aea9d7517 Update js/tests/README.md (#24281) 2017-10-07 01:04:21 +03:00
Johann-S
347b3ac1c0 Remove global jQuery in eslint because we import jQuery (#24246) 2017-10-04 17:31:35 +03:00
XhmikosR
be9e6f3638 Update modal.js 2017-10-04 15:03:06 +03:00
lucascono
47968c8126 Unit test for modal bug fix
Unit test for pull request #24240
2017-10-04 08:55:40 -03:00
lucascono
4b6537bef3 Fix modal bug
Fix for issue #24117
2017-10-04 06:08:34 -03:00