Rohit Sharma
e140ff92ed
Remove .nav-item from .nav-link to make it consistent
...
- Closes #28423
2020-06-09 07:48:58 +03:00
Rohit Sharma
5faf41eb48
Add role="dialog" in modals via JavaScript ( #30936 )
2020-06-04 10:35:09 +03:00
XhmikosR
340236cbe4
Update to @rollup/plugin-babel
( #30742 )
2020-05-26 06:14:12 +03:00
Mark Otto
d2f07ec9e1
Fix some easy Markdown linting issues
...
- Always use dashes for bullets
- Add some basic alt text for our readme OC sponsors
2020-05-18 16:28:22 +03:00
XhmikosR
7966167cf6
Replace double tilde with Math.floor
( #30691 )
...
Nowadays, browser engines have improved a lot and `Math.floor` is the same, if not faster.
Also, clarity is better than micro-optimizations in this case.
2020-05-14 09:46:42 +03:00
XhmikosR
b07b342086
Partially Revert "Use regex.test() when we want to check for a Boolean. ( #29969 )" ( #30770 )
...
This partially reverts commit 9c2b9ac74d
.
2020-05-13 22:49:41 +03:00
XhmikosR
38ec7c4df7
Bump version to 5.0.0-alpha1 ( #29925 )
...
Also add v4.5.0 in versions and keep README.md pointing to v4.5.0 so that there are no broken stuff.
2020-05-13 22:36:00 +03:00
XhmikosR
de7af5ee07
Dist ( #30694 )
2020-05-13 21:53:43 +03:00
XhmikosR
fbdacc0e92
coverage: ignore node_modules
2020-05-12 08:31:38 +03:00
Dominik Kremer
d59de33fc0
Add a test about the scrollbar issue on non-integer width
2020-05-12 07:51:09 +03:00
Giovanni Mendoza
3e7566f2c3
Avoid bad scrollbar replacement into width values
2020-05-12 07:51:09 +03:00
XhmikosR
94109cabf4
Add missing closing div
tags ( #30775 )
...
Missed those in 967e607
2020-05-11 16:54:56 +03:00
Rohit Sharma
ec3cfae29c
Removed role="document" from the modal dialog ( #30755 )
2020-05-11 12:45:42 +03:00
XhmikosR
737b6925ab
Revert "Avoid bad scrollbar replacement into width values ( #30690 )"
...
This reverts commit 85c4788ded
.
2020-05-06 21:25:59 +02:00
XhmikosR
967e6071ba
tests: streamline HTML end tags ( #30648 )
2020-05-06 09:20:08 +03:00
Johann-S
650a7a7b76
add unit tests to ensure our plugins works in jquery
2020-05-06 07:55:48 +02:00
Johann-S
f91788548c
enforce element check on scrollspy target ( #30747 )
2020-05-06 07:30:43 +03:00
XhmikosR
122c99ebeb
BrowserStack: test Edge 16 too ( #30725 )
2020-05-05 22:10:16 +03:00
XhmikosR
345fd1fe4c
Revert "Update karma.conf.js"
...
This reverts commit b8abded0af
.
2020-05-05 17:34:48 +03:00
XhmikosR
db80eb96fa
Move babel whitelist helpers to a common file ( #30723 )
2020-05-04 20:08:28 +03:00
XhmikosR
b8abded0af
Update karma.conf.js
...
Use the recommended karma-browserstack-launcher settings
2020-05-04 20:01:29 +03:00
XhmikosR
727e09b641
scrollspy.js: remove temporary variable ( #30724 )
2020-05-04 19:43:50 +03:00
XhmikosR
37f2c04c5f
Clean up lint rules ( #30721 )
...
* Remove unneeded rule suppression
* Format tests/unit/.eslintrc.json
* build/.eslintrc.json: add strict for consistency
2020-05-04 19:32:09 +03:00
Johann-S
85c4788ded
Avoid bad scrollbar replacement into width values ( #30690 )
2020-04-29 22:28:20 +03:00
Martijn Cuppens
c8d68fbec7
Drop closest from SelectorEngine ( #30653 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-04-28 22:17:23 +03:00
Tanguy Krotoff
d2ed920b15
Remove caret element ( #30633 )
2020-04-24 21:53:31 +02:00
Tanguy Krotoff
7787f642b9
Fix crash when pressing ArrowUp the first time
2020-04-17 18:22:15 +03:00
Tanguy Krotoff
d7f0f1aac9
Replace event.delegateTarget with event.target
...
No need for fixEvent() anymore
2020-04-17 18:22:15 +03:00
Tanguy Krotoff
dcd99aa7d1
Replace event.which with event.key and event.button
2020-04-17 18:22:15 +03:00
XhmikosR
8547ab149a
collapse: don't rely on implicit conversion ( #30566 )
...
`config` can be an `Object` and we only need to test for `hide` or `show` if it's a `String`
2020-04-17 15:09:51 +03:00
XhmikosR
9a5033d413
Pass multiple classes to classList.add
/ classList.remove
( #30537 )
...
This is supported by our currently supported browsers.
2020-04-09 20:56:43 +03:00
ysds
dfa017adc3
Always modal scroll top to 0
2020-04-01 10:05:43 +03:00
Martijn Cuppens
c48d89cb70
Use unordered lists in dropdown-menus
2020-03-31 22:52:57 +02:00
XhmikosR
e1f5d819c7
Remove MSPointerEvent
and ms-touch-action
in tests ( #30463 )
2020-03-29 09:59:54 +03:00
XhmikosR
ed94976ea8
Use textContent
instead of innerText
. ( #30462 )
...
It's supported by all of our supported browsers.
2020-03-29 09:53:57 +03:00
XhmikosR
74afe149c4
Dist ( #29924 )
2020-03-28 12:29:08 +02:00
XhmikosR
f761d8e801
Remove holder.js leftovers ( #30469 )
2020-03-28 12:07:14 +02:00
Laussel Loïc
7ce29d75f3
v5 tabs - accessibility issue when using ul/li semantic
...
Add aria-role presentation on li element when ul element has role tablist and remove dropdown from visual tests as they've been removed from doc
2020-03-28 09:51:24 +02:00
Johann-S
fe492d8021
fix babel config in our files
2020-03-25 22:32:37 +02:00
Johann-S
26d86fce2a
fix: remove make array util function ( #30430 )
2020-03-25 16:35:02 +02:00
Martijn Cuppens
2e150e722a
Use next dropdown menu instead of first of the parent
2020-03-23 15:35:07 +01:00
XhmikosR
018a94c9c1
Remove Internet Explorer leftovers
2020-03-18 20:59:27 +02:00
Johann-S
47aef7b2c6
Remove IE compatibility JS code
2020-03-18 20:59:27 +02:00
Johann-S
aff115219e
fix: ensure totype
always returns stringified null/undefined when null/undefined is passed ( #30383 )
2020-03-18 13:10:55 +02:00
XhmikosR
38333feda5
Switch to strings constants.
...
This allows the minifier to mangle the constants. It also allows the linter to find unused strings properly.
While at it, remove a few unused properties.
File Before After Diff
--------------------------------------------------------
bootstrap.bundle.min.js 23.61 kB 22.61 kB -1.00 kB (-4.23 %)
bootstrap.min.js 17.04 kB 16.08 kB -0.96 kB (-5.63 %)
2020-03-18 12:58:54 +02:00
Sparks
c47547cd09
Improvement: harmonize usage of constants ( #30285 )
2020-03-09 17:26:29 +02:00
Martijn Cuppens
7d8c7c4ba8
prev()
function fails when non-element nodes are present (#30117 )
...
The `prev()` function doesn't take nodes other than elements into account. Also we could simplify things a lot using the `previousElementSibling` property. This property isn't fully supported in IE, it only works for elements, but since the `element` variable is an element, we can safely use it here.
I've also added an additional test.
I don't think we had this issue in v4, since we relied on jQuery back then.
Ref. https://developer.mozilla.org/en-US/docs/Web/API/NonDocumentTypeChildNode/nextElementSibling
2020-03-09 17:21:04 +02:00
yonikohen
7a60dcf9b0
Corrected grammatical error in test descriptions ( #30150 )
...
"without instantiate it" should be "without instantiating it"
2020-02-10 09:35:13 +02:00
Martijn Cuppens
ef6c13c534
tests: Remove button href
s ( #30119 )
2020-02-01 20:39:18 +02:00
Giovanni Mendoza
954a0b1e6a
Close modal with keyboard=true & backdrop=static ( #29986 )
...
* Close modal with keyboard=true & backdrop=static
2020-01-10 11:06:12 +02:00