Chris Rebert
eb350d1a7c
Upgrade to latest version of JSCS (v3.0.4) ( #20070 )
...
Fixes #20002
[skip sauce]
[skip validator]
2016-06-04 17:55:21 -07:00
Chris Rebert
04165ba6e3
Update ESLint to v2.11.1 (latest stable) ( #20068 )
...
Fixes #19908
[skip sauce]
[skip validator]
2016-06-04 17:08:59 -07:00
Chris Rebert
d1b8ec85e2
Upgrade ESLint to v2.9.0 ( #20047 )
...
Refs #19908
[skip sauce]
[skip validator]
2016-06-04 15:07:16 -07:00
Chris Rebert
2b16f5c510
Update ESLint to v2.5.3 ( #20043 )
...
Refs #19908 .
[skip sauce]
[skip validator]
2016-06-04 14:28:34 -07:00
Chris Rebert
92ec110f08
Upgrade ESLint to v2.3.0 ( #20041 )
...
Refs #19908
[skip sauce]
2016-06-04 14:01:12 -07:00
Chris Rebert
5dcd1a743d
Tweak Esc key comment in modal.js
...
[skip sauce]
[skip validator]
2016-05-31 02:19:56 -07:00
Chris Rebert
92e9d9de62
Enable new ESLint-recommended rules in ESLint config
...
Refs http://eslint.org/docs/user-guide/migrating-to-2.0.0#new-rules-in-eslintrecommended
2016-05-31 00:49:48 -07:00
Chris Rebert
4d3bd8e6c5
Migrate parser & env config to ESLint 2.0.0
2016-05-31 00:46:33 -07:00
Chris Rebert
c4add0c2f3
Comply with consistent-return ESLint rule
2016-05-31 00:45:32 -07:00
Chris Rebert
0efec1a3db
Migrate ESLint rules config to ESLint 2.0.0
...
Refs http://eslint.org/docs/user-guide/migrating-to-2.0.0
2016-05-31 00:39:39 -07:00
Chris Rebert
9324da7aeb
Upgrade ESLint to v1.10.3
...
Refs #19908
2016-05-31 00:12:17 -07:00
Chris Rebert
00a3e1d9ad
Upgrade ESLint to v1.9.0
...
Refs #19908
2016-05-30 23:59:24 -07:00
Chris Rebert
324cbb2280
Upgrade ESlint to v1.7.3
...
Enable new rules:
* no-empty-pattern
* no-magic-numbers (exempting 0 and ±1)
Refs #19908
[skip sauce]
[skip validator]
2016-05-30 23:42:22 -07:00
Chris Rebert
5a35ad6d74
Use named constants for magic numbers ( #19992 )
...
Mostly KeyboardEvent.which and MouseEvent.which values.
[skip validator]
2016-05-30 23:42:00 -07:00
Chris Rebert
14c7ba95f9
Fix load & scroll event usage in ScrollSpy tests ( #19986 )
...
* Use $.one() instead of $.on() since there are no $.off()s in the code.
* Remove unnecessary namespacing of listeners for the `scroll` & `load` events.
These are vanilla DOM events (not custom jQuery namespaced events)
and we're not using jQuery namespacing to manage these event listeners either (e.g. `$.off()`).
[skip validator]
2016-05-30 09:39:45 -07:00
Chris Rebert
d35973c2b3
js/tests/unit/scrollspy.js: Fix "offsed" typos ( #19985 )
...
[skip sauce]
[skip validator]
2016-05-29 18:36:09 -07:00
XhmikosR
4bca0f878a
Merge pull request #19894 from twbs/v4-dev-jquery223
...
Update jQuery to v2.2.4.
2016-05-26 15:40:02 +03:00
XhmikosR
a950d5642b
Update jQuery to v2.2.4.
2016-05-26 15:26:12 +03:00
akai
4d1b9d7ce7
Remove stray "~" in modal paddingRight value ( #19932 )
...
[skip validator]
2016-05-18 13:53:01 -07:00
Patrick H. Lauke
b107e3342a
Handle aria-hidden on modal container when showing/hiding
...
Fixes #19878
2016-05-11 02:01:56 +01:00
Mark Otto
932d0aa068
grunt
2016-05-08 13:43:13 -07:00
Chris Rebert
afdd62d161
Modal: Remove IE8-specific window.innerWidth workaround
...
[skip validator]
2016-04-21 01:15:24 -07:00
XhmikosR
8a878c1f7b
Update jQuery to v2.2.2.
2016-03-19 15:21:12 +02:00
Michael J. Ryan
681d390a05
Update tooltip.js
...
match project's style check
2016-03-14 13:29:03 -07:00
Michael J. Ryan
1a23279237
Update tooltip.js
...
Don't reference `Tether` via attachment to `window`, with the update one can import bootstrap providing the dependencies in webpack with:
```
new webpack.ProvidePlugin({
$: 'jquery',
jQuery: 'jquery',
Tether: 'tether',
});
```
Then inside one's own bootstrap/globals, `import 'bootstrap';` will simply work, and $/jQuery can be used from there.
I had wanted to do this, but also expose jQuery, Tether, etc when in development build in my code, but if I provide `window.Tether`, I can't then expose it to the outside...
2016-03-14 13:18:08 -07:00
Chris Rebert
25cf50a4ac
JS visual tests: Remove usages of defunct .page-header class
...
[skip sauce]
2016-02-27 18:01:12 -08:00
XhmikosR
96cafe2d2d
Update tether to v1.2.0.
...
[skip sauce]
[skip validator]
2016-02-27 13:56:40 +02:00
XhmikosR
255e89b241
Run grunt.
...
[ci skip]
2016-02-19 13:14:47 +02:00
XhmikosR
79067a6440
Fix validation errors.
...
[skip sauce]
2016-02-19 11:26:54 +02:00
Patrick H. Lauke
701b12bf58
Replace jQuery with vanilla JS
2016-02-17 15:21:02 +00:00
Mark Otto
3b84ffcc54
grunt
2016-02-16 20:09:57 -08:00
Patrick H. Lauke
83217479c3
Visual/manual test for checkbox/radio button kbd behavior
2016-02-16 21:24:29 +00:00
Patrick H. Lauke
a496cb8be4
Focus (visually hidden) input radio/checkbox
...
This allows for keyboard navigation (e.g. arrow keys left/right to
trigger different radio buttons) following an initial mouse click
interaction
2016-02-16 14:29:59 +00:00
Chris Rebert
ff4792fcef
js/tests/index.html: Replace jQuery event alias methods with functions that throw explanatory errors, instead of with undefined
...
Refs https://github.com/twbs/bootstrap/pull/19219#issuecomment-184653699
[skip validator]
2016-02-16 04:05:41 -08:00
Mark Otto
0e70c6a37f
Merge branch 'v4-dev' of https://github.com/twbs/bootstrap into v4-dev
2016-02-03 19:23:29 -08:00
Johann-S
14ec4fdfc1
Carousel - Do not prevent on keydown for input and textarea
2016-02-01 00:06:07 +01:00
Chris Rebert
f2d77b674c
scrollspy.js: Avoid gratuitous non-ASCII for consistency+compatibility
...
Fixes #19028
[skip sauce]
[skip validator]
2016-01-26 11:58:40 -08:00
Kotas Vlastimil
866e99b00c
Button toggling - trigger change event on input
...
Bootstrap’s .button styles can be applied to other elements, such as labels, to provide checkbox or radio style button toggling.
When the checkbox or radio state is changed, there should be triggered the change event. Currently, the change event is triggered on the Button, which is not correct. Only input fields do support the change event.
2016-01-14 20:26:32 +01:00
Chris Rebert
422ed9ab48
grunt dist docs
...
[ci skip]
2016-01-01 12:37:52 -08:00
Chris Rebert
5deb734b53
ESLint: enable no-bitwise rule
...
[skip sauce]
2015-12-24 18:53:41 -07:00
Chris Rebert
ad4c0ee52f
Exempt getUID() from ESLint's no-bitwise rule
...
[skip sauce]
[skip validator]
2015-12-24 18:53:08 -07:00
Chris Rebert
74f1d3b9b8
Merge pull request #18393 from twbs/dropdown-bitwise-less-tricksy
...
dropdown.js: Use more straightforward phrasing for index bound check
2015-12-24 08:16:19 -07:00
Chris Rebert
d30310feae
Merge pull request #18638 from twbs/fix-18365
...
Modal: Ignore spurious focus event that Firefox fires at document when switching back to its tab
2015-12-24 08:15:27 -07:00
XhmikosR
612ff4f5d1
Run grunt
.
...
[ci skip]
2015-12-24 12:50:15 +02:00
Chris Rebert
d12ed5520e
Modal: Ignore spurious focus
event that Firefox fires at document
when switching back to its tab
...
Fixes #18365
Refs https://bugzilla.mozilla.org/show_bug.cgi?id=1228802
2015-12-22 23:08:03 -07:00
Chris Rebert
2c69e0f810
Add visual test for #18365
...
See also https://bugzilla.mozilla.org/show_bug.cgi?id=1228802
2015-12-22 23:08:03 -07:00
Chris Rebert
96e9205009
js/tests/unit/modal.js: Fix typo
...
[ci skip]
2015-12-22 17:11:21 -07:00
Chris Rebert
31d4139a74
Update version numbers using npm script
...
Errata from:
* 8ce5da3026
* 5d3144e8fb
which missed a few numbers.
[skip sauce]
[skip validator]
2015-12-08 18:16:47 -08:00
Mark Otto
5d3144e8fb
manually bump versions because npm script wasn't working for me
2015-12-08 09:36:08 -08:00
XhmikosR
b7b448a0e7
Run grunt
.
...
[ci skip]
2015-12-05 12:59:13 +02:00
Chris Rebert
75c39f9138
Fix version numbers is JS files; fixes #18435
...
[skip sauce]
[skip validator]
2015-12-05 02:19:46 -08:00
XhmikosR
34a0ce571e
Run grunt
.
...
[ci skip]
2015-12-05 11:43:23 +02:00
XhmikosR
92d0a71fb6
Merge pull request #18391 from twbs/double-bitwise-not-comment
...
util.js: Add comment explaining ~~ trick
2015-12-05 10:37:27 +02:00
XhmikosR
8a1685fdee
Run grunt
.
...
[ci skip]
2015-12-03 08:51:57 +02:00
XhmikosR
79a4273891
Tweak ESLint rules.
2015-12-03 08:41:46 +02:00
XhmikosR
e55fcbcdfe
tests: bump QUnit to v1.20.0.
...
[skip validator]
2015-12-03 08:41:46 +02:00
Chris Rebert
31ca64232d
dropdown.js: Use more straightforward phrasing for index lower bound check
...
[skip sauce]
[skip validator]
2015-11-30 23:59:39 -08:00
Chris Rebert
a887a1207c
util.js: Add comment explaining ~~ trick
...
[skip sauce]
[skip validator]
2015-11-30 23:47:56 -08:00
Chris Rebert
580e2f7845
Remove stray </p> from js/tests/visual/scrollspy.html
...
[skip sauce]
2015-11-19 01:50:20 -08:00
XhmikosR
eea6690d0e
Run grunt
.
...
[ci skip]
2015-11-16 10:03:57 +02:00
Jacob Thornton
ece98f980c
add undefined for now
2015-11-14 20:43:45 -08:00
Jacob Thornton
d600831a15
add explicit error for lack of tether in tooltips - fixes #17273
2015-11-14 20:35:10 -08:00
Jacob Thornton
186c1c6d80
Merge branch 'v4-dev' of https://github.com/lincolndbryant/bootstrap into lincolndbryant-v4-dev
2015-11-14 19:49:48 -08:00
XhmikosR
a291d79ecb
Run grunt
.
...
[ci skip]
2015-11-11 09:00:47 +02:00
Jon Tewksbury
2d87ec9a64
Add eslint no-undef rule and resolve errors
2015-11-03 15:04:26 -08:00
Chris Rebert
1dc8583bc5
grunt dist
2015-10-29 22:08:31 -07:00
XhmikosR
7a85751144
Remove html5shiv and respond.js from test files.
2015-10-26 23:57:19 +02:00
XhmikosR
a50849f61b
Switch to jQuery 2.1.4.
...
Now that we don't support IE 8 it's safe to do that.
2015-10-24 19:09:33 +03:00
Henry Zhu
8924b5044e
update grunt-jscs to 2.1.0 to use jscs 2.x
2015-10-19 08:17:13 -04:00
XhmikosR
724bf86288
Run grunt
.
...
[ci skip]
2015-10-14 00:49:31 +03:00
Johann-S
817d997b75
Use Page Visibility API in Carousel; fixes #17706
...
Avoids cycling carousels when the page isn't visible.
Closes #17710
Refs #15566
2015-10-11 15:10:49 -07:00
Chris Rebert
b74536fa8c
grunt dist
2015-10-09 21:03:57 -07:00
Chris Rebert
10f6e97ec2
Merge pull request #17616 from Johann-S/ThrowError
...
Fix #17612 : Throw explicit error when a nonexistent method is invoked
2015-10-02 01:18:16 -07:00
Johann-S
21a65f181e
Add throw error for undefined method on plugins
2015-10-02 10:01:24 +02:00
XhmikosR
22c8c1e887
Specify root: true
for ESLint.
...
That way, ESLint won't look in parent dirs for configuration files.
2015-09-24 20:24:38 +03:00
XhmikosR
b93c16341d
Run grunt
.
2015-09-23 09:39:13 +03:00
Johann-S
6d451ad99d
Change destroy -> dispose
2015-09-16 09:46:55 +02:00
Johann-S
32f9a5d6a5
fix resetting style on closing collapse
2015-09-11 10:45:08 +02:00
Johann-S
8ece899ba8
Add tests about padding restoration
2015-09-10 08:19:59 +02:00
XhmikosR
f0840c893b
Run grunt
.
2015-09-05 08:13:43 +03:00
muzige2000
3af4560c67
Modals: Fix bad paddingRight calculation; fixes #17399
...
We want to sum two numbers, not concatenate their stringifications.
Closes #17457 by merging a tweaked version of it.
2015-09-03 01:25:38 -07:00
Gleb Mazovetskiy
c7d8e7a077
Accept elements as the tooltip / popover content
...
When a DOM node is passed to an HTML tooltip, the `title` node is only
moved if it is not already in the tooltip. Otherwise, `empty()` is used
instead of `detach()` before appending the `title` to avoid memory
leaks. If a DOM node is passed to a plain text tooltip, its text is
copied via jQuery `.text()`.
Replaces `.detach()` with `.empty()`, as `.detach()` is almost never
useful but instead leaks memory. The difference between `empty` and
`detach` is that the latter keeps all the attached jQuery events/data.
However, since we do not return the previous children, the user would
have to keep these themselves, thus they can `detach()` if necessary.
This is a port of https://github.com/twbs/bootstrap/pull/14552 to v4.
2015-08-31 01:06:13 +01:00
XhmikosR
4dd9a5a6dc
Update QUnit to v1.18.0.
2015-08-27 08:15:19 +03:00
XhmikosR
13e33e329c
Remove the obsolete JSHint references.
2015-08-27 08:11:11 +03:00
Bernardo Gurgel Filho
8ef66df6d7
Convert popover's arrows to generated CSS content via :before/:after
2015-08-26 17:20:01 -03:00
Bernardo Gurgel Filho
2ae5fdf9dd
Convert tooltip's arrows to generated CSS content via :before
2015-08-26 17:20:01 -03:00
Chris Rebert
d06f79e2f7
grunt babel:dev
2015-08-26 01:27:45 -07:00
Jelle Versele
54c4eb950b
fixes #17097 : Go back to using jQuery's text and html methods since innerText is nonstandard and not present in Firefox
...
Closes #17272 by merging a tweaked version of it.
[skip validator]
2015-08-26 01:00:46 -07:00
XhmikosR
7e2eb9e74a
js/.eslintrc: sort rules by name.
...
[ci skip]
2015-08-25 08:45:07 +03:00
Heinrich Fenkart
73a88dbe86
Docs: Update all dropdowns to new HTML structure
2015-08-21 00:18:55 +02:00
Boris Kaiser
463837c1c7
Remove duplicate "spaced-comment" in eslintrc
...
Closes #17100
2015-08-20 01:27:47 -07:00
lbryant
8b15b5a262
_removeTetherClasses is no longer referenced
2015-08-20 01:22:16 -04:00
lbryant
926fb11158
use Tether addTargetClasses: false option instead of manually removing them
2015-08-20 01:03:29 -04:00
Jacob Thornton
03e732708c
rewrite tab with new active shit
2015-08-18 22:03:34 -07:00
Jacob Thornton
4e45e2363c
Merge branch 'v4' of github.com:twbs/derpstrap into v4
2015-08-18 21:23:53 -07:00
Jacob Thornton
fd65b9f32e
some minor alert shit
2015-08-18 20:33:57 -07:00
Mark Otto
1c19ded8c1
Merge branch 'v4' of https://github.com/twbs/derpstrap into v4
2015-08-18 20:25:48 -07:00
Jacob Thornton
8cfde5ef29
fix modal visual example for js
2015-08-18 19:50:32 -07:00
Jacob Thornton
efae761c39
fix dropdown js visual example
2015-08-18 19:42:27 -07:00
Jacob Thornton
18ff57a183
js tests passing + eslint
2015-08-18 19:22:46 -07:00
Mark Otto
15b7ce59df
grunt
2015-08-18 18:45:12 -07:00
Jacob Thornton
f1827e5f9c
add polyfil for bind for tether.js
2015-08-18 17:06:17 -07:00
Jacob Thornton
19e43b62ed
use proxy not bind in alert
2015-08-18 17:01:56 -07:00
Jacob Thornton
05c7a37507
fix dropdown test
2015-08-15 12:17:13 -07:00
Jacob Thornton
c830956d17
change modal.js to use is-fixed classes to target padding-right
2015-08-15 12:10:24 -07:00
Jacob Thornton
11abb0f7e9
fix modal
2015-08-12 21:12:03 -07:00
Jacob Thornton
23d05f1585
get the js working for docs
2015-08-12 19:59:55 -07:00
Mark Otto
1ddc3f5e21
Merge branch 'master' into v4m
2015-08-04 22:29:45 -07:00
Johann-S
ef1ce9ac0b
Fix triggering of {shown,hidden}.bs.dropdown events so relatedTarget gets set properly
...
Fixes #16828
Closes #16865
2015-07-27 00:58:51 -07:00
Melinda Sarnicki Bernardo
cebea5b6f6
Removes unnecessary period at end of comment
2015-07-02 19:30:11 -07:00
Mark Otto
169d2a4a78
Merge branch 'master' into v4
2015-06-18 23:56:43 -07:00
Mark Otto
83bfff7f07
bump version
2015-06-16 09:10:22 -07:00
Patrick H. Lauke
5fd7bc1554
generalize dropdowns / drop role="menu"
...
as role="menu" is a very specific (and strict) ARIA pattern for
desktop-like application menus, and our dropdowns are often used
as pure navigation dropdowns, this change abandons ARIA menus for
a more open-ended and light-weight approach
(see http://heydonworks.com/practical_aria_examples/#submenus and
http://www.w3.org/WAI/tutorials/menus/flyout/#improve-screen-reader-support-using-wai-aria )
note that in dropdown.js, switched to now target ``.dropdown-menu``
instead of ``role["menu"]`` - this also prevents bootstrap scripts
from "bleeding" into non-bootstrap components on the same page.
also removed the ``role=["listbox"]`` part, which appears to be
vestigial/unused (only place in bootstrap that uses that
role are carousels, and their key handling is done separately)
2015-06-02 11:03:21 +01:00
XhmikosR
315907c97c
Use https
when possible.
2015-05-17 12:43:20 +03:00
fat
6b2b0ed32f
al tests passing, dist rebuilt, w/typechecker
2015-05-13 14:52:46 -07:00
fat
eaab1def7a
add simple type checker implementation
2015-05-13 14:46:50 -07:00
fat
c2ced2292a
fix up tests
2015-05-13 13:46:08 -07:00
fat
b0d142334f
fix #15301
2015-05-13 13:43:56 -07:00
fat
7ef0e52fd0
add "focus" option for turning off modal focusing #16050
2015-05-13 13:22:26 -07:00
fat
da495ee24c
address https://github.com/twbs/bootstrap/pull/16135
2015-05-13 13:15:11 -07:00
fat
f8b2569ec8
implement global dispose method
2015-05-13 12:48:34 -07:00
fat
6b251582d6
update attachment -> placement
2015-05-12 16:54:21 -07:00
fat
ab1578465a
grunt test-js, grunt dist-js now working
2015-05-12 16:52:54 -07:00
fat
a58febf71a
popover passing as well
2015-05-12 14:35:00 -07:00
fat
3452e8dc83
rewritten tooltip + tether integration and death to our positioner jank
2015-05-11 23:32:37 -07:00
fat
8eee78ca15
tab es6
2015-05-11 12:29:06 -07:00
fat
2d91494d96
scrollspy es6
2015-05-11 12:05:35 -07:00
fat
ca9c850ebb
add getters for Version and Default where applicable
...
add modal my gawd
2015-05-10 19:45:38 -07:00
fat
bbb97a8660
add dropdown
2015-05-10 13:47:11 -07:00
fat
8bab38bb71
add collapse
2015-05-09 23:04:58 -07:00
XhmikosR
1eba173c9e
Update jQuery to v1.11.3.
2015-05-10 01:22:23 +03:00
fat
1b183e2ff7
carousel -> es6
2015-05-07 22:26:40 -07:00
fat
6605051882
button -> es6
2015-05-07 17:14:38 -07:00
fat
c3a79b1a8c
change the export pattern to protect against leaking globals
2015-05-07 16:34:28 -07:00
fat
0724bd91ff
es6 alert :|
2015-05-07 12:57:31 -07:00
fat
d1fbe200f4
remove closureness from plugins
2015-05-06 13:34:14 -07:00
XhmikosR
a2f81ceb57
phantom.js: switch to unicode characters that work on Windows too.
2015-05-05 06:58:54 +03:00
XhmikosR
49c4556354
Comply to the new JSCS rules.
2015-05-05 06:50:18 +03:00
XhmikosR
93785be2c6
Update JSCS rules.
2015-05-05 06:50:18 +03:00
Chris Rebert
aa2c5b5672
Merge pull request #16014 from redbmk/issue-16008
...
Multiple tooltip triggers don't play well together
2015-05-04 15:07:17 -07:00
Patrick H. Lauke
a254782ca4
Merge pull request #16404 from patrickhlauke/radio-checkbox-kbd-toggle-fix
...
Fix radio and checkbox keyboard handling in .btn-group
2015-05-03 17:05:12 +01:00
Carlo Stearns
0689117f13
Fix issue where affixed element has incorrect positioning
...
when used with a sticky footer layout.
Adds visual test for affix with sticky footer.
Closes #15694 .
Refs #15032 .
2015-05-02 17:59:31 -07:00
Patrick H. Lauke
0c1daaf2ce
Remove broken/vestigial unit test
...
Overall logic for this test appears broken, possibly relating to an
older version of Bootstrap that did not require explicit
`data-toggle="button"` on single toggle buttons?
2015-05-01 12:58:10 +01:00
Patrick H. Lauke
f9cd88e09f
Fix radio and checkbox keyboard handling
...
Fix for problem that emerged from #16226 (`.active` class not actually
being applied) and expansion of the script to also correctly handle
keyboard interaction with checkboxes in `data-toggle="button"` groups
2015-05-01 12:19:19 +01:00
XhmikosR
3e7ca3bbc8
Minor lint tweaks.
2015-04-28 11:03:37 +03:00
Braden M. Kelley
4b269037cb
Multiple tooltip triggers don't play well together
...
Fixes issue #16008
2015-04-27 23:03:56 -07:00
F A T
aa479892d5
Merge pull request #16152 from jarthod/tooltip-placement-viewport-fix
...
Tooltip/popover: Fix auto placement to use viewport
2015-04-27 11:28:54 -07:00
Chris Rebert
cdb37dce3a
Set box-sizing: border-box
on .container-viewport in #16142 testcase
...
Otherwise, the test doesn't properly fail when the fix is reverted.
2015-04-27 01:23:39 -07:00
Adrien
37a10d37c1
Compare tooltip right offset to viewport right offset (and not width)
...
Closes #16142 by merging it.
2015-04-27 01:13:16 -07:00
Chris Rebert
fc372952e2
Throw error when tooltip/popover template has multiple top-level elements
...
Closes #16219 .
2015-04-25 13:16:53 -07:00
Chris Rebert
0d77644fc4
throw error when trying to show tooltip on :hidden element
2015-04-23 17:14:45 -07:00
Adrien Siami
e949505b89
Allow viewport option to be a function
...
Closes #16151 by merging a rebased version of it that adds docs and 1 more assertion.
2015-04-21 22:20:15 -07:00
Chris Rebert
c6b62f0cd9
Merge pull request #16147 from Johann-S/event_inserted
...
Fixes #16124 .
2015-04-21 21:40:14 -07:00
Niels Steenbeek
7429fc7ff9
Tooltip: Destroy $tip, $arrow, $viewport to avoid memory leak
...
Closes #16039 .
2015-04-20 23:29:31 -07:00
Patrick H. Lauke
8549722846
Merge pull request #16226 from patrickhlauke/radio-toggle-kbd-fix
...
Fix radio button toggle behavior for keyboard users
2015-04-17 18:19:11 +02:00
Patrick H. Lauke
66d71136e6
Fix existing radio button unit test
2015-04-11 19:24:21 +02:00
Patrick H. Lauke
1b9baa0d98
Don't preventDefault radio buttons
...
as this breaks keyboard navigation for radio button toggles (see
https://github.com/twbs/bootstrap/issues/16223 )
2015-04-11 19:21:55 +02:00
Chris Rebert
b8935a5d0c
Use .dropdown-menu instead of ARIA roles for dropdown keydown event handler; fixes #16090
2015-04-08 19:20:15 -07:00
Johann-S
3d71eae301
Add event after template inserted
2015-04-08 13:10:53 +02:00
Adrien Jarthon
5921724d9c
fixed IE incompatible CSS
2015-03-29 19:16:59 +02:00
Adrien Jarthon
df96c3e615
Added non-regression test & fixed existing one
2015-03-29 14:59:21 +02:00
Mark Otto
58082cd83e
Merge branch 'master' into v4
...
Conflicts:
.gitignore
Gruntfile.js
_config.yml
dist/css/bootstrap-theme.css
dist/css/bootstrap-theme.min.css
dist/css/bootstrap.css
dist/css/bootstrap.css.map
dist/css/bootstrap.min.css
dist/js/bootstrap.js
dist/js/bootstrap.min.js
docs/_includes/components/navbar.html
docs/_includes/components/progress-bars.html
docs/_includes/css/grid.html
docs/_includes/css/overview.html
docs/_includes/customizer-variables.html
docs/_includes/getting-started/accessibility.html
docs/_includes/getting-started/browser-device-support.html
docs/_includes/getting-started/community.html
docs/_includes/getting-started/disabling-responsiveness.html
docs/_includes/getting-started/download.html
docs/_includes/getting-started/examples.html
docs/_includes/getting-started/license.html
docs/_includes/getting-started/third-party-support.html
docs/_includes/js/alerts.html
docs/_includes/js/buttons.html
docs/_includes/js/carousel.html
docs/_includes/js/collapse.html
docs/_includes/js/dropdowns.html
docs/_includes/js/modal.html
docs/_includes/js/popovers.html
docs/_includes/js/scrollspy.html
docs/_includes/js/tabs.html
docs/_includes/js/tooltips.html
docs/_includes/js/transitions.html
docs/_includes/nav/javascript.html
docs/_includes/nav/main.html
docs/about.html
docs/assets/css/docs.min.css
docs/assets/css/src/docs.css
docs/assets/js/customize.min.js
docs/assets/js/raw-files.min.js
docs/assets/js/src/customizer.js
docs/dist/css/bootstrap-theme.css
docs/dist/css/bootstrap-theme.min.css
docs/dist/css/bootstrap.css
docs/dist/css/bootstrap.css.map
docs/dist/css/bootstrap.min.css
docs/dist/js/bootstrap.js
docs/dist/js/bootstrap.min.js
docs/migration.html
js/affix.js
js/alert.js
js/button.js
js/carousel.js
js/collapse.js
js/dropdown.js
js/modal.js
js/popover.js
js/scrollspy.js
js/tab.js
js/tests/unit/affix.js
js/tests/unit/button.js
js/tests/unit/carousel.js
js/tests/unit/modal.js
js/tests/unit/tooltip.js
js/tests/visual/modal.html
js/tooltip.js
less/component-animations.less
less/jumbotron.less
less/mixins/background-variant.less
less/mixins/buttons.less
less/mixins/responsive-visibility.less
less/mixins/text-emphasis.less
less/navbar.less
less/navs.less
less/scaffolding.less
less/tooltip.less
less/utilities.less
less/variables.less
package.json
scss/_buttons.scss
scss/_forms.scss
scss/_modal.scss
2015-03-29 00:08:54 -07:00
Heinrich Fenkart
da63ff2e95
JSCS: Add "disallowSpacesInFunctionDeclaration"
...
Valid:
function a() {}
Invalid:
function a () {}
2015-03-26 18:28:17 +01:00
Chris Rebert
6c5e7dfce1
rm redundant aria-hidden usage from Modals; fixes #16020
2015-03-25 18:06:47 -07:00
Adrien Jarthon
0e8e5222ff
Tooltip/popover: Fix auto placement to use viewport
...
Currently, auto placement is using the container dimensions (if provided) or the element's parent to determine where to open the tooltip:
```javascript
var $container = this.options.container ? $(this.options.container) : this.$element.parent()
var containerDim = this.getPosition($container)
```
This is quite broken in fact, because the parent element could be just a small div outside the element for example, leading in a totally random placement (placing the tooltip on top even if there's no room). And the container can also be outside of the viewport.
This fix simply uses the viewport instead, that's the purpose of the viewport actually, to position the tooltip.
So the auto placement should use it to find where there's more room.
By default this is body, which is good.
2015-03-25 18:05:58 +01:00
Chris Rebert
d37bc2ae65
Merge pull request #15987 from twbs/fix-15972
...
add role="button" to a[data-toggle="collapse"]
2015-03-24 08:57:56 -07:00
Emmanuel Bourgerie
fa9d28b634
Fix #16072 : Clicking into input field within dropdown no longer closes the dropdown
...
Closes #16073 by merging it
2015-03-21 16:00:15 -07:00
Chris Rebert
9aad9a4164
Merge pull request #16024 from twbs/unnecessary-parsing
...
avoid unnecessary HTML string building+parsing
2015-03-18 22:28:07 -07:00
Chris Rebert
4d652035dc
v3.3.2 => v3.3.4
2015-03-16 08:39:31 -07:00
Maxim Andrukhovych
83371735fc
Fixed proper navigation element selection on backward scrolling (from the bottom to the top)
2015-03-10 20:04:15 +00:00
Chris Rebert
1383b88328
Merge pull request #16012 from twbs/refs-12761
...
Disable jQuery event aliases when running test suite
2015-03-09 17:47:51 -07:00
Chris Rebert
a14665e73e
avoid unnecessary HTML string building+parsing
2015-03-09 06:47:34 -07:00
Chris Rebert
a5243ad3d0
Affix: $('body') => $(document.body)
2015-03-09 06:43:41 -07:00
Chris Rebert
725c6848c3
Disable jQuery event aliases when running test suite
...
To ensure that we don't accidentally use any of the aliases.
This should prevent any future regressions from #12761 .
Also updates the test suite since it now can't use these aliases either.
2015-03-09 01:05:43 -07:00
Chris Rebert
21d56378e1
Merge pull request #16011 from twbs/fix-15315
...
.collapse('hide') on hidden uninit-ed collapsible no longer shows it
2015-03-09 01:03:27 -07:00
Chris Rebert
a134491fe5
add togglable scrollbar-inducing content to Modal visual test
2015-03-07 06:40:57 -08:00
Chris Rebert
6ddb8c2dd7
add static navbar to Modal visual test
2015-03-07 06:39:46 -08:00
Chris Rebert
64ca888cbc
Merge pull request #15999 from twbs/kkirsche-includeTestsReadme
...
Document JS test suite basics
2015-03-06 23:28:30 -08:00
Kevin Kirsche
ba2f7e92d0
[ Fixes #15951 ] Document JS test suite basics
...
X-Ref: #15953
Closes #15952 by merging a tweaked version of it.
[skip sauce]
[skip validator]
2015-03-06 23:27:00 -08:00
Chris Rebert
5c8d56d515
Collapse unit test: rm check that no-op hide adds style="height: 0px"
...
Appears to be unnecessary and is broken by #16011 ,
which is otherwise quite sane.
2015-03-06 18:10:53 -08:00
Chris Rebert
872e56fcf2
.collapse('hide') on hidden uninit-ed collapsible no longer shows it; fixes #15315
...
Thanks to @peterblazejewicz & @Nikita240
Adds unit tests based on #14417
X-Ref: #14282
Closes #15807
2015-03-06 06:58:48 -08:00
Chris Rebert
27bbc7dbe9
Hiding an uninitialized tooltip/popover no longer initializes it; fixes #15874
2015-03-03 22:22:13 -08:00
Chris Rebert
cc39f5c52d
add role="button" to a[data-toggle="collapse"]; fixes #15972
2015-03-03 13:18:36 -08:00
Chris Rebert
168297c779
rm semicolon for sake of fat's eccentric tastes
...
Erratum from #15496
2015-03-03 13:06:32 -08:00
Heinrich Fenkart
420a8088a4
Merge pull request #15961 from kkirsche/ImplementAssertExpect
...
[Fixes #15953 ] Implement assert.expect in each unit test
2015-03-03 15:52:05 +01:00
Kevin Kirsche
4febcb4b49
[ Fixes #15953 ] Implement assert.expect in each unit test
...
[Fixes #15953 ] Implement `assert.expect` in each unit test
2015-03-03 08:45:07 -05:00
Heinrich Fenkart
f5beebe726
Modal: Fix backdrop not readjusting when height changes
...
Fixes #15136 .
Closes #15345 .
Closes #15314 .
Refs #14724 , #14927 .
2015-03-03 05:27:26 +01:00
Chris Rebert
46f5a8f478
Merge pull request #15970 from twbs/the-future-is-now-qunit
...
Disable deprecated QUnit global methods
2015-03-02 02:39:29 -08:00
XhmikosR
f8e34ff48b
Disable es3 for tests and customizer.js.
2015-03-02 11:16:06 +02:00
Chris Rebert
c291c12cb1
Disable deprecated global QUnit method aliases to prevent backsliding on QUnit v2 readiness
2015-03-01 19:50:11 -08:00
Chris Rebert
c80872235f
Merge pull request #15955 from twbs/fixture-on-screen-ios
...
Unit tests: Only display fixture on-screen for iOS
2015-03-01 18:28:46 -08:00
Chris Rebert
015e63f6df
Merge pull request #15593 from neoeno/handle_multiple_zero_offset_scrollspy_elements
...
Handle multiple zero-offset Scrollspy elements.
2015-03-01 16:04:04 -08:00
Caden Lovelace
a1aa0f8afd
Handle multiple zero-offset Scrollspy elements.
...
When the first two elements in a scrollspy content block have a document
offset of zero (i.e. they're hard against the top of the page),
Scrollspy would switch between them on every scroll event.
This could happen, for example, in a system of nested sections:
```
<section id="animals">
<section id="dogs">
Content
</section>
</section>
```
This ocurred because Scrollspy's check to see if it's at the end of the
array of sections uses `!arr[index]`. This misses the case where
`arr[index]` does exist and is zero.
This commit explicitly checks the array bounds.
2015-03-01 23:55:39 +00:00
Mark Otto
c16fee5efd
Merge branch 'master' into v4
...
Conflicts:
.travis.yml
Gruntfile.js
bower.json
dist/css/bootstrap.css
dist/css/bootstrap.css.map
dist/css/bootstrap.min.css
dist/js/bootstrap.js
dist/js/bootstrap.min.js
docs/_data/glyphicons.yml
docs/_includes/components/breadcrumbs.html
docs/_includes/components/button-dropdowns.html
docs/_includes/components/button-groups.html
docs/_includes/components/dropdowns.html
docs/_includes/components/glyphicons.html
docs/_includes/components/labels.html
docs/_includes/components/list-group.html
docs/_includes/components/media.html
docs/_includes/components/navs.html
docs/_includes/components/panels.html
docs/_includes/components/progress-bars.html
docs/_includes/components/thumbnails.html
docs/_includes/components/wells.html
docs/_includes/css/buttons.html
docs/_includes/css/forms.html
docs/_includes/css/helpers.html
docs/_includes/css/images.html
docs/_includes/css/less.html
docs/_includes/customizer-variables.html
docs/_includes/getting-started/accessibility.html
docs/_includes/getting-started/browser-device-support.html
docs/_includes/getting-started/community.html
docs/_includes/getting-started/examples.html
docs/_includes/getting-started/grunt.html
docs/_includes/getting-started/license.html
docs/_includes/getting-started/template.html
docs/_includes/header.html
docs/_includes/js/affix.html
docs/_includes/js/alerts.html
docs/_includes/js/carousel.html
docs/_includes/js/collapse.html
docs/_includes/js/dropdowns.html
docs/_includes/js/modal.html
docs/_includes/js/overview.html
docs/_includes/js/popovers.html
docs/_includes/js/scrollspy.html
docs/_includes/js/tabs.html
docs/_includes/js/tooltips.html
docs/_includes/js/transitions.html
docs/_includes/nav/javascript.html
docs/_layouts/default.html
docs/assets/css/docs.min.css
docs/assets/css/src/docs.css
docs/assets/js/customize.min.js
docs/assets/js/docs.min.js
docs/assets/js/raw-files.min.js
docs/assets/js/vendor/FileSaver.js
docs/assets/js/vendor/autoprefixer.js
docs/assets/js/vendor/uglify.min.js
docs/dist/css/bootstrap.css
docs/dist/css/bootstrap.css.map
docs/dist/css/bootstrap.min.css
docs/dist/js/bootstrap.min.js
docs/examples/blog/index.html
docs/examples/carousel/index.html
docs/examples/cover/index.html
docs/examples/dashboard/index.html
docs/examples/narrow-jumbotron/narrow-jumbotron.css
docs/examples/navbar-fixed-top/index.html
docs/examples/navbar-static-top/index.html
docs/examples/non-responsive/index.html
docs/examples/non-responsive/non-responsive.css
docs/examples/theme/index.html
grunt/configBridge.json
js/affix.js
js/carousel.js
js/collapse.js
js/dropdown.js
js/modal.js
js/popover.js
js/scrollspy.js
js/tab.js
js/tests/unit/affix.js
js/tests/unit/button.js
js/tests/unit/carousel.js
js/tests/unit/modal.js
js/tests/unit/tooltip.js
js/tooltip.js
less/badges.less
less/glyphicons.less
less/type.less
less/variables.less
package.json
scss/_dropdown.scss
scss/_forms.scss
test-infra/npm-shrinkwrap.json
2015-03-01 13:44:10 -08:00
Heinrich Fenkart
20fb55a840
Unit tests: Only display fixture on-screen for iOS
...
Since only on iOS tests fail when the fixture is displayed off-screen, see https://travis-ci.org/twbs/bootstrap/jobs/52605742
2015-03-01 09:49:59 +01:00
Heinrich Fenkart
4345e24479
Use different way to make failing test more visible in Sauce
2015-03-01 09:20:00 +01:00
Ivan Cheung
d5071b19f1
Update all collapse triggers with .collapsed class and aria-expanded
...
Fixes #15741
Closes #15751 by merging it.
2015-02-26 18:48:20 -08:00
Chris Rebert
9afb61fffd
QUnit.jsDump => QUnit.dump
...
Refs http://qunitjs.com/upgrade-guide-2.x/#replace-qunit-jsdump-with-qunit-dump
2015-02-25 23:29:27 -08:00
Chris Rebert
4ff9c54cdd
Use QUnit.log(...) instead of QUnit.log = ...
...
Refs http://qunitjs.com/upgrade-guide-2.x/#replace-qunit-log-callback-with-qunit-log-callback-for-all-reporting-callbacks
2015-02-25 23:29:27 -08:00
Heinrich Fenkart
3bb05b5fbb
Unit tests: Use new names of module hooks
...
Refs #15893
2015-02-26 08:20:42 +01:00