GeoSot
7b7f4a5ced
Decouple Modal's scrollbar functionality ( #33245 )
2021-04-11 09:37:59 +03:00
Rohit Sharma
9bca1b5a8b
Remove unnecessary data-bs-backdrop="static" ( #33578 )
...
Since the value for the `backdrop` option is available in the configuration object.
2021-04-08 08:20:21 +03:00
GeoSot
752b001b0a
Simplify Modal config
2021-04-06 18:43:43 +03:00
Muhammadamin
056216a3bd
modal: don't add margin & padding when sticky is not full width ( #30621 )
...
* modal: don't add margin & padding when sticky is not full width
* Check if element is shorter than window
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Rohit Sharma <rohit2sharma95@gmail.com>
2021-02-23 14:52:09 +02:00
Rohit Sharma
dc5e3328c1
Allow constructors to accept a CSS selector ( #32245 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <otto@github.com>
2021-02-22 09:01:04 +02:00
GeoSot
3602828a90
Add tests for DATA_KEY ( #33090 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-16 08:58:08 +02:00
Rohit Sharma
c9cd741aff
Throw a TypeError instead of the generic Error ( #32585 )
...
* Change from Error to TypeError
* Convert the `NAME` to upper case to make the consistency in the error message
* Update the remaining tests to be stricter
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-13 22:13:30 +02:00
Rohit Sharma
e34481b6eb
Fix toggling modal when clicking on data-bs-toggle="modal" ( #32691 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-13 21:59:47 +02:00
XhmikosR
51a208f119
Switch to Jasmine's toBeInstanceOf matcher
2020-11-29 20:58:26 +02:00
Johann-S
9f6b342dc7
create a base component
2020-11-29 20:58:26 +02:00
Rohit Sharma
358c36d4b5
Add missing tags in unit tests ( #32221 )
2020-11-20 20:10:15 +02:00
Rohit Sharma
0839cbf04d
Don't hide modal when keyboard is set to false in modal's configuration ( #32179 )
...
* Don't hide modal when config.keyboard is false
* Update unit test
- Modal should not be closed when pressing esc key if keyboard = false
and backdrop is 'static'
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-20 15:36:24 +02:00
XhmikosR
2e758f64cf
Switch to Number properties
2020-11-14 15:54:50 +02:00
Rohit Sharma
418f17ee2b
Add bs in data attributes
...
- Add `bs` in data APIs everywhere
- Update unit tests
2020-11-14 07:09:15 +02:00
XhmikosR
c9f8fa45fb
tests: tweak Jasmine usage ( #32046 )
...
* jasmine/expect-matcher
* jasmine/prefer-jasmine-matcher
Found with `eslint-plugin-jasmine`
2020-11-02 16:13:24 +02:00
Shohei Yoshida
fb4efb49ea
Prevent overflowing static backdrop modal animation ( #30326 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-06-25 11:35:53 +03:00
Rohit Sharma
5faf41eb48
Add role="dialog" in modals via JavaScript ( #30936 )
2020-06-04 10:35:09 +03:00
Dominik Kremer
d59de33fc0
Add a test about the scrollbar issue on non-integer width
2020-05-12 07:51:09 +03:00
XhmikosR
94109cabf4
Add missing closing div tags ( #30775 )
...
Missed those in 967e607
2020-05-11 16:54:56 +03:00
XhmikosR
967e6071ba
tests: streamline HTML end tags ( #30648 )
2020-05-06 09:20:08 +03:00
Tanguy Krotoff
dcd99aa7d1
Replace event.which with event.key and event.button
2020-04-17 18:22:15 +03:00
ysds
dfa017adc3
Always modal scroll top to 0
2020-04-01 10:05:43 +03:00
Johann-S
26d86fce2a
fix: remove make array util function ( #30430 )
2020-03-25 16:35:02 +02:00
XhmikosR
018a94c9c1
Remove Internet Explorer leftovers
2020-03-18 20:59:27 +02:00
Giovanni Mendoza
954a0b1e6a
Close modal with keyboard=true & backdrop=static ( #29986 )
...
* Close modal with keyboard=true & backdrop=static
2020-01-10 11:06:12 +02:00
Higor Araújo dos Anjos
46912797b2
Added animation when modal backdrop is static ( #29516 )
2019-10-25 21:12:09 +03:00
XhmikosR
577bf8b14d
Rename "js/tests/units" to "js/tests/unit". ( #29503 )
2019-10-09 01:27:43 +03:00
